From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 40EF1C43334 for ; Fri, 10 Jun 2022 09:16:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AlULTJIZ8Vvt7wv7O7w+DdwG7IjjGnjwVxbLL1+dCDE=; b=05mQjMMlnI/EyH +raCwr+2s9733QC7MrJN2957+Jb53isDGZ/2nAI+clZiBacfQ0MrrBrgZH2ACK6dPYKvihZIU1ARR 0PSMhd7J87ir1KlnNQPjCanqE+Yo32Gaw7SfstD/8tstaksx9KdLfQzEPFeC2B02OV9D71Kij5k0H fgqqTWVnbpsPitcHSNqYPSZ86tRWOib4jeMUl4jHdiXTKBuQJEB//bDCkFyDjoLFtLwoUhnSI2dBY lJGqKowzpkN+Cf0Di3HgyRMhU4RYhYIQlkgXP09tl/aGh41R5B53qIzBXaKnnc9VsQkpybadsX1iO GhvyEFDrqdXb4SU8ViEA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nzaja-0073dt-Or; Fri, 10 Jun 2022 09:15:14 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nzajX-0073bQ-M8 for linux-arm-kernel@lists.infradead.org; Fri, 10 Jun 2022 09:15:13 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 95C6F61D71; Fri, 10 Jun 2022 09:15:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7AB82C3411C; Fri, 10 Jun 2022 09:15:08 +0000 (UTC) Date: Fri, 10 Jun 2022 10:15:04 +0100 From: Catalin Marinas To: Alejandro Tafalla Cc: Will Deacon , ~postmarketos/upstreaming@lists.sr.ht, Mark Rutland , Mark Brown , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64/sysreg: Fix typo in Enum element regex Message-ID: References: <20220609204220.12112-1-atafalla@dnyon.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220609204220.12112-1-atafalla@dnyon.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220610_021511_801487_E0417EFA X-CRM114-Status: GOOD ( 17.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jun 09, 2022 at 10:42:18PM +0200, Alejandro Tafalla wrote: > In the awk script, there was a typo with the comparison operator when > checking if the matched pattern is inside an Enum block. > This prevented the generation of the whole sysreg-defs.h header. > > Fixes: 66847e0618d7 ("arm64: Add sysreg header generation scripting") > Signed-off-by: Alejandro Tafalla > --- > arch/arm64/tools/gen-sysreg.awk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/tools/gen-sysreg.awk b/arch/arm64/tools/gen-sysreg.awk > index 89bfb74e28de..5c55509eb43f 100755 > --- a/arch/arm64/tools/gen-sysreg.awk > +++ b/arch/arm64/tools/gen-sysreg.awk > @@ -253,7 +253,7 @@ END { > next > } > > -/0b[01]+/ && block = "Enum" { > +/0b[01]+/ && block == "Enum" { This makes sense but I'm surprised that we haven't noticed it until now (maybe some awk versions treat it as a relational operator). -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel