From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 49995C43334 for ; Fri, 10 Jun 2022 12:05:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MB8BecJdghBamyeEC0qSiTds++gzngcZEYBjWxvFja4=; b=SoPiYFTgV0fPR/ 36ulykXQDaXIn7NWvSpDD4W+BOLk3vkto6k+wRWeQt/IsOjbrWWfRf1qMDfvlgdyPcqlz58P0L1Pl O9a2ZAmcTsY5bN8ny2f/Y8pa5jmRepIiVXudxkOS+GRsO0hKJwq70JBKyxHSYTKY2Q+T84pBrPd4s fWcc9fPLVvQbEDcskOQpF7MoIhg5fyYi2UEme023eFP9Gmd8MCbcPIq1/qCm/aNKO67hUpjLIrzBh Qvr0No7hId5oARSk92E8DWcoVll1oaukpX15eXDTY7spSVqNIeNwdlyPjiEl01PCjTbX2nEdzVfzu UmOxI+h1fMA+LVzxIVvQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nzdN1-00849s-8F; Fri, 10 Jun 2022 12:04:07 +0000 Received: from relay3-d.mail.gandi.net ([217.70.183.195]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nzdMy-00844c-5k for linux-arm-kernel@lists.infradead.org; Fri, 10 Jun 2022 12:04:05 +0000 Received: (Authenticated sender: alexandre.belloni@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 2142C60008; Fri, 10 Jun 2022 12:03:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1654862639; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Wk/jtq8xnieuXpnFHV28FbZhaagmc7D9cxAaLwaoz9Y=; b=CYs4u8lBEb8T+7VflaieA4F8cQQ+Wv8XFP5a/KeI75L8Lulgv/WMPFpaLVkcv17QBvKyhg 03amMT0xX+/StH3JDr4WY276TWhEPhsQT4TRU7UjBxh7qaUx9++aDUv0KPSd5xYZ8em+Ks k/oujVqIwLA/wMQBb4YBQr701dNHLLcG51tvgbmXG9tm+w6FrBVd6/dUn2zE7dw13jewa4 XMZT9wL3Nr9GZskUdAYx3YNJxcEFeVmj1asPRMnHBMIxE0sXPKcXancUaxGpUmr3JEc7P+ CkarAIjFkWTwuxglW+tKo2Hcy2ViMfe8J8/w00sWGiCjg7a2/XrvCLsb8ek1bw== Date: Fri, 10 Jun 2022 14:03:55 +0200 From: Alexandre Belloni To: Srinivas Neeli Cc: a.zummo@towertech.it, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, michal.simek@xilinx.com, sgoud@xilinx.com, shubhraj@xilinx.com, srinivas.neeli@amd.com, neelisrinivas18@gmail.com, devicetree@vger.kernel.org, linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, git@xilinx.com Subject: Re: [PATCH V7 3/3] rtc: zynqmp: Updated calibration value Message-ID: References: <20220610113709.2646118-1-srinivas.neeli@xilinx.com> <20220610113709.2646118-3-srinivas.neeli@xilinx.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220610113709.2646118-3-srinivas.neeli@xilinx.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220610_050404_382455_66CF9A8E X-CRM114-Status: GOOD ( 14.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/06/2022 17:07:09+0530, Srinivas Neeli wrote: > As per RTC spec default calibration value is 0x7FFF. > Having that as a second patch breaks the calculation in your previous patch, really, this should just be a single patch. > Signed-off-by: Srinivas Neeli > --- > Changes in V7: > -New patch > -TRM not updated yet, Internal design document contains 0x7FFF as > default value. TRM Will update in next release. > --- > drivers/rtc/rtc-zynqmp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/rtc/rtc-zynqmp.c b/drivers/rtc/rtc-zynqmp.c > index 39b23f88ee26..1dd389b891fe 100644 > --- a/drivers/rtc/rtc-zynqmp.c > +++ b/drivers/rtc/rtc-zynqmp.c > @@ -37,7 +37,7 @@ > #define RTC_OSC_EN BIT(24) > #define RTC_BATT_EN BIT(31) > > -#define RTC_CALIB_DEF 0x198233 > +#define RTC_CALIB_DEF 0x7FFF > #define RTC_CALIB_MASK 0x1FFFFF > #define RTC_ALRM_MASK BIT(1) > #define RTC_MSEC 1000 > -- > 2.25.1 > -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel