From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 93F44C43334 for ; Sat, 11 Jun 2022 14:49:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=A+TCHUQ1KM4Q1yCDisxNLBciLgsoskLN0iMfFtpY3uA=; b=gjwWsoN+mATLZ4 0KB99RCPrCvYGxGLI6mqCz2sHp3gVmP5bN5FhZxZCPP3qTAumSIpon0mDPBXRkXUf41NWV279xvok 1UX2hOonO371Qt9NoEbXJRBfZ11y+648QAOgBVVs2cXdB3WSEYzeDDoS5x3tdD5gB1D8qxx/Og1c2 2WmVHZYK7kG8p4ASqImkXqKAg7cWpwLXwOqUvYgEFdikqPDwBQF3jPq5Gxo+1IC9EVVCggOIFvkS9 zsR3VQBUAJWv3EBDtpL+M3g8WHEcA0fMbm5yOm9j8eKsLwMcKf+oG8HRwEnYd1OyD7eUV0O6yCtod QHj+K4ZJKuKCpDNbHD3Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o02Pv-00DP6L-Ou; Sat, 11 Jun 2022 14:48:47 +0000 Received: from relay7-d.mail.gandi.net ([217.70.183.200]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o02Pr-00DP3B-4r for linux-arm-kernel@lists.infradead.org; Sat, 11 Jun 2022 14:48:45 +0000 Received: (Authenticated sender: alexandre.belloni@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id AE55E20003; Sat, 11 Jun 2022 14:48:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1654958918; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=I8VR4ymqkJ5K3C4CihtuWX5UmLAF7ogIHNe6DBY0KA0=; b=BL/jeWKrSHxkcIKpUp2Vg+dVcMhHN5ckuWf415X7yA3gTo/5vUJpz3kQuA8qk7YbJz0mjF QMBdcBNrtM9lNgf6aE6nMXNxk0XlKyyxBAYQcd0UNeQMQSrDRbWlm7JTByoaUs++wTtNdj s1BG16xDGduS2MzfHCABnguNOmYkMtKrruCP/woalx5hjKL6WhC6a3qdN5OwRRRl+5Rh7y wMR6egEXS2RQGhAr+3AkKwxaJNSCVgVt+zjFjJ8R7D3UNfTZMCclVIvphFwLJYTgnOsHGX KRUwRFWIiFgG6muyNySalKcWhYzJTYlmHBkZNpJT0Ribgai2PP3I8FIZA07UHQ== Date: Sat, 11 Jun 2022 16:48:35 +0200 From: Alexandre Belloni To: "Neeli, Srinivas" Cc: Srinivas Neeli , "a.zummo@towertech.it" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "michal.simek@xilinx.com" , "sgoud@xilinx.com" , "shubhraj@xilinx.com" , "neelisrinivas18@gmail.com" , "devicetree@vger.kernel.org" , "linux-rtc@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "git@xilinx.com" Subject: Re: [PATCH V7 3/3] rtc: zynqmp: Updated calibration value Message-ID: References: <20220610113709.2646118-1-srinivas.neeli@xilinx.com> <20220610113709.2646118-3-srinivas.neeli@xilinx.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220611_074843_495563_835E7864 X-CRM114-Status: GOOD ( 21.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/06/2022 15:04:31+0000, Neeli, Srinivas wrote: > [AMD Official Use Only - General] > > Hi, > > > -----Original Message----- > > From: Alexandre Belloni > > Sent: Friday, June 10, 2022 5:34 PM > > To: Srinivas Neeli > > Cc: a.zummo@towertech.it; robh+dt@kernel.org; > > krzysztof.kozlowski+dt@linaro.org; michal.simek@xilinx.com; > > sgoud@xilinx.com; shubhraj@xilinx.com; Neeli, Srinivas > > ; neelisrinivas18@gmail.com; > > devicetree@vger.kernel.org; linux-rtc@vger.kernel.org; linux-arm- > > kernel@lists.infradead.org; linux-kernel@vger.kernel.org; git@xilinx.com > > Subject: Re: [PATCH V7 3/3] rtc: zynqmp: Updated calibration value > > > > On 10/06/2022 17:07:09+0530, Srinivas Neeli wrote: > > > As per RTC spec default calibration value is 0x7FFF. > > > > > > > Having that as a second patch breaks the calculation in your previous patch, > > really, this should just be a single patch. > > Can I swap 3/3 and 2/3, Will that be fine ?. That would be better, yes > > > > > > Signed-off-by: Srinivas Neeli > > > --- > > > Changes in V7: > > > -New patch > > > -TRM not updated yet, Internal design document contains 0x7FFF as > > > default value. TRM Will update in next release. > > > --- > > > drivers/rtc/rtc-zynqmp.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/rtc/rtc-zynqmp.c b/drivers/rtc/rtc-zynqmp.c index > > > 39b23f88ee26..1dd389b891fe 100644 > > > --- a/drivers/rtc/rtc-zynqmp.c > > > +++ b/drivers/rtc/rtc-zynqmp.c > > > @@ -37,7 +37,7 @@ > > > #define RTC_OSC_EN BIT(24) > > > #define RTC_BATT_EN BIT(31) > > > > > > -#define RTC_CALIB_DEF 0x198233 > > > +#define RTC_CALIB_DEF 0x7FFF > > > #define RTC_CALIB_MASK 0x1FFFFF > > > #define RTC_ALRM_MASK BIT(1) > > > #define RTC_MSEC 1000 > > > -- > > > 2.25.1 > > > > > > > -- > > Alexandre Belloni, co-owner and COO, Bootlin > > Embedded Linux and Kernel engineering > > https://bootlin.com -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel