From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C6122C433EF for ; Wed, 15 Jun 2022 09:41:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Bvf3IXyWJHCBthgCqlVBmkutBXWVrUjWugK5PAn6QP8=; b=Ruok1GltBWnBdA 4bdHbGqpcWmLoPErnjCp3TiHR7joI0FRd1Ut2NoMV6jItS7ZAQDMTo0rdm/rC6WCP2hWQipiGdnz0 dda5azFOx9RNLaEFj94xlL7P+bRRuJoXmSqrSalE5OiJRWpqFYJkKGvYwxVEY4MphIWtZ8hqZBtu5 mi3FA/MY3Ps030eRzv05QYNR3dw2VSlpjLbxpW+Dlv5cUb40/9c9q7ymUIccGcmNOI8JDFoUkHOnm 3u5+bRdKQbgyUMD1pdkFGxV+QOXxH0BSn39YNoSNlKpC1BgC3CClmmnIHQt4zjdRrl/S8TQ4UrE4M N+iJ5qhiVCisnSK/pgbA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1PWE-00DWuu-75; Wed, 15 Jun 2022 09:40:58 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1PWA-00DWsw-E4 for linux-arm-kernel@lists.infradead.org; Wed, 15 Jun 2022 09:40:56 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 92532152B; Wed, 15 Jun 2022 02:40:51 -0700 (PDT) Received: from e120937-lin (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4245C3F66F; Wed, 15 Jun 2022 02:40:50 -0700 (PDT) Date: Wed, 15 Jun 2022 10:40:40 +0100 From: Cristian Marussi To: Florian Fainelli Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, sudeep.holla@arm.com, james.quinlan@broadcom.com, Jonathan.Cameron@huawei.com, etienne.carriere@linaro.org, vincent.guittot@linaro.org, souvik.chakravarty@arm.com Subject: Re: [PATCH 11/22] firmware: arm_scmi: Add SCMIv3.1 extended names protocols support Message-ID: References: <20220330150551.2573938-1-cristian.marussi@arm.com> <20220330150551.2573938-12-cristian.marussi@arm.com> <6f865d7f-fde8-d923-3c7e-d12bfbc370a6@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220615_024054_593063_23CF721F X-CRM114-Status: GOOD ( 22.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jun 15, 2022 at 09:18:03AM +0100, Cristian Marussi wrote: > On Wed, Jun 15, 2022 at 05:45:11AM +0200, Florian Fainelli wrote: > > > > > > On 3/30/2022 5:05 PM, Cristian Marussi wrote: > > > Using the common protocol helper implementation add support for all new > > > SCMIv3.1 extended names commands related to all protocols with the > > > exception of SENSOR_AXIS_GET_NAME. > > > > > > Signed-off-by: Cristian Marussi > > > > This causes the following splat on a platform where regulators fail to > > initialize: > > > > Hi Florian, > > thanks for the report. > > It seems a memory error while allocating so it was not meant to be > solved by the fixes, anyway, I've never seen this splat in my testing > and at first sight I cannot see anything wrong in the devm_k* calls > inside scmi_voltage_protocol_init...is there any particular config in > your setup ? > > Moreover, the WARNING line 5402 seems to match v5.19-rc1 and it has > slightly changed with -rc-1, so I'll try rebasing on that at first and > see if I can reproduce the issue locally. > I just re-tested the series rebased on v519-rc1 plus fixes and I cannot reproduce in my setup with a few (~9) good and bad voltage domains. How many voltage domains are advertised by the platform in your setup ? Thanks, Cristian > > > [ 0.603737] ------------[ cut here ]------------ > > [ 0.603752] WARNING: CPU: 1 PID: 1 at mm/page_alloc.c:5402 > > __alloc_pages+0x6c/0x184 > > [ 0.603797] Modules linked in: > > [ 0.603809] CPU: 1 PID: 1 Comm: swapper/0 Not tainted > > 5.19.0-rc1-g44dbdf3bb3f4 #42 > > [ 0.603818] Hardware name: BCX972160SV (DT) > > [ 0.603825] pstate: 20000005 (nzCv daif -PAN -UAO -TCO -DIT -SSBS > > BTYPE=--) > > [ 0.603834] pc : __alloc_pages+0x6c/0x184 > > [ 0.603841] lr : kmalloc_order+0x40/0x88 > > [ 0.603851] sp : ffffffc00a40b850 > > [ 0.603856] x29: ffffffc00a40b850 x28: 0000000000000000 x27: > > ffffffc008d60404 > > [ 0.603867] x26: ffffff80c1e3e1a8 x25: ffffffc00877bd78 x24: > > 0000000000000058 > > [ 0.603878] x23: ffffffc0081921a8 x22: ffffffc008cb04b0 x21: > > 0000000000000000 > > [ 0.603889] x20: 000000000000000b x19: 000000000000000b x18: > > 0000000000000000 > > [ 0.603900] x17: 0000000000000001 x16: 0000000100000000 x15: > > 000000000000000a > > [ 0.603911] x14: 0000000000000000 x13: ffffff80c1e3c20a x12: > > ffffffffffffffff > > [ 0.603922] x11: 0000000000000020 x10: 0000000000000880 x9 : > > ffffffc008159dac > > [ 0.603932] x8 : ffffff80c02708e0 x7 : 0000000000000004 x6 : > > 000000000041a880 > > [ 0.603943] x5 : 0000000000000001 x4 : ffffff8000000000 x3 : > > 0000000000000000 > > [ 0.603954] x2 : 0000000000000000 x1 : 0000000000000001 x0 : > > ffffffc00a32d3f2 > > [ 0.603965] Call trace: > > [ 0.603970] __alloc_pages+0x6c/0x184 > > [ 0.603977] kmalloc_order+0x40/0x88 > > [ 0.603984] kmalloc_order_trace+0x30/0xd0 > > [ 0.603992] __kmalloc_track_caller+0x64/0x19c > > [ 0.603999] devm_kmalloc+0x5c/0xe0 > > [ 0.604009] scmi_voltage_protocol_init+0x14c/0x2f4 > > [ 0.604020] scmi_get_protocol_instance+0x128/0x1f4 > > [ 0.604030] scmi_devm_protocol_get+0x64/0xc8 > > [ 0.604037] scmi_regulator_probe+0x5c/0x42c > > [ 0.604049] scmi_dev_probe+0x28/0x38 > > [ 0.604056] really_probe+0x1b8/0x380 > > [ 0.604065] __driver_probe_device+0x14c/0x164 > > [ 0.604073] driver_probe_device+0x48/0xe0 > > [ 0.604080] __driver_attach+0x160/0x170 > > [ 0.604087] bus_for_each_dev+0x78/0xb8 > > [ 0.604095] driver_attach+0x28/0x30 > > [ 0.604101] bus_add_driver+0xf4/0x208 > > [ 0.604108] driver_register+0xb4/0xf0 > > [ 0.604116] scmi_driver_register+0x5c/0xa4 > > [ 0.604123] scmi_drv_init+0x28/0x30 > > [ 0.604132] do_one_initcall+0x80/0x1a4 > > [ 0.604141] kernel_init_freeable+0x220/0x23c > > [ 0.604149] kernel_init+0x28/0x128 > > [ 0.604158] ret_from_fork+0x10/0x20 > > [ 0.604166] ---[ end trace 0000000000000000 ]--- > > [ 0.604194] scmi-regulator: probe of scmi_dev.2 failed with error -12 > > [ 0.604792] arm-scmi brcm_scmi@0: Failed. SCMI protocol 22 not active. > > -- > > Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel