From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6580DC43334 for ; Wed, 15 Jun 2022 16:13:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PDzH7mBMpQDEvlewxAqV39RzaDydR+xWJc530T6V+1c=; b=bbBXlaXBnARvft XYZJ2jPujaBLCYJIiL4mPRJve8WiC04w/b+iQ/BB+wkUFxWpDew9nMbr+mOeT80E5besWGBptXjP8 F3+qAozVmWfKkM7bmq1MJPDzw+BMd9wmUu56+hvPDto8HytlApIU+Hy+K9dHhVz0kXDRQ807wxGPs iOzrlnvWS45eKopbAbqsEWrmVUi3wNYE9IxfByG+Wl2WTfqEKA6eCeowUXnzc0JulnAZ6sX4BXy7P 443QQ2l5u3kWMlx7mj7i8/wFbLVFLuGWaQqDNtCYspawnXMD+WMqeQopD4JLPdVKOygVf+z91CneU CurxYBdh7hFhnzOdwGiA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1Vcz-00FJPO-MC; Wed, 15 Jun 2022 16:12:21 +0000 Received: from mail-he1eur02on0618.outbound.protection.outlook.com ([2a01:111:f400:fe05::618] helo=EUR02-HE1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1Vcw-00FJNi-1H for linux-arm-kernel@lists.infradead.org; Wed, 15 Jun 2022 16:12:19 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PW2knbMtKKJtEFFDWsJ6XBXFPRuutxpWVsUpW9zdHgQ7MhFhQo4VxWhdCLT5uyiZyDWOMOk2+slIhpHx41iuicwTgHmSSJc18oCl8j+p3d9Pb6IdFNpq6mf/JCvqCrpEh8aDsy+iJ1Ts4PFdIrBkL2QJ5nQ2H/Ac6amA1msCtkj+X1S7paRVtAr2+KczhVdCnFzbLkunIQ6Ix1kWDdWsLYcSzmTvebBNM8Abrb3/wqmyw936Yc9IB3CLjyCsPKREC/6HsR6pVd5AlSgRwYwkyKx/k7lRpWmsfJ/6diPXGnaD08nvM+MPPEEV960xJE35ePGDye2WCVCTceqQDh7GjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1suS5/lyV6jc1WNQKBLlZjf3NaicYbs7Bg2uFCvrm9w=; b=emcAKM5O+hG7au36FjpIO/8k+XaINAUTGGGMCina9cTWobHJJXtz/0Bj/eKkS3o1w3ff3WWIoF+bnM1pa6DIlF8jt54r6ahrMYrRv7GtpnoPsm6T+Xyaf08Zg08JDZt6l/Ol6FYP7sfU+8BPFbgX8l4y/ksZ2PXPII9EIhylb764JJPZ/wVc3703nSc4vwY36mij+gohMmSruSBQztIqo39sBkUK/5v+4G72hIgV4QfX4x6uaU53Oc1kxVAs94FDEkjBb9/kp1aVHEwgokOF2C0Ovez1/dJDUp70lkdxcEQu1MF4DHcZakWGh79VOHK0lA0HKyW4ggn2xtoG9WBjYw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1suS5/lyV6jc1WNQKBLlZjf3NaicYbs7Bg2uFCvrm9w=; b=TjOm8NYCn8yCaRQ6q7wGS7KKgQFcyoLE2pGe6PLL0Ttsum6eScs6VV+NuKAf785Zyl4VeHLCIKw8G+8NQgabR9s/u8WpFr4X7EIj3ZJIwXjWOymCMo1w26jcpjNtlVp4ybF5fu+TK8ikY4BZ0mTuQi0ZMT5tf5CxwtiOrLIhhsI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from VI1PR04MB4688.eurprd04.prod.outlook.com (2603:10a6:803:6a::30) by HE1PR0401MB2555.eurprd04.prod.outlook.com (2603:10a6:3:84::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.14; Wed, 15 Jun 2022 15:56:47 +0000 Received: from VI1PR04MB4688.eurprd04.prod.outlook.com ([fe80::1989:809a:81e1:adf9]) by VI1PR04MB4688.eurprd04.prod.outlook.com ([fe80::1989:809a:81e1:adf9%5]) with mapi id 15.20.5353.013; Wed, 15 Jun 2022 15:56:47 +0000 Date: Wed, 15 Jun 2022 18:56:44 +0300 From: Abel Vesa To: Marek Vasut Cc: linux-arm-kernel@lists.infradead.org, Fabio Estevam , Jacky Bai , Laurent Pinchart , Lucas Stach , Michael Turquette , Shawn Guo , Stephen Boyd , linux-imx@nxp.com Subject: Re: [PATCH 1/4] clk: imx: imx8mp: Add audiomix block control Message-ID: References: <20220504204144.442193-1-marex@denx.de> Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: AM7PR03CA0030.eurprd03.prod.outlook.com (2603:10a6:20b:130::40) To VI1PR04MB4688.eurprd04.prod.outlook.com (2603:10a6:803:6a::30) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 46f03c9e-dc15-462c-942e-08da4ee7a711 X-MS-TrafficTypeDiagnostic: HE1PR0401MB2555:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OfEyTcZFSNsaHmGN81ZqX5dMNfOuNFgFyU0yoA8M3lpQQLpmiRnXknP+Occ2HdLA3Xq/f7UZvaoUVyixiToKcZA+7wcW6tRxR70ysKcHyykyu/04tRTdeYZ0U1kmUqu8BZ0ag1ZLw5JIn8vd3Q14NLhpvNCrnNFWA/VsKtjNW+zNXoXfVgfTjWT1xwdRnSgkz/uEOxU7SfsuCjq4TgrTexN3x2fTP8G1KBPZNEcx22G6rElvhLM2ycJ4v/DFt7Vd/fiNwx7IzR84ejM6a6qZQNuQ8yIcUYyVmk91infpKpgq0jUo7cVc+SJvaqGuqzhOd/Zzt08bDcDOWGw7P0UFJMoy2tG0mpPd+MsFhZKhzM5oiWDR0BcpyBrAkExgpOQWgDXXhBcYHnNPUMtZOWm/dwBJtOAnvRSAzB6gBw4wIW6Ky92+eqTlaHBfVWYzz6hO+NIBx388rK/PPMtYWIL26wOZER/V5SJu1tafw/paZCp6rpLI+7pFNSq2AOIhILv9PTlULdeMndBhAN7aF3ceqS8/lXCxJY7P1/w903t/1EPpYT7IGQdrOHdXrXSBSAUmvp2Skf1kUSB0lteRG3NbSSzOabIlP8R5Bh0WEt8huj9b2kwxExyOZ1GWj3DNUyzwkzj5DURJDCWfT7drKMAT/71EGP8bTHymW1XNEbRQIYt6cFsDYsVg9a7OUd+W1jG+chOB9VQC22tzYkTjEh5ALcb7Ioby3d3Fhw0/ru2osSY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB4688.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(7916004)(4636009)(366004)(316002)(52116002)(53546011)(8936002)(8676002)(4326008)(66946007)(6512007)(66476007)(86362001)(66556008)(9686003)(26005)(38350700002)(508600001)(6486002)(38100700002)(6506007)(6916009)(6666004)(83380400001)(2906002)(33716001)(54906003)(5660300002)(186003)(44832011)(32563001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?GKZcOQwDEkHlEoB6Zk/gXXNszRJzZ5zDDBVqRaWpbXAaw2DzuEO4Xxj9aWhn?= =?us-ascii?Q?r/sTvnNxZu/rQCqpoRhcN4XHcWLoo/ApS8R+WO8H/bR4f/l6x9lLB6BS6sOJ?= =?us-ascii?Q?wscMahjoFGjl+o8FvwVq8toCFnWoiygw0U3s4t0/buC1EBAI8ho0azUPE4a3?= =?us-ascii?Q?JGqKj610TkuhcuUx3+kpgjwjmVEQRmc3EGzCsnXHnn2VKVEh+NvwUkZgriCG?= =?us-ascii?Q?OBWqV7h+OCJMQeol1vwdB2AqFMtha2ZcZckngSEIY3p4ybevjtTVQjWgaygJ?= =?us-ascii?Q?KZSo2Z0tqhigzxdyrYrm6i6hOoFNR0w56/6ZQ1LwgDBGNexedWjRzwC1xuht?= =?us-ascii?Q?g4rjK6tiAiNotjiRBqdo9zWTtkxqDDum1XD/6/QxNNu66RyhOJz5l7upLuOJ?= =?us-ascii?Q?k9pO1bcx59rZlR6GhHx5TsXQnZVtYONwq0xVZWnN5JvruBhyGuqjzirMk6cM?= =?us-ascii?Q?s7EcRr4R1uad3IcWdo01bboeN7xkegR9JclrInszfa3Cpb8YhNvooIoIy1GU?= =?us-ascii?Q?1i+iXis10T6FdVtCpDzj+3raChOK5Tpv91NtAw9BPhF31D7TIeRF7HOal2ba?= =?us-ascii?Q?1ZkkSpG/tu5heBTXG/pRjp3cWGEsM+ehWirxUJ3BXzr8FeFu6jjffhRdfSzw?= =?us-ascii?Q?goV74j8CEwMBQBg40dA+cIcdF0+FF1wJQx0TaQUlVjr6T28IdULYqx9LRfqW?= =?us-ascii?Q?MxMBKtC41LVF7CipX0XnxirF1s5FfYDrNLGtLmKGv6YmHPNiOdWEw1L0g2NM?= =?us-ascii?Q?99f7/Xq6cvjnt7f7z4jykXem9sdWOIC7w1dchZqoZ0YBHJBt3/6NFebxV3ny?= =?us-ascii?Q?TUeHh1Xufg4Nbnf+aMXQw1aHANiEGlU9racZrpsEgp0ZO7PmrFYKYj2C7CZm?= =?us-ascii?Q?s5tSioTNxKtjpB+87+l7PUv00qFIDcP+SqeLKfqSRPGqWeSYc6f67J8hODWE?= =?us-ascii?Q?kASQOOdyvJP1LZDEoEvNjcyXZuYg+gDBt4nnjuvgYq2Ux+uhKEUi0Z5djhCd?= =?us-ascii?Q?8E9sZjvXBYJFcYlTsyF3Od5e51QRiGiDge26vqQDMKwIfiRvtpOhPmsfgazh?= =?us-ascii?Q?FZsmMhcM9sLAcFSdXa+ftI0bepmke6S3jngPGeTyx7cG+R4BBu1pI/F3yVom?= =?us-ascii?Q?NOa5t/+s3/y1nYS4NMKowJpKRKTretKgyLAoc96Sb1xUWIoKu4Ev8RrOP6Rx?= =?us-ascii?Q?edON3Xrav2P/gd6xFS5ULA7ClR/viAjbZ44ngYz9QYqCQlMpakdHnzvOj4yf?= =?us-ascii?Q?yJbkmRZ/goFiETKdIn6JXxkVzFFKSRc8uzcLXgWC8J6jhXxAQ+vvdXgGq9D6?= =?us-ascii?Q?7UVmQ+w2+vLXRrZqWH8uhtf47UQvh85lnHqhM4PuB9NjT3TWdYdkbpt2yLcc?= =?us-ascii?Q?4mpqheqJ/2L10+ckdp/h6a0mDrZnVHvi6fkFpvzDHMY6FUBJGpFbX+vpOXGM?= =?us-ascii?Q?r2O3kxMc87xLPWE0nUO0CEeRmPe5l+rM9sNLnil/Oy+wQ+IeNVshe1uTqjIv?= =?us-ascii?Q?LSMzpWwbpqFBX2uwWbojZNwbAJXKjeThyAfzes25cFstYR6LCE++BpKqY2tS?= =?us-ascii?Q?8Zamu89yGMbQw7MFblA4HrjPcdafECNegSmJhvMsM3JUg7UuVfzVONaOycr1?= =?us-ascii?Q?aY8//EZWq5vm6RxkgawmcjX5PfIof1YQhSD+Ums8NZfHPJvE91W5MXqNI1Oj?= =?us-ascii?Q?zx9OdSjiVNYWYxrSKUdgQVGdpPVqgmZ3vtWQznPfRx8aCxrJ6l7pa1Sm4NG3?= =?us-ascii?Q?Jsqz1A2Ziw=3D=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 46f03c9e-dc15-462c-942e-08da4ee7a711 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB4688.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jun 2022 15:56:47.6986 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: giLh6YEynwzUU4ekL6IUsxi98ntYwCYRFEgAjl3Rn4qMvpsbiCT5TmghnGIwfQMaOnE+EwrnH00MdGPrUed1/A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0401MB2555 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220615_091218_145599_D3B4A15D X-CRM114-Status: GOOD ( 17.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 22-06-15 18:47:01, Abel Vesa wrote: > On 22-06-15 17:08:28, Marek Vasut wrote: > > On 6/15/22 16:30, Abel Vesa wrote: > > > > [...] > > > > > > +static int clk_imx8mp_audiomix_probe(struct platform_device *pdev) > > > > +{ > > > > + struct clk_imx8mp_audiomix_priv *priv; > > > > + struct device *dev = &pdev->dev; > > > > + struct resource *res; > > > > + void __iomem *base; > > > > + struct clk_hw *hw; > > > > + int i; > > > > + > > > > + priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); > > > > + if (!priv) > > > > + return -ENOMEM; > > > > + > > > > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > > > + base = devm_ioremap_resource(dev, res); > > > > + if (IS_ERR(base)) > > > > + return PTR_ERR(base); > > > > + > > > > > > Hmm, the audiomix blk-ctl driver uses the PD for this device. > > > That is not going to work. > > > > What is not going to work. Can you elaborate on your concerns ? > > Have a look at drivers/soc/imx/imx8m-blk-ctrl.c. > > As of now, there is no i.MX8MP audio blk ctrl support added there yet, > but once that gets added, that driver will disable the PD from under > this clock controller. On a second thought, I remember there was a discussion about this being implemented entirely in imx8m-blk-ctrl.c. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel