From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4BD6BC43334 for ; Wed, 15 Jun 2022 17:30:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KerTcjLiLS2IhXp8pJLr7rC8Uju4jKh1b+KZ2w4ysV8=; b=3Z4/0hYO/7ezp3 4NciTrN7lxkSvRtJhNHf32if37+v1CRs7/x+lTT4kw4UG6R4jaXYEi4KIA0PdEOJkKXZMXSIaC/fJ JC7fRZSvmjOVofcgN6q/oxMaohK8yQXbnIaqJ4NCrrCHNUxQi6SFlyQzHquuGNFZ+fUM3h6oU0Yu2 hoYwaxqrF1Lut5VWrIvLJSnigxdXl2FihZe/yEiby06JynSD6Hcqjcgy7uO01ibUTc5fD1stSW6aG wKrYfPHITnXTeVL/gloL2EcVciIkrtyi5cQcEvWdHOqgpVQB+8XRzSyNDIcIjrQTvH+VZsfjl046a uM7srNZe/1kkY2YLddKQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1Wpe-00FhKO-FF; Wed, 15 Jun 2022 17:29:30 +0000 Received: from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1Wpa-00FhID-N0 for linux-arm-kernel@lists.infradead.org; Wed, 15 Jun 2022 17:29:28 +0000 Received: by mail-pl1-x629.google.com with SMTP id y6so15086plg.0 for ; Wed, 15 Jun 2022 10:29:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=il/KBps6ii6Gd5FHFi9j3ZFy5kAtbrCy1Dgg4+ftDI4=; b=nGG3zeC3ujp1Lyr79SQNyz3Yei5eS80xvtngKVpw/5YXlWoG5FFrAxwd8qnLOVoDPS SIaZg0HNQMFqJ/TRcM4ZVL9bkTGfLuu9eUAPFm41Xl9FQLgRlRlMO5MR7y10uklFmE+u PipgW0PTjhJ1/PPY6CMmEFkVkCl9GbkCXKKPs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=il/KBps6ii6Gd5FHFi9j3ZFy5kAtbrCy1Dgg4+ftDI4=; b=Lz8LxpfpmjU0SdoUmJGdJKU0tfdxhkqrdFvVwdxwz8hvgfE5oRioXAEIjpeQq59isU WyBDMfU0rx7NxYug9nTG4OAD0K4DFjC6C2nrDQ//pI1Y+UKSxBiju7ydea+dE74a1JRo buxXVHu1CzS0xSfG+eanzrcJ6NPbMvGA3KlruuWov+5Sc12i6JN9SnDIF4SZlN4Ogwqs mfFMSRBOKKxLG6FLU3mZCGR//+I6HQDKzmObNI8G9gJk/151KzrrP3PZUh583cRieG1H QU6GjdkdTXbXnXZfQTc3wBip5J73SQrPcTX8fNtUnOBistV3gm00I154Hm4cbquETtbn Cvhw== X-Gm-Message-State: AJIora8JevmWFk7I2JwI+oqY/dER9uesd3szzRzqT/FyJT5RHO+A7tLT uS8KkPs/6+7tEwGWytKr2lKlPw== X-Google-Smtp-Source: AGRyM1sYHET89749fDt5TDoEPXQeflY6qeT3IV7HNP/7XVyGqeBNCkZrte/HBbD0kJf4G/g2FjkDMQ== X-Received: by 2002:a17:90a:6444:b0:1ea:b662:c12e with SMTP id y4-20020a17090a644400b001eab662c12emr506120pjm.199.1655314162312; Wed, 15 Jun 2022 10:29:22 -0700 (PDT) Received: from google.com ([2620:15c:202:201:342:e7bd:5391:5d5b]) by smtp.gmail.com with ESMTPSA id g3-20020a636b03000000b003fcfdc9946dsm10402512pgc.51.2022.06.15.10.29.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jun 2022 10:29:21 -0700 (PDT) Date: Wed, 15 Jun 2022 10:29:19 -0700 From: Brian Norris To: Judy Hsiao Cc: Rob Herring , Heiko Stuebner , Douglas Anderson , Guenter Roeck , Chen-Yu Tsai , linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [v1] arm64: dts: rk3399: i2s: switch BCLK to GPIO Message-ID: References: <20220615045146.3134420-1-judyhsiao@chromium.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220615045146.3134420-1-judyhsiao@chromium.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220615_102926_792338_FFEF5EDD X-CRM114-Status: GOOD ( 21.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Normally the subject should look like "[PATCH v1] ...", not just "[v1] ...". On Wed, Jun 15, 2022 at 04:51:46AM +0000, Judy Hsiao wrote: > We discoverd that the state of BCLK on, LRCLK off and SD_MODE on > may cause the speaker melting issue. Removing LRCLK while BCLK > is present can cause unexpected output behavior including a large > DC output voltage as described in the Max98357a datasheet. > > In order to: > 1. prevent BCLK from turning on by other component. > 2. keep BCLK and LRCLK being present at the same time > > This patch adjusts the device tree to allow BCLK to switch > to GPIO func before LRCLK output, and switch back during > LRCLK is output. I get how this "allows" switching, but it seems like this would make more sense in a patch series that implements the switching. I'm also not certain, but it might be worth adding this to the DT binding, so we set the 'pinctrl-names' piece (which presumably you need to use in a driver) in stone. > --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi ... > @@ -2225,6 +2226,8 @@ pcfg_input_pull_down: pcfg-input-pull-down { > input-enable; > bias-pull-down; > drive-strength = <2>; > + pcfg_pull_none_hiz: pcfg-pull-none-hiz { > + bias-disable; > }; This isn't valid syntax. You probably didn't resolve conflicts correctly when rebasing a patch? You need an extra brace somewhere. Also, this definition seems like it belongs next to 'pcfg_pull_none' (around line 2138), or at least somewhere near the other 'pcfg_pull_*' handles. Brian > > clock { _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel