From: Abel Vesa <abel.vesa@linaro.org>
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
Cc: mturquette@baylibre.com, sboyd@kernel.org, shawnguo@kernel.org,
s.hauer@pengutronix.de, kernel@pengutronix.de,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Haibo Chen <haibo.chen@nxp.com>, Peng Fan <peng.fan@nxp.com>,
Jacky Bai <ping.bai@nxp.com>
Subject: Re: [PATCH 1/7] clk: imx93: use adc_root as the parent clock of adc1
Date: Thu, 16 Jun 2022 00:31:15 +0300 [thread overview]
Message-ID: <YqpPowp9SZhL9Rww@ryzen> (raw)
In-Reply-To: <20220609132902.3504651-2-peng.fan@oss.nxp.com>
On 22-06-09 21:28:56, Peng Fan (OSS) wrote:
> From: Haibo Chen <haibo.chen@nxp.com>
>
> When debug, find after system boot up, all adc register operation
> will trigger system hang, this is because the internal adc ipg
> clock is gate off. In dts, only reference the IMX93_CLK_ADC1_GATE,
> which is adc1, no one touch the adc_root, so adc_root will be gate
> off automatically after system boot up.
>
> Fixes: 24defbe194b6 ("clk: imx: add i.MX93 clk")
> Reviewed-by: Peng Fan <peng.fan@nxp.com>
> Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
> Signed-off-by: Jacky Bai <ping.bai@nxp.com>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
Reviewed-by: Abel Vesa <abel.vesa@linaro.org>
> ---
> drivers/clk/imx/clk-imx93.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/imx/clk-imx93.c b/drivers/clk/imx/clk-imx93.c
> index edcc87661d1f..172cd56c9610 100644
> --- a/drivers/clk/imx/clk-imx93.c
> +++ b/drivers/clk/imx/clk-imx93.c
> @@ -150,7 +150,7 @@ static const struct imx93_clk_ccgr {
> { IMX93_CLK_A55_GATE, "a55", "a55_root", 0x8000, },
> /* M33 critical clk for system run */
> { IMX93_CLK_CM33_GATE, "cm33", "m33_root", 0x8040, CLK_IS_CRITICAL },
> - { IMX93_CLK_ADC1_GATE, "adc1", "osc_24m", 0x82c0, },
> + { IMX93_CLK_ADC1_GATE, "adc1", "adc_root", 0x82c0, },
> { IMX93_CLK_WDOG1_GATE, "wdog1", "osc_24m", 0x8300, },
> { IMX93_CLK_WDOG2_GATE, "wdog2", "osc_24m", 0x8340, },
> { IMX93_CLK_WDOG3_GATE, "wdog3", "osc_24m", 0x8380, },
> --
> 2.25.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-06-15 21:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-09 13:28 [PATCH 0/7] clk: imx93: pll/imx93 fixes and update Peng Fan (OSS)
2022-06-09 13:28 ` [PATCH 1/7] clk: imx93: use adc_root as the parent clock of adc1 Peng Fan (OSS)
2022-06-15 21:31 ` Abel Vesa [this message]
2022-06-09 13:28 ` [PATCH 2/7] clk: imx93: correct nic_media parent Peng Fan (OSS)
2022-06-15 21:33 ` Abel Vesa
2022-06-09 13:28 ` [PATCH 3/7] clk: imx93: Correct the edma1's parent clock Peng Fan (OSS)
2022-06-15 21:39 ` Abel Vesa
2022-06-16 0:16 ` Stephen Boyd
2022-06-16 3:58 ` Peng Fan
2022-06-16 14:18 ` Abel Vesa
2022-06-09 13:28 ` [PATCH 4/7] clk: imx: clk-fracn-gppll: fix mfd value Peng Fan (OSS)
2022-06-09 13:29 ` [PATCH 5/7] clk: imx: clk-fracn-gppll: Return rate in rate table properly in ->recalc_rate() Peng Fan (OSS)
2022-06-09 13:29 ` [PATCH 6/7] clk: imx: clk-fracn-gppll: correct rdiv Peng Fan (OSS)
2022-06-09 13:29 ` [PATCH 7/7] clk: imx: clk-fracn-gppll: Add more freq config for video pll Peng Fan (OSS)
2022-06-16 16:01 ` [PATCH 0/7] clk: imx93: pll/imx93 fixes and update Abel Vesa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YqpPowp9SZhL9Rww@ryzen \
--to=abel.vesa@linaro.org \
--cc=haibo.chen@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=peng.fan@nxp.com \
--cc=peng.fan@oss.nxp.com \
--cc=ping.bai@nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox