From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 65C66C433EF for ; Thu, 16 Jun 2022 17:41:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mZAbnFa0iKg55Up/tmT3XgLjmHZTImYy/LC6f06hpp4=; b=ytAIoaK/DG0MP9 XZISINjdYhsZqmXIud3LEY9NmpmHS+u8rOddtrh6ZoY0DrH5denZWB3XZCmei/CLzlqVlVWAm2ivg 6Sr3IScCLITZZsfbFswn5HsX1N+eLiLEh9Mx4jMzR+NUPO/BWh5h1JMfQxMKJass5ZLkvnGd5UaPM fZqNHCVfjI9RrzmbkNYXIQY0Chxgb6XNir3B3EWd+6T81FJ97YsNKL/6jIiXiG18EMuRPoO6q5QqL CaTAg5pWElcWTt3krNWLX4zAwvv4XebcXxo7Quw30uJvBwFd/AL/MX9GtSQBq93xg6spPnnlmoH8S HKjFV0CP7NWBXwjDJhDg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1tUD-003hwi-7i; Thu, 16 Jun 2022 17:40:53 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1tUA-003huU-BP for linux-arm-kernel@lists.infradead.org; Thu, 16 Jun 2022 17:40:51 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 9A008CE2644; Thu, 16 Jun 2022 17:40:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6DC5AC34114; Thu, 16 Jun 2022 17:40:44 +0000 (UTC) Date: Thu, 16 Jun 2022 18:40:40 +0100 From: Catalin Marinas To: Vincenzo Frascino Cc: Andrey Ryabinin , Andrey Konovalov , Will Deacon , Peter Collingbourne , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 2/4] mm: kasan: Skip unpoisoning of user pages Message-ID: References: <20220610152141.2148929-1-catalin.marinas@arm.com> <20220610152141.2148929-3-catalin.marinas@arm.com> <75aa779d-785f-6515-51cd-654e8c5d18f5@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <75aa779d-785f-6515-51cd-654e8c5d18f5@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220616_104050_606193_4C632906 X-CRM114-Status: GOOD ( 14.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jun 16, 2022 at 09:42:10AM +0100, Vincenzo Frascino wrote: > On 6/10/22 16:21, Catalin Marinas wrote: > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > > index e008a3df0485..f6ed240870bc 100644 > > --- a/mm/page_alloc.c > > +++ b/mm/page_alloc.c > > @@ -2397,6 +2397,7 @@ inline void post_alloc_hook(struct page *page, unsigned int order, > > bool init = !want_init_on_free() && want_init_on_alloc(gfp_flags) && > > !should_skip_init(gfp_flags); > > bool init_tags = init && (gfp_flags & __GFP_ZEROTAGS); > > + int i; > > > > Nit: Since "i" is not used outside of the for loop context we could use the > contract form "for (int i = 0; ..." which is allowed by C11. Oh yeah, Linux moved to C11 in 5.18. But it looks better to be consistent with the other for loop in this file. > Reviewed-by: Vincenzo Frascino Thanks. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel