From: Nicolin Chen <nicolinc@nvidia.com>
To: "Tian, Kevin" <kevin.tian@intel.com>
Cc: "joro@8bytes.org" <joro@8bytes.org>,
"will@kernel.org" <will@kernel.org>,
"marcan@marcan.st" <marcan@marcan.st>,
"sven@svenpeter.dev" <sven@svenpeter.dev>,
"robin.murphy@arm.com" <robin.murphy@arm.com>,
"robdclark@gmail.com" <robdclark@gmail.com>,
"baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"orsonzhai@gmail.com" <orsonzhai@gmail.com>,
"baolin.wang7@gmail.com" <baolin.wang7@gmail.com>,
"zhang.lyra@gmail.com" <zhang.lyra@gmail.com>,
"jean-philippe@linaro.org" <jean-philippe@linaro.org>,
"alex.williamson@redhat.com" <alex.williamson@redhat.com>,
"jgg@nvidia.com" <jgg@nvidia.com>,
"jordan@cosmicpenguin.net" <jordan@cosmicpenguin.net>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
"alyssa@rosenzweig.io" <alyssa@rosenzweig.io>,
"linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
"saiprakash.ranjan@codeaurora.org"
<saiprakash.ranjan@codeaurora.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"jonathanh@nvidia.com" <jonathanh@nvidia.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"yangyingliang@huawei.com" <yangyingliang@huawei.com>,
"gerald.schaefer@linux.ibm.com" <gerald.schaefer@linux.ibm.com>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"christophe.jaillet@wanadoo.fr" <christophe.jaillet@wanadoo.fr>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
"isaacm@codeaurora.org" <isaacm@codeaurora.org>,
"cohuck@redhat.com" <cohuck@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"dwmw2@infradead.org" <dwmw2@infradead.org>
Subject: Re: [PATCH v2 4/5] vfio/iommu_type1: Clean up update_dirty_scope in detach_group()
Date: Thu, 16 Jun 2022 15:26:09 -0700 [thread overview]
Message-ID: <YquuAR4h7dMCg4eq@Asurada-Nvidia> (raw)
In-Reply-To: <BL1PR11MB5271A40D57BEBBA0BAA4C0BB8CAC9@BL1PR11MB5271.namprd11.prod.outlook.com>
On Thu, Jun 16, 2022 at 06:45:09AM +0000, Tian, Kevin wrote:
> > +out_unlock:
> > mutex_unlock(&iommu->lock);
> > }
> >
>
> I'd just replace the goto with a direct unlock and then return there.
> the readability is slightly better.
OK. Will do that.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-06-16 22:27 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-16 0:02 [PATCH v2 0/5] Simplify vfio_iommu_type1 attach/detach routine Nicolin Chen
2022-06-16 0:03 ` [PATCH v2 1/5] iommu: Return -EMEDIUMTYPE for incompatible domain and device/group Nicolin Chen
2022-06-16 2:09 ` Baolu Lu
2022-06-16 2:40 ` Nicolin Chen
2022-06-16 6:28 ` Tian, Kevin
2022-06-16 0:03 ` [PATCH v2 2/5] vfio/iommu_type1: Prefer to reuse domains vs match enforced cache coherency Nicolin Chen
2022-06-16 6:29 ` Tian, Kevin
2022-06-21 22:46 ` Alex Williamson
2022-06-21 23:47 ` Nicolin Chen
2022-06-16 0:03 ` [PATCH v2 3/5] vfio/iommu_type1: Remove the domain->ops comparison Nicolin Chen
2022-06-16 6:40 ` Tian, Kevin
2022-06-16 22:23 ` Nicolin Chen
2022-06-22 7:54 ` Robin Murphy
2022-06-23 3:50 ` Tian, Kevin
2022-06-23 7:47 ` Nicolin Chen
2022-06-24 13:16 ` Jason Gunthorpe
2022-06-24 18:31 ` Robin Murphy
2022-06-24 18:46 ` Jason Gunthorpe
2022-06-16 0:03 ` [PATCH v2 4/5] vfio/iommu_type1: Clean up update_dirty_scope in detach_group() Nicolin Chen
2022-06-16 6:45 ` Tian, Kevin
2022-06-16 22:26 ` Nicolin Chen [this message]
2022-06-16 0:03 ` [PATCH v2 5/5] vfio/iommu_type1: Simplify group attachment Nicolin Chen
2022-06-16 7:08 ` Tian, Kevin
2022-06-16 22:40 ` Nicolin Chen
2022-06-17 2:53 ` Tian, Kevin
2022-06-17 23:07 ` Nicolin Chen
2022-06-20 4:03 ` Jason Gunthorpe
2022-06-21 20:59 ` Nicolin Chen
2022-06-20 10:11 ` Robin Murphy
2022-06-21 21:08 ` Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YquuAR4h7dMCg4eq@Asurada-Nvidia \
--to=nicolinc@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=alyssa@rosenzweig.io \
--cc=baolin.wang7@gmail.com \
--cc=baolu.lu@linux.intel.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=cohuck@redhat.com \
--cc=dwmw2@infradead.org \
--cc=gerald.schaefer@linux.ibm.com \
--cc=iommu@lists.linux-foundation.org \
--cc=isaacm@codeaurora.org \
--cc=jean-philippe@linaro.org \
--cc=jgg@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=jordan@cosmicpenguin.net \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=matthias.bgg@gmail.com \
--cc=orsonzhai@gmail.com \
--cc=robdclark@gmail.com \
--cc=robin.murphy@arm.com \
--cc=saiprakash.ranjan@codeaurora.org \
--cc=sven@svenpeter.dev \
--cc=tglx@linutronix.de \
--cc=thierry.reding@gmail.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=will@kernel.org \
--cc=yangyingliang@huawei.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).