From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 14012C43334 for ; Thu, 16 Jun 2022 22:42:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=J7J5W2WFmo1I5/Pcf+v73u9Yw48rXAGgppR+HWnhmtk=; b=3Os7M0meFTiT2v fw8QtbLXaCCLb2ElexfdvvXwNG11IemXKl5jQPNKnIn3Q+v+2/F1u8A9b6RUy1/PhhkIG+NS4xvLm Q8oRK43vF+5hgUF2Ms2FEGUzN0VBwmK9WDG1nadaVmj7qKY7+tutJQETHruLBlUmO/sXxUNXqYWSk O7iZDYzMfRONEZSCy2pIXmVNx6zp/6ELNafvBwELHcNJKaaAt15D97uYPTwB+8EVMMtGd2lNfMWJR Bud0kvGvdlvRU5Z7+ChiXAMmR+1jRpKzD2u0nn7QN9ECPUq8cZS8H97UypndxyHwBLLlXfxzea2fW 7k6waGUObZk7G0VfdBNg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1yB1-004dvu-LZ; Thu, 16 Jun 2022 22:41:23 +0000 Received: from mail-bn8nam12on20614.outbound.protection.outlook.com ([2a01:111:f400:fe5b::614] helo=NAM12-BN8-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1yAy-004duY-OO; Thu, 16 Jun 2022 22:41:22 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bX5pcTEnZf7FpWsIzHhZ/wbpBi9Oqu65uibwOdkV/GnMCSGHQl5j71h/XppYyaatv07WFX0yG0PCTwnIMKjtBSX6vZgq75SGD2hY/ORxAbgNDPjAsMWXSoFBXWKr62dc4wm7kTqsDqOA5T6Kst+nXUnbA3N9qjqogO0q2KD4vZe2SapkkX9QhcXRwglQWa0UhD2H+acf6rxWXyT84TT++8t31kLQduqrGhoM9GY0z2faVkxqn8kdflWtiwBaKWCYqXOY3AYmEoqrxdxr5JVNuFPx3dpiRrEQWx46/FtmpUOgOwzprRjM9ljlp6pFNr0glZK/KJc4DE4I7BvFxMoGJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zgp5iE3AW7LRxZF1GBubRntHzqsJyyTgzfgQIAASVYE=; b=M+iS+omVOFrJUiesFR1Wj3sl4sRyVQsviqe+4qKmh8Bt8+RGAAl/GqFcp1NkmBdPSjxyfW2rLmKjxSMgSqv6XEwEWHBxJim0bbCDYEH8uH3n9DluthG2+4QawF2VoU7n4ZgaXlZMBq8471bVjjEhkDlqaDy0p1c+3NoReweVKLG2h91hwC6kLHlUntTPlrUHDFeDWn3bZNSNrKwBFJB2FfI1cm2xmTXsYpREq5u9gpuABBZUIRkVJsiFtpn0SXeMlfq6j93qxL9Yg45+S/eOdGGdybMqQREqBwI3oGw7ipxCfpSbVPD4Umx+mi/6zjC5rGCsnnPDMo7Ehq3+y1HlQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 12.22.5.238) smtp.rcpttodomain=arm.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zgp5iE3AW7LRxZF1GBubRntHzqsJyyTgzfgQIAASVYE=; b=ZD6sY9Cl7bF1DpTysd0hQ5kJ/DR1ouZg1JkQXGyMy1beydmPCh4/IMysxTzzXCUX8/KIZn1ToZwcE7ULNKNuhslj1Gh5in1Zgq2Yma1NYD2QOSuDZ0F6aHegTTBsrBYtF5SZFWa2EuyE8tNijPQJ5aGB7dV4wpUtKImT6vwzwI9vsFZea14LQwM0I3nHYp4ReRnOIAOThJat/WtTEpxoX50zLFQ6Zki9DwhF1GY5pBffRhVUonEc04aIzM7mpivqrYAZ2XxTF7ziy3rvsMmMAwY2QBk/0drQ0vz1ukIIlSy0UxGoqNyQl35CmH0vP0huDpaZNUnK9iE+q5g18caYWQ== Received: from DM5PR1101CA0016.namprd11.prod.outlook.com (2603:10b6:4:4c::26) by BL1PR12MB5732.namprd12.prod.outlook.com (2603:10b6:208:387::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.14; Thu, 16 Jun 2022 22:41:15 +0000 Received: from DM6NAM11FT012.eop-nam11.prod.protection.outlook.com (2603:10b6:4:4c:cafe::58) by DM5PR1101CA0016.outlook.office365.com (2603:10b6:4:4c::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.19 via Frontend Transport; Thu, 16 Jun 2022 22:41:15 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 12.22.5.238) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 12.22.5.238 as permitted sender) receiver=protection.outlook.com; client-ip=12.22.5.238; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (12.22.5.238) by DM6NAM11FT012.mail.protection.outlook.com (10.13.173.109) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.5353.14 via Frontend Transport; Thu, 16 Jun 2022 22:41:15 +0000 Received: from rnnvmail202.nvidia.com (10.129.68.7) by DRHQMAIL105.nvidia.com (10.27.9.14) with Microsoft SMTP Server (TLS) id 15.0.1497.32; Thu, 16 Jun 2022 22:40:53 +0000 Received: from rnnvmail204.nvidia.com (10.129.68.6) by rnnvmail202.nvidia.com (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Thu, 16 Jun 2022 15:40:52 -0700 Received: from Asurada-Nvidia (10.127.8.11) by mail.nvidia.com (10.129.68.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22 via Frontend Transport; Thu, 16 Jun 2022 15:40:50 -0700 Date: Thu, 16 Jun 2022 15:40:48 -0700 From: Nicolin Chen To: "Tian, Kevin" CC: "joro@8bytes.org" , "will@kernel.org" , "marcan@marcan.st" , "sven@svenpeter.dev" , "robin.murphy@arm.com" , "robdclark@gmail.com" , "baolu.lu@linux.intel.com" , "matthias.bgg@gmail.com" , "orsonzhai@gmail.com" , "baolin.wang7@gmail.com" , "zhang.lyra@gmail.com" , "jean-philippe@linaro.org" , "alex.williamson@redhat.com" , "jgg@nvidia.com" , "jordan@cosmicpenguin.net" , "thierry.reding@gmail.com" , "alyssa@rosenzweig.io" , "linux-s390@vger.kernel.org" , "saiprakash.ranjan@codeaurora.org" , "kvm@vger.kernel.org" , "jonathanh@nvidia.com" , "linux-arm-kernel@lists.infradead.org" , "yangyingliang@huawei.com" , "gerald.schaefer@linux.ibm.com" , "linux-arm-msm@vger.kernel.org" , "christophe.jaillet@wanadoo.fr" , "linux-tegra@vger.kernel.org" , "tglx@linutronix.de" , "virtualization@lists.linux-foundation.org" , "isaacm@codeaurora.org" , "cohuck@redhat.com" , "linux-kernel@vger.kernel.org" , "iommu@lists.linux-foundation.org" , "linux-mediatek@lists.infradead.org" , "dwmw2@infradead.org" Subject: Re: [PATCH v2 5/5] vfio/iommu_type1: Simplify group attachment Message-ID: References: <20220616000304.23890-1-nicolinc@nvidia.com> <20220616000304.23890-6-nicolinc@nvidia.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b1201343-8352-4791-4bbd-08da4fe95278 X-MS-TrafficTypeDiagnostic: BL1PR12MB5732:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nk74016v9mt1rCmjH5UOQIlrAhVCquvXKRo493JksbtTiOr1sWHplxlVewAZV0M9N5GQBDi9prjABasx04aHk5dOrYmqqHoT5kj5n/tpkScS2qGWb7FkB5iQvAPpXB6NC3Lvdxlbyhbaxi2svf5DmuUbvS9AsNAr62Kqzk+bUI6z3W2Uu097QeM4vgs9WiTDzbcxzPFmP9cWfr7xvMDgAAp9V2JKDTOYylCOCYj9OHHZ9f0ZC999Dwn1pvzbZcMMfsEJc8Bbd5ee/nJchRBrRb/pV2K//UpWsrUcIYcx+N0XCJeJq3ORiAyttTETfiPcjzerVTBMjsc9Hb/ZYGPzOHRT5PODKWxHSH3uUpCRLYjHtSzxxxSRLG8hyBTNrsu/sEo5lArGNgdQT/4papj310Hue7TaSfYb+/zQNNHgt1DcppeiOnBZ6tAVusW9GTadpVJXQ0B3KJpCccAomtiLX2vus7bSv8poPNbOke/OLv31/TXqRs5ZLcY2hWWf5ALuQlD8AvxlNT9UtsYADwABI+6yTeDHcT2lJu/V0maug5mIgvixXnyzOMzead8RLCfHaBRQAIwA4V+PPYD32dPx748g7JBXk3cGwSjmtGwDKZIfvrYiCV6C8DEZpmgI7mC8nqpv4uV5goLptF2OWNi+RxtonGswus7UKJvQnc2UZ2wa4OKpre8+5u0JzzQr/aoDC42g734N6roMb6U/vX1Br51W2MrvKaOP8sozLn+xfWw= X-Forefront-Antispam-Report: CIP:12.22.5.238;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:InfoNoRecords;CAT:NONE;SFS:(13230016)(4636009)(40470700004)(36840700001)(46966006)(8936002)(26005)(9686003)(7416002)(508600001)(7406005)(356005)(70586007)(70206006)(2906002)(5660300002)(55016003)(83380400001)(36860700001)(186003)(81166007)(47076005)(426003)(336012)(40460700003)(8676002)(86362001)(82310400005)(33716001)(4326008)(54906003)(6916009)(316002)(67856001)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jun 2022 22:41:15.4530 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b1201343-8352-4791-4bbd-08da4fe95278 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[12.22.5.238];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT012.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5732 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220616_154120_836350_E9A69CA3 X-CRM114-Status: GOOD ( 20.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jun 16, 2022 at 07:08:10AM +0000, Tian, Kevin wrote: > ... > > +static struct vfio_domain * > > +vfio_iommu_alloc_attach_domain(struct bus_type *bus, struct vfio_iommu > > *iommu, > > + struct vfio_iommu_group *group) > > +{ > > + struct iommu_domain *new_domain; > > + struct vfio_domain *domain; > > + int ret = 0; > > + > > + /* Try to match an existing compatible domain */ > > + list_for_each_entry (domain, &iommu->domain_list, next) { > > + ret = iommu_attach_group(domain->domain, group- > > >iommu_group); > > + if (ret == -EMEDIUMTYPE) > > + continue; > > Probably good to add one line comment here for what EMEDIUMTYPE > represents. It's not a widely-used retry type like EAGAIN. A comment > can save the time of digging out the fact by jumping to iommu file. Sure. I can add that. > ... > > - if (resv_msi) { > > + if (resv_msi && !domain->msi_cookie) { > > ret = iommu_get_msi_cookie(domain->domain, > > resv_msi_base); > > if (ret && ret != -ENODEV) > > goto out_detach; > > + domain->msi_cookie = true; > > } > > why not moving to alloc_attach_domain() then no need for the new > domain field? It's required only when a new domain is allocated. When reusing an existing domain that doesn't have an msi_cookie, we can do iommu_get_msi_cookie() if resv_msi is found. So it is not limited to a new domain. > ... > > - if (list_empty(&domain->group_list)) { > > - if (list_is_singular(&iommu->domain_list)) { > > - if (list_empty(&iommu- > > >emulated_iommu_groups)) { > > - WARN_ON(iommu->notifier.head); > > - > > vfio_iommu_unmap_unpin_all(iommu); > > - } else { > > - > > vfio_iommu_unmap_unpin_reaccount(iommu); > > - } > > - } > > - iommu_domain_free(domain->domain); > > - list_del(&domain->next); > > - kfree(domain); > > - vfio_iommu_aper_expand(iommu, &iova_copy); > > Previously the aperture is adjusted when a domain is freed... > > > - vfio_update_pgsize_bitmap(iommu); > > - } > > - /* > > - * Removal of a group without dirty tracking may allow > > - * the iommu scope to be promoted. > > - */ > > - if (!group->pinned_page_dirty_scope) { > > - iommu->num_non_pinned_groups--; > > - if (iommu->dirty_page_tracking) > > - vfio_iommu_populate_bitmap_full(iommu); > > - } > > + vfio_iommu_detach_destroy_domain(domain, iommu, > > group); > > kfree(group); > > break; > > } > > > > + vfio_iommu_aper_expand(iommu, &iova_copy); > > but now it's done for every group detach. The aperture is decided > by domain geometry which is not affected by attached groups. Yea, I've noticed this part. Actually Jason did this change for simplicity, and I think it'd be safe to do so? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel