From: Matt Ranostay <mranostay@ti.com>
To: Marc Zyngier <maz@kernel.org>
Cc: <linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Robin Murphy <robin.murphy@arm.com>, Nishanth Menon <nm@ti.com>
Subject: Re: [PATCH v2] arm64: dts: ti: k3-j721s2: fix overlapping GICD memory region
Date: Fri, 17 Jun 2022 08:02:27 -0700 [thread overview]
Message-ID: <YqyXg2//cglzV7eF@ubuntu> (raw)
In-Reply-To: <87tu8j2x9u.wl-maz@kernel.org>
On Fri, Jun 17, 2022 at 03:13:33PM +0100, Marc Zyngier wrote:
> On Fri, 17 Jun 2022 15:02:07 +0100,
> Matt Ranostay <mranostay@ti.com> wrote:
> >
> > GICD region was overlapping with GICR causing the latter to not map
> > successfully, and in turn the gic-v3 driver would fail to initialize.
> >
> > This issue was hidden till commit 2b2cd74a06c3 ("irqchip/gic-v3: Claim iomem resources")
> > replaced of_iomap() calls with of_io_request_and_map() that internally
> > called request_mem_region().
>
> Please correctly wrap long lines in the commit message.
>
> >
> > Respective console output before this patchset:
> >
> > [ 0.000000] GICv3: /bus@100000/interrupt-controller@1800000: couldn't map region 0
> >
> > Fixes: 2b2cd74a06c3 ("irqchip/gic-v3: Claim iomem resources")
>
> No, that's the wrong target for this. Your patch fixes the *original*
> submission of the DT, and this should carry a:
>
> Fixes: b8545f9d3a54 ("arm64: dts: ti: Add initial support for J721S2 SoC")
>
Ah right. Not sure I was thinking there.. will fix in v3.
- Matt
> Please also consider adding a
>
> Cc: stable@vger.kernel.org
>
> Thanks,
>
> M.
>
> --
> Without deviation from the norm, progress is not possible.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-06-17 15:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-17 14:02 [PATCH v2] arm64: dts: ti: k3-j721s2: fix overlapping GICD memory region Matt Ranostay
2022-06-17 14:13 ` Robin Murphy
2022-06-17 14:13 ` Marc Zyngier
2022-06-17 15:02 ` Matt Ranostay [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YqyXg2//cglzV7eF@ubuntu \
--to=mranostay@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=nm@ti.com \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).