From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E8F8AC43334 for ; Fri, 17 Jun 2022 16:43:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=yEqYcqkG3ySFP7YN5igcT2AF7w1oO1PhO0xZgibSPg8=; b=fe3Y8UZXwxr0gjHfTA+9/yETOB WxPtK6ZzINl8T2HH1sCE116K9NCncIEnoO9LsS4ALqQyYaqu+nW4OXuyGAp79z5JFmSsphQAcaDtX /0MGHK8skkrILby62G3KXDssVX6me5V8w5+G5TkqX4Lr5To3h2SDn3cQMB0MEq15A8/XfHJbf4hOM XnBS/AczSwMlSwM8I96Qdd9MC7y2jhYNBRTdNeE+g7qVMbGq2hcjrmltN0hRE3IUvIP5Flr7BVfrv ysdLLGNMWe/5aU+yYSFNIiht435vFq2GvjwFZZROPSVar7paWsvfvm3i66pnW9WBVAFYuLWMyGkym y/zbxjsQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o2F3Y-008HJo-U0; Fri, 17 Jun 2022 16:42:50 +0000 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o2F3T-008HFZ-J8 for linux-arm-kernel@lists.infradead.org; Fri, 17 Jun 2022 16:42:45 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 880EF320094E; Fri, 17 Jun 2022 12:42:38 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 17 Jun 2022 12:42:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stwcx.xyz; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1655484158; x=1655570558; bh=AiSSKnRv3m zrSKSMor1JpwujxpGQtnv79xXFLeYhgvM=; b=aWJ1WEAB7fpW3ksRDFuo+wlB7T QyH5gRz+OrZHIEnuu1Q0h2c/jNLK6vfxIeok3dOj6duThJ4E2xe4xTeaJp52gPp3 BXg9EqYuyV6LxTIGh7zGbF48O8ySDN7sGi6sHJL3iQ7AGmof0Q3v+9uWE4lz81xQ 1mgnObakMLIyipm6DqmQ5qRZu1hwH09VL84Nq8Nqm7TlJ4r0tbK7tyXK9nWBtycJ UUfHkijnECeXXTWD1H209NH+McAfaxZPwSdQy+1R8telkDSA3JfXUEWQ/tfq5U6X S+fgOwlzMsRhH1IO8dO+nxk8xOsk+duLf3P7ohvHGvDJSGv+dRwrzNOKOd+A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1655484158; x=1655570558; bh=AiSSKnRv3mzrSKSMor1JpwujxpGQ tnv79xXFLeYhgvM=; b=WdbnG9Mxrwj0toMuApALwtgRZd3wp96RyLRMt1T1T178 xmszSIuCUxiyV6v0J0hTzzZCEf6MS3cG3qYp5FG2jFp1Cj0nKL3CUc17HdO8xTaR 2Nqx4O3GTSw9Meek3sVu4JbPm6pZpFg6h3t/rj7ZMLKEwSQPx9z+B5yT0tq+2Q+T w7GzL6kczaTqJXVT8GVEix0X98I4foDSQi02NkZ1Tj2kYvy4h5C+E3irIy7lp+re 5fYnlOCqzk7okgLp2FYD7fLaJmf7Z9nEHqO7dLKCibtcd0Iz08iI4CQMrp7tHDwf sCFWpd6XQVaq+iGXql1RbCPaQ2GW0cXO7+l+Nuymlg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedruddvhedguddtudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enfghrlhcuvffnffculdefhedmnecujfgurhepfffhvfevuffkfhggtggujgesghdtreer tddtvdenucfhrhhomheprfgrthhrihgtkhcuhghilhhlihgrmhhsuceophgrthhrihgtkh esshhtfigtgidrgiihiieqnecuggftrfgrthhtvghrnhepjeejteelheelieejuddtudff hfeuueefhfefleehveegvdeigfffheduleehlefhnecuffhomhgrihhnpehgihhthhhusg drtghomhenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhm pehprghtrhhitghksehsthiftgigrdighiii X-ME-Proxy: Feedback-ID: i68a1478a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 17 Jun 2022 12:42:36 -0400 (EDT) Date: Fri, 17 Jun 2022 11:42:35 -0500 From: Patrick Williams To: Logananth Sundararaj Cc: Arnd Bergmann , Olof Johansson , soc@kernel.org, Rob Herring , Joel Stanley , Andrew Jeffery , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, garnermic@gmail.com, thangavel.k@hcl.com, naveen.mosess@hcl.com Subject: Re: [PATCH v2] ARM: dts: aspeed: Adding Facebook Yosemite V3.5 BMC Message-ID: References: <20220616120707.GA22590@logan-ThinkPad-T14-Gen-1> MIME-Version: 1.0 In-Reply-To: <20220616120707.GA22590@logan-ThinkPad-T14-Gen-1> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220617_094244_271627_55A04DBD X-CRM114-Status: GOOD ( 17.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============2563982872276199001==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============2563982872276199001== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="5N0BVpXlyV7XdVV7" Content-Disposition: inline --5N0BVpXlyV7XdVV7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 16, 2022 at 05:37:07PM +0530, Logananth Sundararaj wrote: > The Yosemite V3.5 is a facebook multi-node server > platform that host four OCP server. The BMC > in the Yosemite V3.5 platform based on AST2600 SoC. >=20 > This patch adds linux device tree entry related to > Yosemite V3.5 specific devices connected to BMC SoC. >=20 > Signed-off-by: Logananth Sundararaj >=20 > --- > --- v2 - Enabled i2c drivers. > --- v1 - Initial draft. > --- > arch/arm/boot/dts/Makefile | 1 + > .../boot/dts/aspeed-bmc-facebook-fby35.dts | 277 ++++++++++++++++++ > 2 files changed, 278 insertions(+) > create mode 100644 arch/arm/boot/dts/aspeed-bmc-facebook-fby35.dts A few comments below. =2E.. > +&uart5 { > + status =3D "okay"; > + /* Workaround for AST2600 A0 */ > + compatible =3D "snps,dw-apb-uart"; > +}; Is this comment accurate? Are we using A0 hardware on this system? > +&fmc { > + status =3D "okay"; > + reg =3D <0x1e620000 0xc4>, <0x20000000 0x8000000>; > + flash@0 { > + status =3D "okay"; > + m25p,fast-read; > + label =3D "spi0.1"; > + spi-max-frequency =3D <50000000>; > + spi-tx-bus-width =3D <2>; > + spi-rx-bus-width =3D <2>; > + #include "openbmc-flash-layout-64.dtsi" > + }; > +}; Aren't there two SPI flashes? It seems like it based on: https://github.com/facebook/openbmc-linux/blob/dev-5.10/arch/arm/boot/dts/a= speed-bmc-facebook-fby35.dts#L162 > + > +&spi1 { > + status =3D "okay"; > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&pinctrl_spi1_default>; > + > + flash@0 { > + status =3D "okay"; > + m25p,fast-read; > + label =3D "pnor"; > + spi-rx-bus-width =3D <4>; > + spi-max-frequency =3D <100000000>; > + }; > +}; What is SPI1 used for? I don't see it in the facebook/openbmc-linux DTS. > --=20 > 2.17.1 >=20 Are we missing the pwm/tach support? Or is that still not upstream from Aspeed? --=20 Patrick Williams --5N0BVpXlyV7XdVV7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEBGD9ii4LE9cNbqJBqwNHzC0AwRkFAmKsrvsACgkQqwNHzC0A wRnIcQ//VcCo6ddGOZm0/gcObmyDc7rvp8grACdL5h0TbcdIsfsewa4a+/bp6ZmV flPUo9HCS4mqkHhip2YZbIfiv4ksneGst6p3LupEwLkba87dtBqgrbMhEGTcrjiz fJ3DfwnbPrmexUY3UiNZYifiej2L4PwKk/exlj2hx5VKyErHns+T3vuFov/LkLQX B5o1KWNis2E6Luj8olDfdnHQm7LR5Xsi7j9G1ZAYyb8Uro5Osja/GpAkqOxMKWoM ZpaavyncNeSBiJH6gMYDN2qEwhuWgMVd1nh0OEbNEk0ZfdySMjLHmHqTBX2fXQ/f OchWoLQVoC9Je9k8DAkmJ/cw5n9vOx63CyFezeuI5sFPU8S7DLXH1YFZGkES9cF7 mw+Waxpho39r3wTNMfA6gM1dQ7L+TJxXrjH6W3FfwD6100611QdKX6tfIjiVMAal 7Urzckk+EN2G5AbMnuede7Xfm2iRrZjSwDkG32/xSo7XtN0ZN/X9E4YWVWktxJ8E +pi0fLHaRl2jcgKWYKQGhQc+BTZxS6b1cjJQSNuJSTDaeyQLFAEyyWr2vXGv0OUv lYqB2y2bVrVX1VFHOsO+7eUyT84nekhmEbKJ6Yu95Wr1PgXaQRsQ4loA/aqHPqhY sb2g9WrcUvuycVQbXM4pKwwBfayoj4j8APpfFLqIJ9yiHk9R/tA= =aJmc -----END PGP SIGNATURE----- --5N0BVpXlyV7XdVV7-- --===============2563982872276199001== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============2563982872276199001==--