From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 56683C433EF for ; Fri, 1 Jul 2022 15:30:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WSzjrbY2ml6nDcZxRrZuFmzB7mQLVDHKGlKXHsQsEfw=; b=NZ7O32M26H9KVs efwYjzbuSNkSgChpQw9Qt3BRbaI4I55TCaWAQI5L6hWdPdPHnL6UyArs59vD1CyQT+Mx2mD2dw4/c xKWvUc/EfG6SehbwR7M0vsAEDOjhNddeXfVKh41AXEXbdksiE1WGf4UqCb0hzZz1jxoEu2f0RS+ba hqFoB2Inx3xajOMPmP/PIUIHy5HqZO7vJLYe3ZnjQow2+blvhmfecB4dZKycCxxnuhXzlYQG8i4Cg Jxp2ekpMKJSrP+xCb+lv2erAn99j81aWbWjzfx+4TBUvOeYkE25/2/YsnFsgpawAHQAp1oK1z1Lah fxzewYzVXF0ZX0+sGFdw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o7Iai-005gde-33; Fri, 01 Jul 2022 15:29:56 +0000 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o7Iac-005gYu-Q9 for linux-arm-kernel@lists.infradead.org; Fri, 01 Jul 2022 15:29:53 +0000 Received: by mail-wr1-x42b.google.com with SMTP id k22so3726374wrd.6 for ; Fri, 01 Jul 2022 08:29:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=SQE/nevxcKA6J2DjkomhNRehwjJd8jzrATOHb/r4LVA=; b=JqPnynJnqBpqYAJ77jS6OgeELlFUlXIZzkvmDOmARSD0PYp/CAx6lOu3sEL9KY9aw/ pckpJZmQ9VOvkJnei8UXTJgP2KouA9LdVtjUkFF7EvTzMdor9IYgDISQdmIohZnOkFlr CWtK6Oe0NynIynWxtWPKYdFoe1RWZFGOaNq3Yj5L4wQS2gVGXGKBcinioNlaP2/RI1ar /pXELCFMxsKWFi5/xELnAI1GCP5UH1wbzjDM7QLCtmV+efw86NGcPXffBvJxMDFZKvK6 8OgoI91xxSHiBQkUfutwHVTtj0jn6Xhjo7kFrRgd8lFQl/CorjXP9OEFnhYl0GQy4lrF Uuig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=SQE/nevxcKA6J2DjkomhNRehwjJd8jzrATOHb/r4LVA=; b=alKybAsfte7mj2dfQa9v/lZR2rdCzC0NMZe3U8dpg+Pjm3ZKpoS7jJPQMm6KaQroZH CufcTkeRRmxnvfCyDyzGdULb6ZiEcBf9XDHA38FzBW6wqtKxLBlS3fZB7EUJJokqt4lo 7IBrkfZaAi36XMm33A6xfzC+eYhQ99Gkrcne6R06DZ6UnVmaSLxhv4zH00EUzU2Sk8ZE dPgjgAxBMAy1A5j4iZntUpULVvD7pUkDNj3ujyyMcMDFJhnkGpXsxznTaS/D+McTr4L5 3w8tLFipXF9+8JPxkn/kPtGyLvnFUC6vwpsxlQ00x1eQ3nMx1L+wW0foyuK1GWDFKyne wPDQ== X-Gm-Message-State: AJIora+5oKFILAGZN0XlJCeAf2jGIRQ8kPqEKcivNPXpQC0eEP7LsP0+ PBj1vkC8KDtf27tC9HhB8KBpHg== X-Google-Smtp-Source: AGRyM1uYeem/gulVAxrbR7W86e7vWNrdVIdC3XYtaCRfHHMyY3xeBudzSKn3yofNH1u5ksyStsq29A== X-Received: by 2002:a5d:614e:0:b0:21b:9736:736f with SMTP id y14-20020a5d614e000000b0021b9736736fmr13939214wrt.200.1656689383824; Fri, 01 Jul 2022 08:29:43 -0700 (PDT) Received: from google.com (44.232.78.34.bc.googleusercontent.com. [34.78.232.44]) by smtp.gmail.com with ESMTPSA id y15-20020a5d4acf000000b0021b9c520953sm22721777wrs.64.2022.07.01.08.29.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Jul 2022 08:29:42 -0700 (PDT) Date: Fri, 1 Jul 2022 15:29:40 +0000 From: Sebastian Ene To: Alexandru Elisei Cc: will@kernel.org, julien.thierry.kdev@gmail.com, maz@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, pierre.gondois@arm.com Subject: Re: [PATCH kvmtool] arm64: pvtime: Use correct region size Message-ID: References: <20220629103905.24480-1-alexandru.elisei@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220629103905.24480-1-alexandru.elisei@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220701_082950_893524_7EEC35EA X-CRM114-Status: GOOD ( 23.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jun 29, 2022 at 11:39:05AM +0100, Alexandru Elisei wrote: > pvtime uses ARM_PVTIME_BASE instead of ARM_PVTIME_SIZE for the size of the > memory region given to the guest, which causes to the following error when > creating a flash device (via the -F/--flash command line argument): > > Error: RAM (read-only) region [2000000-27fffff] would overlap RAM region [1020000-203ffff] > > The read-only region represents the guest memory where the flash image is > copied by kvmtool. The region starting at 0x102_0000 (ARM_PVTIME_BASE) is > the pvtime region, which should be 64K in size. kvmtool erroneously creates > the region to be ARM_PVTIME_BASE in size instead, and the last address > becomes: > > ARM_PVTIME_BASE + ARM_PVTIME_BASE - 1 = 0x102_0000 + 0x102_0000 - 1 = 0x203_ffff > > which corresponds to the end of the region from the error message. > > Do the right thing and make the pvtime memory region ARM_PVTIME_SIZE = 64K > bytes, as it was intended. > > Fixes: 7d4671e5d372 ("aarch64: Add stolen time support") > Reported-by: Pierre Gondois > Signed-off-by: Alexandru Elisei > --- > arm/aarch64/pvtime.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > Hi, Thanks for fixing this. Reviewed-by: Sebastian Ene > diff --git a/arm/aarch64/pvtime.c b/arm/aarch64/pvtime.c > index a49cf3ed5478..2933ac7ca959 100644 > --- a/arm/aarch64/pvtime.c > +++ b/arm/aarch64/pvtime.c > @@ -14,15 +14,15 @@ static int pvtime__alloc_region(struct kvm *kvm) > char *mem; > int ret = 0; > > - mem = mmap(NULL, ARM_PVTIME_BASE, PROT_RW, > + mem = mmap(NULL, ARM_PVTIME_SIZE, PROT_RW, > MAP_ANON_NORESERVE, -1, 0); > if (mem == MAP_FAILED) > return -errno; > > ret = kvm__register_ram(kvm, ARM_PVTIME_BASE, > - ARM_PVTIME_BASE, mem); > + ARM_PVTIME_SIZE, mem); > if (ret) { > - munmap(mem, ARM_PVTIME_BASE); > + munmap(mem, ARM_PVTIME_SIZE); > return ret; > } > > @@ -36,8 +36,8 @@ static int pvtime__teardown_region(struct kvm *kvm) > return 0; > > kvm__destroy_mem(kvm, ARM_PVTIME_BASE, > - ARM_PVTIME_BASE, usr_mem); > - munmap(usr_mem, ARM_PVTIME_BASE); > + ARM_PVTIME_SIZE, usr_mem); > + munmap(usr_mem, ARM_PVTIME_SIZE); > usr_mem = NULL; > return 0; > } > -- > 2.36.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel