From: Nicolin Chen <nicolinc@nvidia.com>
To: Robin Murphy <robin.murphy@arm.com>
Cc: marcan@marcan.st, mjrosato@linux.ibm.com,
linux-kernel@vger.kernel.org, thierry.reding@gmail.com,
will@kernel.org, alyssa@rosenzweig.io, jean-philippe@linaro.org,
kvm@vger.kernel.org, zhang.lyra@gmail.com, joro@8bytes.org,
iommu@lists.linux-foundation.org, jonathanh@nvidia.com,
iommu@lists.linux.dev, jgg@nvidia.com, yangyingliang@huawei.com,
orsonzhai@gmail.com, gerald.schaefer@linux.ibm.com,
kevin.tian@intel.com, sven@svenpeter.dev,
linux-arm-msm@vger.kernel.org, john.garry@huawei.com,
alex.williamson@redhat.com, christophe.jaillet@wanadoo.fr,
thunder.leizhen@huawei.com, linux-tegra@vger.kernel.org,
virtualization@lists.linux-foundation.org,
linux-arm-kernel@lists.infradead.org, chenxiang66@hisilicon.com,
linux-s390@vger.kernel.org, cohuck@redhat.com,
robdclark@gmail.com, suravee.suthikulpanit@amd.com,
baolin.wang7@gmail.com, dwmw2@infradead.org,
baolu.lu@linux.intel.com
Subject: Re: [PATCH v4 1/5] iommu: Return -EMEDIUMTYPE for incompatible domain and device/group
Date: Fri, 1 Jul 2022 09:43:10 -0700 [thread overview]
Message-ID: <Yr8kHnK7xRx2DZus@Asurada-Nvidia> (raw)
In-Reply-To: <fab41f28-8f48-9f40-09c8-fd5f0714a9e0@arm.com>
On Fri, Jul 01, 2022 at 11:21:48AM +0100, Robin Murphy wrote:
> > diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu.c b/drivers/iommu/arm/arm-smmu/arm-smmu.c
> > index 2ed3594f384e..072cac5ab5a4 100644
> > --- a/drivers/iommu/arm/arm-smmu/arm-smmu.c
> > +++ b/drivers/iommu/arm/arm-smmu/arm-smmu.c
> > @@ -1135,10 +1135,8 @@ static int arm_smmu_attach_dev(struct iommu_domain *domain, struct device *dev)
> > struct arm_smmu_device *smmu;
> > int ret;
> >
> > - if (!fwspec || fwspec->ops != &arm_smmu_ops) {
> > - dev_err(dev, "cannot attach to SMMU, is it on the same bus?\n");
> > - return -ENXIO;
> > - }
> > + if (!fwspec || fwspec->ops != &arm_smmu_ops)
> > + return -EMEDIUMTYPE;
>
> This is the wrong check, you want the "if (smmu_domain->smmu != smmu)"
> condition further down. If this one fails it's effectively because the
> device doesn't have an IOMMU at all, and similar to patch #3 it will be
Thanks for the review! I will fix that. The "on the same bus" is
quite eye-catching.
> removed once the core code takes over properly (I even have both those
> patches written now!)
Actually in my v1 the proposal for ops check returned -EMEDIUMTYPE
also upon an ops mismatch, treating that too as an incompatibility.
Do you mean that we should have fine-grained it further?
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-07-01 16:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-30 20:36 [PATCH v4 0/5] Simplify vfio_iommu_type1 attach/detach routine Nicolin Chen
2022-06-30 20:36 ` [PATCH v4 1/5] iommu: Return -EMEDIUMTYPE for incompatible domain and device/group Nicolin Chen
2022-07-01 6:53 ` Baolu Lu
2022-07-01 10:21 ` Robin Murphy
2022-07-01 16:43 ` Nicolin Chen [this message]
2022-07-01 18:17 ` Robin Murphy
2022-07-01 19:08 ` Nicolin Chen
2022-06-30 20:36 ` [PATCH v4 2/5] vfio/iommu_type1: Prefer to reuse domains vs match enforced cache coherency Nicolin Chen
2022-06-30 20:36 ` [PATCH v4 3/5] vfio/iommu_type1: Remove the domain->ops comparison Nicolin Chen
2022-06-30 20:36 ` [PATCH v4 4/5] vfio/iommu_type1: Clean up update_dirty_scope in detach_group() Nicolin Chen
2022-06-30 20:36 ` [PATCH v4 5/5] vfio/iommu_type1: Simplify group attachment Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yr8kHnK7xRx2DZus@Asurada-Nvidia \
--to=nicolinc@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=alyssa@rosenzweig.io \
--cc=baolin.wang7@gmail.com \
--cc=baolu.lu@linux.intel.com \
--cc=chenxiang66@hisilicon.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=cohuck@redhat.com \
--cc=dwmw2@infradead.org \
--cc=gerald.schaefer@linux.ibm.com \
--cc=iommu@lists.linux-foundation.org \
--cc=iommu@lists.linux.dev \
--cc=jean-philippe@linaro.org \
--cc=jgg@nvidia.com \
--cc=john.garry@huawei.com \
--cc=jonathanh@nvidia.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=mjrosato@linux.ibm.com \
--cc=orsonzhai@gmail.com \
--cc=robdclark@gmail.com \
--cc=robin.murphy@arm.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=sven@svenpeter.dev \
--cc=thierry.reding@gmail.com \
--cc=thunder.leizhen@huawei.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=will@kernel.org \
--cc=yangyingliang@huawei.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox