From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 62A13C43334 for ; Mon, 20 Jun 2022 09:02:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sgczNyEU9aWia7nfEk1uTm99i+Uf12+1h4aGLUVQkIM=; b=4SM/mJR83n2Swm MENiP5/iA058ENRGTg3RVphefQbn7+U1DUEojaZhSg3V4X/CmfGhcpzaPjD2k51068vBYvaqh3ySd OO1+dDSPZmXMMJH2f5hEwn1fOzwOH6a4AEW8uTBicjbmsL005c33niuzmpHjfZvJzShdsc4qpX7Hb fw/aRtz91dV9qoBcBJG/xHOOrV9+3RFpdBCvbBBd7sEisESXohUj/PvSNpgg3lLJZXVIY5Fpf68j7 e7Zss5XVsrftPauda1cjMHTQUMPXohTZILpREfw2SjUeSymk5XPag/2z99iyR6lw35UUtK9Iltlfu DYsqTF3zmeR5x2Tm79dg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o3DHm-00H2wv-J7; Mon, 20 Jun 2022 09:01:30 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o3DHk-00H2w2-0A for linux-arm-kernel@lists.infradead.org; Mon, 20 Jun 2022 09:01:29 +0000 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id AF8CC883; Mon, 20 Jun 2022 11:01:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1655715681; bh=KcPiSA4mOJI0Q7DYqgykvdJaq4trgNKPzkJE9THtiKI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NjDoEtQ+kewvnqkyrxVBkvGIEVhmpCBk+DqAfSx9WMgDA4l1UmRAII/nvh8HK4dh1 N/ZFDbuGxXbc15n4wO1jfdWlhje0cyeBFwhasCXbapWUCe48LFyXyZ5E6oL6qlO1PJ k4lNgzzX3HwmKoqs72nvjIr+sZLuurjOC8trFXVU= Date: Mon, 20 Jun 2022 12:01:07 +0300 From: Laurent Pinchart To: "Peng Fan (OSS)" Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, paul.elder@ideasonboard.com, marex@denx.de, aford173@gmail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan Subject: Re: [PATCH] arm64: dts: imx8mp: correct clock of pgc_ispdwp Message-ID: References: <20220620032044.4093226-1-peng.fan@oss.nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220620032044.4093226-1-peng.fan@oss.nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220620_020128_232629_4649785F X-CRM114-Status: GOOD ( 15.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Peng, Thank you for the patch. On Mon, Jun 20, 2022 at 11:20:44AM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > The deprecated DIV clk is previously part of the ISP composite clk, but > there is still one child clk(IMX8MP_CLK_MEDIA_ISP_ROOT) sourcing from > IMX8MP_CLK_MEDIA_ISP( previously IMX8MP_CLK_MEDIA_ISP_DIV) > > So IMX8MP_CLK_MEDIA_ISP_ROOT should be used, not IMX8MP_CLK_MEDIA_ISP_DIV. > > Fixes: 9d89189d5227 ("arm64: dts: imx8mp: Add MEDIAMIX power domains") Oops, my bad. Reviewed-by: Laurent Pinchart Tested-by: Laurent Pinchart > Signed-off-by: Peng Fan > --- > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > index b2f4a5f1f73c..2f970d458f80 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > @@ -595,7 +595,7 @@ pgc_hsiomix: power-domains@17 { > pgc_ispdwp: power-domain@18 { > #power-domain-cells = <0>; > reg = ; > - clocks = <&clk IMX8MP_CLK_MEDIA_ISP_DIV>; > + clocks = <&clk IMX8MP_CLK_MEDIA_ISP_ROOT>; > }; > }; > }; -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel