From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8F487C43334 for ; Mon, 20 Jun 2022 11:55:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=g33qfSnaTtkmJ5rPtiO9BxztFS3Ehj6wzr9ieC6WvII=; b=XP+TbyjWOmw1Fq G1trMC8giD+uhH4FBJcCP4OXccMctUoA4bLi7LcZ+e17CEcLKz4z8erVJSWv76yP3K5fAUUIDp8eQ hPZoGXgPQw7PhZk2XjgSgxFkq8zyd5hsChn+oe8UXK5IBfdQzox/O4+vO38pzdZzeQnxID/xLhuuv FEEh5MaXvkejpVY6gTYRyQuLuD+uQdnrotmjv4I66YdkzDTc77aka045r/ee8SqTQG/Yqb17lSttO uAYZv8HQxAQZD07B95lvpEoDMH0e9flY3+L1jXHjP43I2ENAYIAl7LpuGrsR34TxgVmnrgPa20Stn F0PVbXoZt3q56f1IyCBQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o3Fyb-000BSe-Nf; Mon, 20 Jun 2022 11:53:53 +0000 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o3FyY-000BQI-6y; Mon, 20 Jun 2022 11:53:52 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 002EC5C016C; Mon, 20 Jun 2022 07:53:44 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 20 Jun 2022 07:53:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1655726024; x=1655812424; bh=Y+1ESBA9Is I+iRB5+jQBFbcdOi0iPcqA++20lElc3hg=; b=Io6UhmJvaC1FoVxHZJrCKFpyOh rINcO69oMm/0UV11V3RH7maqJe6sbNp/IhEJqhUd9KKM2md4OY4w4CiIicJ9yFNZ rZCFvQrjzlS29BFCtnh4ZRQlYTKw2qYdDXOOr3DP/uhMkyUFfJjV+aUnP/PKkT1q iM4aEbSzm6rGdKCjNYNeBVXLWx0FCmXx1TKU+PSKjjx3dC+/7jJxLF6MP8xd2r3a AmCgP8nt9vgpSr7aUq4Pak6X0aYRdrqlteG1OQft/6xgLLmniLNTU3caxVfs5Kyh S/nYTji5Xi/e8XeNy6vvbgcoS/DRWIqAE/L3w6P1/buzzMOwzgnS8vyznSow== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1655726024; x=1655812424; bh=Y+1ESBA9IsI+iRB5+jQBFbcdOi0i PcqA++20lElc3hg=; b=ZQKehoPa92vHTB3MVokYv0jGD3YgpQGvHsf+7hFhM6bZ ctnu+AlzMCAwOAPIhtIZXfGPTsJE7al3E5I0t36vg9o0rj5H8Fq1qKDmpnvN1Feb 9ln3Cneoqx3rif8B7ZorZr+vscztBQKzPkxchGDw4M7bAlU5kJ0H0OTHg5yB4Wvn wjfESFXEHcxU/2COzMIs/u4leikWuz6IeEsMRR7RXji6E6bsEhFcaGsW1L/3GoS0 FNe1EGJjbI5bnGoY1Q6BPm4nmfZ9AVSxw72P0oLmJ5m2jop6b3sH39ZbGwLr0TZg uHpWbd/Wxeqc7EKoL0yVKaPa0aTPvs2opaiLe+licQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudefuddggeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepifhrvghg ucfmjfcuoehgrhgvgheskhhrohgrhhdrtghomheqnecuggftrfgrthhtvghrnhepgeehue ehgfdtledutdelkeefgeejteegieekheefudeiffdvudeffeelvedttddvnecuffhomhgr ihhnpehkvghrnhgvlhdrohhrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmh epmhgrihhlfhhrohhmpehgrhgvgheskhhrohgrhhdrtghomh X-ME-Proxy: Feedback-ID: i787e41f1:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 20 Jun 2022 07:53:43 -0400 (EDT) Date: Mon, 20 Jun 2022 13:53:41 +0200 From: Greg KH To: Mark-PK Tsai Cc: Catalin Marinas , Will Deacon , Matthias Brugger , yj.chiang@mediatek.com, Jean-Philippe Brucker , stable@vger.kernel.org, Masami Hiramatsu , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH 5.4] arm64: kprobes: Use BRK instead of single-step when executing instructions out-of-line Message-ID: References: <20220615015928.19181-1-mark-pk.tsai@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220615015928.19181-1-mark-pk.tsai@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220620_045350_752282_C7942EFF X-CRM114-Status: GOOD ( 11.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jun 15, 2022 at 09:59:23AM +0800, Mark-PK Tsai wrote: > From: Jean-Philippe Brucker > > commit 7ee31a3aa8f490c6507bc4294df6b70bed1c593e upstream. > > Commit 36dadef23fcc ("kprobes: Init kprobes in early_initcall") enabled > using kprobes from early_initcall. Unfortunately at this point the > hardware debug infrastructure is not operational. The OS lock may still > be locked, and the hardware watchpoints may have unknown values when > kprobe enables debug monitors to single-step instructions. > > Rather than using hardware single-step, append a BRK instruction after > the instruction to be executed out-of-line. > > Fixes: 36dadef23fcc ("kprobes: Init kprobes in early_initcall") > Suggested-by: Will Deacon > Signed-off-by: Jean-Philippe Brucker > Acked-by: Masami Hiramatsu > Link: https://lore.kernel.org/r/20201103134900.337243-1-jean-philippe@linaro.org > Signed-off-by: Will Deacon > Link: https://lore.kernel.org/lkml/20220610063619.7921-1-mark-pk.tsai@mediatek.com/ > Cc: stable@vger.kernel.org > Signed-off-by: Mark-PK Tsai Now queued up, thanks. greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel