From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CD4E2C433EF for ; Mon, 20 Jun 2022 19:54:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wJ5j0R5vXyjGEM3+hpTnP4Dznam6/JiQDyPIUqwBKMk=; b=EO0mc4zKttnRB1 s4kVh+enrndhXLd/6bvaRMFrBkwoEXJimFJfhbSAGXvZq2AdjSs2oXJHnRYBLSMWMWDG2nxWyjYDU VxSLyBcBFTnm0nG28toSu0sxN3yGyNri5ji4RdKpVzy2SNEacEHHfkO08S3c5Hn03tLmyY+H9DtU/ 5odBG/n6YPjapvEPZ2XsMo6zBTvceC9sW7gibTa2tFHpEfUQI6oiTEraOivIhIrWpLTpoAY0MhOZU knJJ+aTdL/4jkRnljI62iJkiUCjlhjUw9A5oaWvH7N1BxfBdU7rUdYAbN2X6FxQTMpJ9r4duoz+vd xgc8t9AeqxA0+bD0S63A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o3NSC-0025D1-Sp; Mon, 20 Jun 2022 19:52:56 +0000 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o3NS7-0025Bw-A4 for linux-arm-kernel@lists.infradead.org; Mon, 20 Jun 2022 19:52:54 +0000 Received: by mail-wr1-x436.google.com with SMTP id o16so16047234wra.4 for ; Mon, 20 Jun 2022 12:52:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=jq8IlzmRmUKlqv3On/oY1AUojxYr/sDjB5anz61AADg=; b=BFMp9cD/zJgwL7A4Gi2zq2+syrCaj79o2kHHXPppdxVFrjwtVwLBYpUIDHRY9a26gL s1Feayiw4pBUYQ4FYhfHO5CdknDD+GXwv9ka04CjqdQMwf0vWl+GJdgALEa8a3Ga7dd/ le3DpXKcQEiR1UvDGX2k3gXztiMotyh4G1Njku9pVrPab4aOx/YOnMWZCvnl+uDd4+Rk b/3VHTUWZHW5sX4LtW/816+QZQUlZVjC/MYeLLaDSj49J0+TBTVfQnYNPqgfq/96Gqbc cB7Gc1s57/b2BFq43tGo3oBWLmMNuPsqvYd0IY5jrJEcIpZBzMpUor866y2vaBqhEtwf Xw5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=jq8IlzmRmUKlqv3On/oY1AUojxYr/sDjB5anz61AADg=; b=sCVWf/JUYnLrPKdlKskXuuV6bEqe715SbECmV80aRt/PvDDLsLQ+4M0hNHrRsKeBdu dexf7ebYBSKhRhEXPumSMGcNol1MqIbcZbpbwDXg26V9DzOXdCBJqopGMLm3yFD3QG5n FvUNur8V3WEc2gSXf7GY5QZylHiW6IEDRtNIjfPM3OHAA3P2a0FcIQwXECCMzp7KqkTG 3j8si40hiQh4CWFLHYpq6TlH+8vt4MDWxIM90SN1IBLx1TR6UdAYp62h96eXDjeSE+CV UuzU/Y+2fRbGeCNvFWXu0CsNi6T5aon+Znzuri1ASzo8pANZFWI1NxokxIU0UD2yOBiW YLmQ== X-Gm-Message-State: AJIora8W5g6co0dcX8rp2qsQv4X3zs8H1048UOyCmCWFPja56i4OcGSC 0bWhyCyw9RSOClUxcaDdio4yBg== X-Google-Smtp-Source: AGRyM1ub028C5N2cNunBKzdOO6smSIhTL/+9sSH1BIJD/KahEQc2jTp8WwsgKdqKKhpYSvmh2TlDGA== X-Received: by 2002:a5d:598e:0:b0:218:525b:4743 with SMTP id n14-20020a5d598e000000b00218525b4743mr24392302wri.708.1655754768944; Mon, 20 Jun 2022 12:52:48 -0700 (PDT) Received: from Red ([2a01:cb1d:3d5:a100:264b:feff:fe03:2806]) by smtp.googlemail.com with ESMTPSA id j19-20020a05600c1c1300b0039c5645c60fsm28023077wms.3.2022.06.20.12.52.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jun 2022 12:52:48 -0700 (PDT) Date: Mon, 20 Jun 2022 21:52:44 +0200 From: LABBE Corentin To: heiko@sntech.de, krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org, m.reichl@fivetechno.de Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, stable@kernel.org Subject: Re: [PATCH] arm64: rockchip: rk3399-roc-pc: prevent fusb302 powering off the board during boot Message-ID: References: <20220620110407.2393644-1-clabbe@baylibre.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220620110407.2393644-1-clabbe@baylibre.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220620_125251_544423_DB0A5052 X-CRM114-Status: GOOD ( 16.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Le Mon, Jun 20, 2022 at 11:04:07AM +0000, Corentin Labbe a =E9crit : > The rk3399-roc-pc never finish booting because it is powered off when pro= bing > fusb302. > = > The type c port is disabled because not present in DT as can seen in dmes= g: > OF: graph: no port node found in /i2c@ff3d0000/usb-typec@22 > = > So adding the port in DT (as needed by the device tree schema of > fusb302), permits the board to survive and finish booting. > = > CC: stable@kernel.org # 5.10+ > Fixes: 8bb878cf20ae ("arm64: dts: rockchip: add support for ROC-RK3399-PC= board") > Signed-off-by: Corentin Labbe > --- > This patch is tested on 5.10.123, 5.15.48 and next-20220614 > = Please ignore this for now, it fixes the issue but [ 31.653778] typec_fusb302 7-0022: cannot register tcpm port, ret=3D-22 [ 31.659415] typec_fusb302: probe of 7-0022 failed with error -22 So while having a board which boot fine is better, having everything well p= robed will be better. For fixing the probe error, adding the following is sufficiant: @@ -558,6 +559,9 @@ connector { data-role =3D "host"; label =3D "USB-C"; power-role =3D "dual"; + op-sink-microwatt =3D <1000000>; + sink-pdos =3D ; + source-pdos =3D ; = ports { #address-cells =3D <1>; But this bring the initial issue, the board is still dont booting... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel