From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D472AC43334 for ; Tue, 21 Jun 2022 07:55:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4foMaRZCDCR2G+X0qnryyF4VXK6YHCvtsXtdLgq3T0M=; b=h7JMxzNU/X3PjE eNUeV+7d9qu9IaA6bHAoWa/neh+1jDJYRW/ZaM7r57JIkijzSQPzi+xB39DmokxhPi9M5S2kzCwY3 RoBXcK7Wa8MtSdqewcvqWSZM9DRweGwnx5273fPkJJFvYWMXS6v52x6LcUmLH23PPfaBUYwmk743Q 3z8JVhs3gg6Qq4DBa1UolquQCDHD4rWGhZTZomvImEpw4Qoq55pQfeNOUauyjt/bfKX12jKZuoT7M jbIYEeVthj32X3JxeQG5ETnmzPGrSrMJz0ybRkaCpnb3EYicrYyChR1l7HHxwuSapjUvNqWlkSkWK 30yr+LuxRV78PAtcueyw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o3Yhp-004DeS-I1; Tue, 21 Jun 2022 07:53:49 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o3Yhl-004DdY-Me for linux-arm-kernel@lists.infradead.org; Tue, 21 Jun 2022 07:53:47 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 155096148C; Tue, 21 Jun 2022 07:53:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 746A6C3411D; Tue, 21 Jun 2022 07:53:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655798024; bh=MpeEIIy9pRKV+9+aIbYO9RMnNjY4VitAYHKXHqLyjz4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Tv6Z4bwBbfRqciNuJn1ZLOH+05a+7YGR3D7ZPhImIueGNT9qxD0VBIMoHAiYNfFsC gGAamaeXB47eXKx0ItUmsnhv4PjCBp3ZebLxG8y08rc+L74wEI1xrOhq8VboWKrzAJ 6qzYEoG1ED40AkWBVh6Hd1aOBoXK7VnLA37Dww91gMIAV+Z7TjMSiiNu/XGKJBRY8L 3rbRGV0SRjCGkGZ6/BM2vPZ7g6HNfHPLSKR8H6laZiy3qldgi+rYeMbz82FfXWvyIR PYE0x7//qOfMn9xONXBQBtm5ilo7aEjTT1+tu/hF9/skB+1AoO4XseO/cBaAkijtvO b1/E5+aV7xAOw== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1o3Yhd-0005fc-7k; Tue, 21 Jun 2022 09:53:37 +0200 Date: Tue, 21 Jun 2022 09:53:37 +0200 From: Johan Hovold To: Baruch Siach Cc: Andy Gross , Bjorn Andersson , Stanimir Varbanov , Selvam Sathappan Periakaruppan , Kathiravan T , Bjorn Helgaas , Rob Herring , Thierry Reding , Jonathan Hunter , Jingoo Han , Gustavo Pimentel , Robert Marko , Bryan O'Donoghue , Pali =?utf-8?B?Um9ow6Fy?= , linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org Subject: Re: [PATCH v7 3/3] PCI: qcom: Add IPQ60xx support Message-ID: References: <87k09aekop.fsf@tarshish> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87k09aekop.fsf@tarshish> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220621_005345_820990_E6ED4688 X-CRM114-Status: GOOD ( 21.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 21, 2022 at 06:39:45AM +0300, Baruch Siach wrote: > Hi Johan, > > Thanks for your review comments. > > On Mon, Jun 20 2022, Johan Hovold wrote: > > On Sun, Jun 12, 2022 at 01:18:35PM +0300, Baruch Siach wrote: > >> From: Selvam Sathappan Periakaruppan > >> > >> IPQ60xx series of SoCs have one port of PCIe gen 3. Add support for that > >> platform. > >> > >> The code is based on downstream[1] Codeaurora kernel v5.4 (branch > >> win.linuxopenwrt.2.0). > >> > >> Split out the DBI registers access part from .init into .post_init. DBI > >> registers are only accessible after phy_power_on(). > >> > >> [1] https://source.codeaurora.org/quic/qsdk/oss/kernel/linux-ipq-5.4/ > >> > >> Signed-off-by: Selvam Sathappan Periakaruppan > >> Signed-off-by: Baruch Siach > >> --- > > > >> +static void qcom_pcie_deinit_2_9_0(struct qcom_pcie *pcie) > >> +{ > >> + struct qcom_pcie_resources_2_9_0 *res = &pcie->res.v2_9_0; > >> + > >> + clk_bulk_disable_unprepare(ARRAY_SIZE(res->clks), res->clks); > > > > Assert reset as you do in the init error path? > > Not sure about that. As I understand, the reset assert/deassert sequence > on init is meant to ensure clean startup state. Deinit most likely does > not need that. So maybe I should remove reset assert from init error > path instead? Yeah, I think the init error path and deinit should at least be consistent. > As always, this code sequence is from downstream kernel. I have no > access to documentation. I feel your pain. ;) Johan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel