From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 46183C43334 for ; Tue, 21 Jun 2022 11:02:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xtATtOSyDyH0lNBVzRh+rpEm8lv4Na4Od5LnOCgy/tg=; b=ZkSeYYjHiTu7qa 75mqo3O6Uo+j7l5fsnwZHoqtUFqVBYelcTXa8chHqvltEdimbmgry27vvIJDcdkyhyzVMnLe9ey4L V3Tp1iUI4hGvgMZQpKIzuDD16aUA/nBQM/FfVp7zbuakhWWV3jXHxyXFMys1mgHK+TkMspBIhPdt7 h42FW1kaItjY2jNty3y/2i91Rhw72+zbZ6hKvHXm4kc1hIisWiVRaDPCqI30xAtOMo+ous3zkbGMR KmJK14RBC73HxYXFLOX65nClAOX9SuOEiK1m10kJzrMqLeKxd0J8Col++wbKqQPc0b8/3faleVKjx nKBxWOG41J3T77JRzQUA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o3bcg-004zVH-3w; Tue, 21 Jun 2022 11:00:42 +0000 Received: from mga04.intel.com ([192.55.52.120]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o3bcd-004zQX-8g for linux-arm-kernel@lists.infradead.org; Tue, 21 Jun 2022 11:00:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655809239; x=1687345239; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ZdbxRsGGheu6GBHdOyV1uGckiP8Rrf2B1AVqMjy5upc=; b=mCSDycdAskV+IpzZ6W+Q9sAPlyVrOmnFeUS+plLBUWNl8M0L7eSMagfg eEaM0U8T4WqknT5LAIZFwh5eruUeQ1odgvdDvrBX7/bGjM9hqZ9MArFe2 /IGInAeB5rJhhpuSgT4LXasgKZ9wLlJclkXIEAICZ5n7LOLiHJy1gJNaW 1sRg9QAb5/8iHsObLyXCWcJED8bCJw7tlqcgtuboQmdPWekvJC2L6fFD2 M46kQqlhyPeh+i+nvyUfXNPHhgHcM1QnEeSDDEyGavRWT+FuXnkbVvpvT eQhEJVvK6C6HeVBR61t6Yx8/odsg42VIUmcNfcCMCVcjwDdX0kkTNY3Iu A==; X-IronPort-AV: E=McAfee;i="6400,9594,10384"; a="278860217" X-IronPort-AV: E=Sophos;i="5.92,209,1650956400"; d="scan'208";a="278860217" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jun 2022 04:00:33 -0700 X-IronPort-AV: E=Sophos;i="5.92,209,1650956400"; d="scan'208";a="655092970" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jun 2022 04:00:30 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1o3baK-000qwz-Ou; Tue, 21 Jun 2022 13:58:16 +0300 Date: Tue, 21 Jun 2022 13:58:16 +0300 From: Andy Shevchenko To: Fabio Estevam , Ksenija Stanojevic , Marek Vasut Cc: linux-iio@vger.kernel.org, "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , linux-kernel , Jonathan Cameron , Lars-Peter Clausen , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , NXP Linux Team Subject: Re: [PATCH v1 1/1] iio: adc: mxs-lradc-adc: Get rid of OF specifics Message-ID: References: <20220530173324.921-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220621_040039_409484_CE4F5925 X-CRM114-Status: GOOD ( 19.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 20, 2022 at 06:13:53PM -0300, Fabio Estevam wrote: > On Mon, May 30, 2022 at 2:33 PM Andy Shevchenko > wrote: ... > I tried to apply the same change inside > drivers/input/touchscreen/mxs-lradc-ts.c: > > --- a/drivers/input/touchscreen/mxs-lradc-ts.c > +++ b/drivers/input/touchscreen/mxs-lradc-ts.c > @@ -675,11 +675,9 @@ static int mxs_lradc_ts_probe(struct platform_device *pdev) > if (irq < 0) > return irq; > > - virq = irq_of_parse_and_map(node, irq); > - > mxs_lradc_ts_stop(ts); > > - ret = devm_request_irq(dev, virq, > + ret = devm_request_irq(dev, irq, > mxs_lradc_ts_handle_irq, > 0, mxs_lradc_ts_irq_names[i], ts); > if (ret) > > but I still get the following warning: So just to be sure. You got it before the above change applied, correct? I'm wondering how this all LRADC was supposed to work. The IRQs are assigned based on abstract numbering without any IRQ domain behind it. This is not how it's designed in Linux. Adding Ksenija and Marek to shed a light. > [ 6.135583] ------------[ cut here ]------------ > [ 6.140366] WARNING: CPU: 0 PID: 1 at drivers/base/platform.c:449 > __platform_get_irq_byname+0x74/0x90 > [ 6.151053] 0 is an invalid IRQ number > [ 6.155201] Modules linked in: > [ 6.158444] CPU: 0 PID: 1 Comm: swapper Not tainted > 5.18.5-00001-g3e38be7e4832 #108 > [ 6.166537] Hardware name: Freescale MXS (Device Tree) > [ 6.172040] unwind_backtrace from show_stack+0x10/0x14 > [ 6.177503] show_stack from __warn+0xc4/0x1cc > [ 6.182356] __warn from warn_slowpath_fmt+0x90/0xc8 > [ 6.187549] warn_slowpath_fmt from __platform_get_irq_byname+0x74/0x90 > [ 6.194698] __platform_get_irq_byname from platform_get_irq_byname+0x10/0x30 > [ 6.202286] platform_get_irq_byname from mxs_lradc_ts_probe+0x19c/0x380 > [ 6.209216] mxs_lradc_ts_probe from platform_probe+0x58/0xb8 > [ 6.215383] platform_probe from really_probe+0xfc/0x288 > [ 6.220907] really_probe from __driver_probe_device+0x80/0xe4 > [ 6.227145] __driver_probe_device from driver_probe_device+0x30/0xd8 > [ 6.234010] driver_probe_device from __driver_attach+0x70/0xf4 > [ 6.240137] __driver_attach from bus_for_each_dev+0x74/0xc0 > [ 6.246195] bus_for_each_dev from bus_add_driver+0x154/0x1e8 > [ 6.252359] bus_add_driver from driver_register+0x74/0x108 > [ 6.258131] driver_register from do_one_initcall+0x8c/0x2fc > [ 6.264198] do_one_initcall from kernel_init_freeable+0x184/0x210 > [ 6.270588] kernel_init_freeable from kernel_init+0x10/0x108 > [ 6.276756] kernel_init from ret_from_fork+0x14/0x3c > [ 6.282224] Exception stack(0xc8819fb0 to 0xc8819ff8) > [ 6.287444] 9fa0: 00000000 > 00000000 00000000 00000000 > [ 6.295988] 9fc0: 00000000 00000000 00000000 00000000 00000000 > 00000000 00000000 00000000 > [ 6.304631] 9fe0: 00000000 00000000 00000000 00000000 00000013 00000000 > [ 6.311392] irq event stamp: 128211 > [ 6.315220] hardirqs last enabled at (128221): [] > __up_console_sem+0x54/0x64 > [ 6.323632] hardirqs last disabled at (128230): [] > __up_console_sem+0x40/0x64 > [ 6.331821] softirqs last enabled at (128200): [] > __do_softirq+0x31c/0x4bc > [ 6.340041] softirqs last disabled at (128191): [] > irq_exit+0x150/0x18c > [ 6.347913] ---[ end trace 0000000000000000 ]--- > [ 6.364587] input: mxs-lradc-ts as > /devices/soc0/80000000.apb/80040000.apbx/80050000.lradc/mxs-lradc-ts/input/input0 > > Any suggestions? -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel