From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2326CC43334 for ; Thu, 23 Jun 2022 19:09:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jJS0nSRfA+xlowj+InkSgVuWurSftxDmO12gGO2NY+w=; b=3nZkR8bWTZ99Pq CdHwDAq8Kp8s9s63ge4qcKaZzJ89tyuXvZsUga8V7e+5ppg1+7c2tUhspv8N/9H7u8cvBYZEQJyaI f+17PHv6VeRhmNTNEQveAeuOsofqMTckeClcbRGC29BVpS6rMLQ/pj5tVWsNsCnF5CUaDp0LACb0J 8wYFfmWCROtT4dXwXKSQJDNCu6BGPXkCOFHBleyZSEn39zbM8vUTD6rZ7QzoxAOfQqUJe+8f07868 2YA1ac1Jr4kqlOS9hnanoAOxHmMWTFKGELXtmWPKQmF/yrSToxmoB8cbivBDMo6jnUunWrVwO/EDm XcKx4XCTwzvBcx4N3Q0w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o4SC3-00GRET-3T; Thu, 23 Jun 2022 19:08:43 +0000 Received: from alexa-out.qualcomm.com ([129.46.98.28]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o4SBz-00GRCy-Vd for linux-arm-kernel@lists.infradead.org; Thu, 23 Jun 2022 19:08:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1656011320; x=1687547320; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=J+82fiAkS6UDD5/pp26a92/IR26KYgUmTE+aTlC+9Go=; b=pDWUtaYZzJXb54SZ629vrPktbfBWyQvSb8kSwNMwd8zmKMiRmBSk1GQe Mtcjed3u/8qkHQd49viXyM4+ldT11I/6L7D8+gQtma9F+33SiQSlETUuX f/nyy2nm9mLpVkr/Bpqa2awXaR7AhD6ZQ37GL6uQcHVsof33c2KwCaOGW I=; Received: from ironmsg08-lv.qualcomm.com ([10.47.202.152]) by alexa-out.qualcomm.com with ESMTP; 23 Jun 2022 12:08:36 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg08-lv.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2022 12:08:36 -0700 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Thu, 23 Jun 2022 12:08:35 -0700 Received: from qian (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Thu, 23 Jun 2022 12:08:34 -0700 Date: Thu, 23 Jun 2022 15:08:32 -0400 From: Qian Cai To: Eric Biggers CC: Herbert Xu , "David S. Miller" , Ard Biesheuvel , Catalin Marinas , Will Deacon , , , Subject: Re: [PATCH] arm64/crypto: Select AEAD2 for GHASH_ARM64_CE Message-ID: References: <20220622142557.144536-1-quic_qiancai@quicinc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220623_120840_088075_8391D37E X-CRM114-Status: GOOD ( 16.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jun 23, 2022 at 10:17:19AM -0700, Eric Biggers wrote: > On Wed, Jun 22, 2022 at 10:25:57AM -0400, Qian Cai wrote: > > Otherwise, we could fail to compile. > > > > ld: arch/arm64/crypto/ghash-ce-glue.o: in function 'ghash_ce_mod_exit': > > ghash-ce-glue.c:(.exit.text+0x24): undefined reference to 'crypto_unregister_aead' > > ld: arch/arm64/crypto/ghash-ce-glue.o: in function 'ghash_ce_mod_init': > > ghash-ce-glue.c:(.init.text+0x34): undefined reference to 'crypto_register_aead' > > > > Fixes: 37b6aab68fae ("crypto: arm64/ghash - drop PMULL based shash") > > I don't see how the Fixes commit is related. Hasn't this been a problem since > commit 537c1445ab0b, which added an AEAD algorithm to this module? Ah, you are probably right. crypto_unregister_aead and crypto_register_aead are already there in the previous commit. > > > diff --git a/arch/arm64/crypto/Kconfig b/arch/arm64/crypto/Kconfig > > index 4391a463abd7..6b2ecc193bc0 100644 > > --- a/arch/arm64/crypto/Kconfig > > +++ b/arch/arm64/crypto/Kconfig > > @@ -71,6 +71,7 @@ config CRYPTO_GHASH_ARM64_CE > > select CRYPTO_HASH > > select CRYPTO_GF128MUL > > select CRYPTO_LIB_AES > > + select CRYPTO_AEAD2 > > I don't think CRYPTO_AEAD2 is meant to be selected directly. It should be > CRYPTO_AEAD instead. I am not sure about that. I chose CRYPTO_AEAD2 because that is in the Makefile. obj-$(CONFIG_CRYPTO_AEAD2) += aead.o _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel