From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C9B11C43334 for ; Thu, 23 Jun 2022 17:18:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vd/o2gRD15sU3M/1eDL58cWZXWB5B44GpeFFzr7UBqc=; b=4jEBZOvIesUaYQ MD/8QeCuxIdaWq8dVN/H5TbDrfUzZNqmL8REuwc9DWblX4ACCTEQOrCULz5W6ClEPBIpQHrJPMBo3 S8GPD1LBNjYSmPGKXOe0BYPQOi4fmdED0eHF31LviiucTeY+bGPUnygTUmXaPgMzsX+QqpK7NpNHB zTYK2101/ikqTS7vB47pld3yHPLQCh7CxdLk9og3gfpggbz5em6Y+XnAPvtRjxJWlCc02JkaNfrQJ kW8BH2wjWODh3zBJiBKQihvt03ny3MCQiselRMzZmMxgqgrkzA7zlxLqVc3R/rV4+0ykL0kuPczPo Ah9L8raJr/KBXCZw1NiA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o4QSO-00G56h-LC; Thu, 23 Jun 2022 17:17:28 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o4QSK-00G563-R5 for linux-arm-kernel@lists.infradead.org; Thu, 23 Jun 2022 17:17:26 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 888C2B824B8; Thu, 23 Jun 2022 17:17:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 05AC4C3411B; Thu, 23 Jun 2022 17:17:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656004641; bh=ECl0+thSGaC6aSTo4aDyPUB/qSChvQhdGO/voCXF0rw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZDCUMclpM1j1gNt6R5tv7+I6GS+Uen+mRM4eVYaL3jd1t98CZBGVgF5FUBEC+7UgL rc0ScSbWK5cIvvH+s9C4CwFPCteIXHLfYtz0CIQEe4WOarBKQ9qpGqTb2RHRhVhIeq oII0mlUrL8XXsxxRIPaEfrLk60a+jXmymeJQ07RKTlG/n8HzFlvNhagWNKBDny4Yen U4Bdd+j7QdoUNQRcTMxSnusu0QAGAtVuDPR7wYybD2WrTwBMXz2JpkDn33fFjBhnO8 rEP8UgQkNPDebXQJfkG7yzfmdOKNsxnlsF2mFvAbg3YfTpzKOrLTUlmJxEqjGESkS1 8Ox+pt32FSUow== Date: Thu, 23 Jun 2022 10:17:19 -0700 From: Eric Biggers To: Qian Cai Cc: Herbert Xu , "David S. Miller" , Ard Biesheuvel , Catalin Marinas , Will Deacon , linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64/crypto: Select AEAD2 for GHASH_ARM64_CE Message-ID: References: <20220622142557.144536-1-quic_qiancai@quicinc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220622142557.144536-1-quic_qiancai@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220623_101725_064035_28F7FFAB X-CRM114-Status: GOOD ( 14.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jun 22, 2022 at 10:25:57AM -0400, Qian Cai wrote: > Otherwise, we could fail to compile. > > ld: arch/arm64/crypto/ghash-ce-glue.o: in function 'ghash_ce_mod_exit': > ghash-ce-glue.c:(.exit.text+0x24): undefined reference to 'crypto_unregister_aead' > ld: arch/arm64/crypto/ghash-ce-glue.o: in function 'ghash_ce_mod_init': > ghash-ce-glue.c:(.init.text+0x34): undefined reference to 'crypto_register_aead' > > Fixes: 37b6aab68fae ("crypto: arm64/ghash - drop PMULL based shash") I don't see how the Fixes commit is related. Hasn't this been a problem since commit 537c1445ab0b, which added an AEAD algorithm to this module? > diff --git a/arch/arm64/crypto/Kconfig b/arch/arm64/crypto/Kconfig > index 4391a463abd7..6b2ecc193bc0 100644 > --- a/arch/arm64/crypto/Kconfig > +++ b/arch/arm64/crypto/Kconfig > @@ -71,6 +71,7 @@ config CRYPTO_GHASH_ARM64_CE > select CRYPTO_HASH > select CRYPTO_GF128MUL > select CRYPTO_LIB_AES > + select CRYPTO_AEAD2 I don't think CRYPTO_AEAD2 is meant to be selected directly. It should be CRYPTO_AEAD instead. - Eric _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel