From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 76F0AC433EF for ; Sun, 26 Jun 2022 03:21:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PO2O0iLtcO/kDUkaZ8VUiwvX0tTV9Yb2iCBsHjP9Hwk=; b=du5kwu3l7y3Nnj V2dgpCR/lM9s8sG8dZc/yrzrBYDz7YLb/Z8ys08dh2tzVdd+GDn8BVdHEGU+K3fcKqNJVsOsz+xg+ rG1o0DEHaT8EPNk2GLEwpgEz1kcrT2qx/JwbcDA4WX+8mf9QIOb+HxbheCeZEy0YJeDdQvFx14Kmj TF46OdMd80AcAgjFXT31bBiRLfRfvUKDR/tadvv56SGElmQLM9zyvapoyTyEZHU9Y5VZdjoHZR7zv 29dlG8iDbbhJMzOZwDFwABWb7IQFM3wojMDJ+QNujxpacTARvhq49gQsj48r43vnDj9QA99NrE5lv OZq9VBFezdmYcTUOuRgw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o5Ioe-009FQ7-D5; Sun, 26 Jun 2022 03:20:04 +0000 Received: from mail-ot1-x335.google.com ([2607:f8b0:4864:20::335]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o5Ioa-009FO8-Rv for linux-arm-kernel@lists.infradead.org; Sun, 26 Jun 2022 03:20:02 +0000 Received: by mail-ot1-x335.google.com with SMTP id l9-20020a056830268900b006054381dd35so4933258otu.4 for ; Sat, 25 Jun 2022 20:20:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=w/mYeMPmd0Fk8nQabOaGxE7uHrcY17tT/p63c/0m/K8=; b=y4TkfpoCC1kczoEYXJb+AciMyXrERHIx7++CgsHxTlOA/OI+ST+BTCmIH1CpjVAG35 YTtbNUjvO0QbvJrexaeD3eA/1t3Meb/Ify9txPu1IgrYdCYKgoNHiSrfxEKX6BtbmKUS 9jUeqlnMe15Rnp9aWAOrn5hCbeCVl0ZTUoq46r4iENpKoy8kazmApT91Rmmf/90X/857 h5uB6h3HeYkWicLpluc0eoBNulVXrYyK1rwlWqTISEHu6YDZBsZ3N4d55cOZD4Zjigg/ hSRAmRltMtv4sEt4NZDS31dxJzC0qYQdEaSVCyGeKf6SWgHIm6fA2Ufr1K1Cgo2SWclC 2ZSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=w/mYeMPmd0Fk8nQabOaGxE7uHrcY17tT/p63c/0m/K8=; b=PmRGWgjBZH5M60qR5qLvtDsvLMHNvWtjz6/te5IgGjwUrsyJboR71q5mjwCgbIYsvk bE9M7MeustjiYxy4aKVbZWiLhLvRmpR49YjB2P2Hmp6EccWevFhi2GOXxMs+VVjaboad fFKLGx/7MlsxjvE4l1qaDfmq5m6Szei1vqODMhX6B55KI1qPChQeHh0QBYOv9ECnW8hb yyLmF3vHz+jzmYzREeX1/yVu9omkl9I9lwwXdCr0vra34XI8gI5NtjrXFeUSvQQElzq+ xN4wOmrciN0cIbjMyjo2yfBYQzKZ4/FjuJGtMzB9evtcywEKVUlTNKk8Qiy/RP6ZuTBu iBdQ== X-Gm-Message-State: AJIora9GF+7ogN2cnBn9UnQm5Ir3a9qoQeV+YMObAk6X+KhY2q1N75iH EWsLTeyWjXpELwldCs6RVFlEeA== X-Google-Smtp-Source: AGRyM1ueYuHJYGTGsRDe7GO1mvPAOg2cTr58tcPwudtIXoIbwJopBM7c20rw5dd4IUzHo/kBe21jmA== X-Received: by 2002:a05:6830:1f26:b0:60c:2662:ef9a with SMTP id e6-20020a0568301f2600b0060c2662ef9amr3133660oth.37.1656213599397; Sat, 25 Jun 2022 20:19:59 -0700 (PDT) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id 4-20020a544184000000b0032f75714af1sm3422554oiy.18.2022.06.25.20.19.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Jun 2022 20:19:58 -0700 (PDT) Date: Sat, 25 Jun 2022 22:19:56 -0500 From: Bjorn Andersson To: Rajendra Nayak Cc: Krzysztof Kozlowski , Andy Gross , Georgi Djakov , Rob Herring , Catalin Marinas , Will Deacon , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Rob Herring Subject: Re: [PATCH v4 1/4] dt-bindings: interconnect: qcom,sdm845-cpu-bwmon: add BWMON device Message-ID: References: <20220601101140.170504-1-krzysztof.kozlowski@linaro.org> <20220601101140.170504-2-krzysztof.kozlowski@linaro.org> <3e4e504c-5a38-43cd-ea8d-afbbb72eacad@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220625_202000_951337_D7717194 X-CRM114-Status: GOOD ( 27.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed 22 Jun 06:58 CDT 2022, Rajendra Nayak wrote: > > > On 6/7/2022 12:20 PM, Krzysztof Kozlowski wrote: > > On 06/06/2022 23:11, Bjorn Andersson wrote: > > > On Wed 01 Jun 03:11 PDT 2022, Krzysztof Kozlowski wrote: > > > > > > > Add bindings for the Qualcomm Bandwidth Monitor device providing > > > > performance data on interconnects. The bindings describe only BWMON > > > > version 4, e.g. the instance on SDM845 between CPU and Last Level Cache > > > > Controller. > > > > > > > > Signed-off-by: Krzysztof Kozlowski > > > > Reviewed-by: Rob Herring > > > > Acked-by: Georgi Djakov > > > > --- > > > > .../interconnect/qcom,sdm845-cpu-bwmon.yaml | 97 +++++++++++++++++++ > > > > 1 file changed, 97 insertions(+) > > > > create mode 100644 Documentation/devicetree/bindings/interconnect/qcom,sdm845-cpu-bwmon.yaml > > > > > > > > diff --git a/Documentation/devicetree/bindings/interconnect/qcom,sdm845-cpu-bwmon.yaml b/Documentation/devicetree/bindings/interconnect/qcom,sdm845-cpu-bwmon.yaml > > > > new file mode 100644 > > > > index 000000000000..8c82e06ee432 > > > > --- /dev/null > > > > +++ b/Documentation/devicetree/bindings/interconnect/qcom,sdm845-cpu-bwmon.yaml > > > > @@ -0,0 +1,97 @@ > > > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > > > > +%YAML 1.2 > > > > +--- > > > > +$id: http://devicetree.org/schemas/interconnect/qcom,sdm845-cpu-bwmon.yaml# > > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > > + > > > > +title: Qualcomm Interconnect Bandwidth Monitor > > > > + > > > > +maintainers: > > > > + - Krzysztof Kozlowski > > > > + > > > > +description: > > > > + Bandwidth Monitor measures current throughput on buses between various NoC > > > > + fabrics and provides information when it crosses configured thresholds. > > > > + > > > > +properties: > > > > + compatible: > > > > + enum: > > > > + - qcom,sdm845-cpu-bwmon # BWMON v4 > > > > > > It seems the thing that's called bwmon v4 is compatible with a number of > > > different platforms, should we add a generic compatible to the binding > > > as well, to avoid having to update the implementation for each SoC? > > > > > > (I.e. "qcom,sdm845-cpu-bwmon", "qcom,bwmon-v4") > > it seems pretty useful to have the "qcom,bwmon-v4" and "qcom,bwmon-v5" > compatibles, I tried these patches on a sc7280 device which has a bwmon4 > between the cpu and caches (and also has a bwmon5 between the caches and DDR) > and the driver works with zero changes. > But does the '4' and '5' has a relation to the hardware? Or is just the 4th and 5th register layout supported by the downstream driver? Regards, Bjorn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel