From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 47CD1C433EF for ; Sun, 26 Jun 2022 09:23:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NA5PlmVtG/U3+7WXFk/uNa/OC709AmwV29+GyiyJCjo=; b=LAai5iAqHPMPm/ 5U3ROh7OK+G2/Gr+Flw/tWv55CQEHu5G2/9Z6MxcmbpidcpKr12jQfqCUO3jTyHmzBogORbhL5Pd4 OTl1LImVVcO1GY1/sYUmJ3NBOmDFXT32A01vNfDXuhp/f/b7YtWz9mssZNEMpSuehLvL9PNFu6NHO lCPOL+yc79boJz4lTTrJ4KiQLbGWeMTNtmZ0DTdt9plQbPVGiWP3Elfunu+2La3tVx4Xno0h9t34l mIDI0Wa4xGWih07gKnHhrULxoeSECHVBYCeH4jjmUIYC/IiAi686IKcNl/JZzZJ/Ofg2D4+2j7KtW xNkrot14eDfJZPMYozMA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o5OTg-00ArcF-8N; Sun, 26 Jun 2022 09:22:48 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o5OTd-00ArbU-Cc for linux-arm-kernel@lists.infradead.org; Sun, 26 Jun 2022 09:22:46 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 675652B; Sun, 26 Jun 2022 02:22:43 -0700 (PDT) Received: from FVFF77S0Q05N (unknown [10.57.71.61]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DA3B13F792; Sun, 26 Jun 2022 02:22:41 -0700 (PDT) Date: Sun, 26 Jun 2022 10:22:39 +0100 From: Mark Rutland To: Ard Biesheuvel Cc: linux-arm-kernel@lists.infradead.org, Marc Zyngier , Will Deacon , Kees Cook , Catalin Marinas , Mark Brown , Anshuman Khandual Subject: Re: [PATCH v5 01/21] arm64: head: move kimage_vaddr variable into C file Message-ID: References: <20220624150651.1358849-1-ardb@kernel.org> <20220624150651.1358849-2-ardb@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220624150651.1358849-2-ardb@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220626_022245_535940_72FA3B56 X-CRM114-Status: GOOD ( 15.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 24, 2022 at 05:06:31PM +0200, Ard Biesheuvel wrote: > This variable definition does not need to be in head.S so move it out. > > Signed-off-by: Ard Biesheuvel > Reviewed-by: Anshuman Khandual Nice! Acked-by: Mark Rutland > --- > arch/arm64/kernel/head.S | 7 ------- > arch/arm64/mm/mmu.c | 3 +++ > 2 files changed, 3 insertions(+), 7 deletions(-) > > diff --git a/arch/arm64/kernel/head.S b/arch/arm64/kernel/head.S > index 6a98f1a38c29..1cdecce552bb 100644 > --- a/arch/arm64/kernel/head.S > +++ b/arch/arm64/kernel/head.S > @@ -469,13 +469,6 @@ SYM_FUNC_START_LOCAL(__primary_switched) > ASM_BUG() > SYM_FUNC_END(__primary_switched) > > - .pushsection ".rodata", "a" > -SYM_DATA_START(kimage_vaddr) > - .quad _text > -SYM_DATA_END(kimage_vaddr) > -EXPORT_SYMBOL(kimage_vaddr) > - .popsection > - > /* > * end early head section, begin head code that is also used for > * hotplug and needs to have the same protections as the text region > diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c > index c5563ff990da..7148928e3932 100644 > --- a/arch/arm64/mm/mmu.c > +++ b/arch/arm64/mm/mmu.c > @@ -49,6 +49,9 @@ u64 idmap_ptrs_per_pgd = PTRS_PER_PGD; > u64 __section(".mmuoff.data.write") vabits_actual; > EXPORT_SYMBOL(vabits_actual); > > +u64 kimage_vaddr __ro_after_init = (u64)&_text; > +EXPORT_SYMBOL(kimage_vaddr); > + > u64 kimage_voffset __ro_after_init; > EXPORT_SYMBOL(kimage_voffset); > > -- > 2.35.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel