From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1869FC43334 for ; Mon, 27 Jun 2022 13:55:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=spH3Wx+uSdACRZXcd59jTcTbbfP36p9eVzwbm2JEYmo=; b=cYXtt8MG1izx+U 1BbyZVTQRB2vAvH7XSDysXIsOPFJ9gxNaT5W3w64YTZ+vce1RmVcNRvn5tnnm6t50YsAX0/PkWNtR jBx4PndnCWcZe4YrQs7T2048sx5brnkx8XiV3oSBQ1p0X7sffAWMr8V99xTNjoV4JEw3t/xMVTxhN UMU01hx8ekJzYpHbo976DasO7l/VfPki7gvJ1rzS8uMuoG0K6mOp1jN91r0Jwf8SnxbxwiotEkoKg /rFo9yQF5Floep9ljweawRPpmYWwJ8KaAe2X8W61bwlF48cjQRNJCJykJ3l2aSEQRFgEe4VgDDOJy CbCu+fAQmsT4E3vVZZGw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o5pCL-001GB5-MA; Mon, 27 Jun 2022 13:54:41 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o5pCB-001G6j-VQ; Mon, 27 Jun 2022 13:54:33 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9ABBF1758; Mon, 27 Jun 2022 06:54:30 -0700 (PDT) Received: from localhost (ionvoi01-desktop.cambridge.arm.com [10.1.196.65]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0BA403F5A1; Mon, 27 Jun 2022 06:54:29 -0700 (PDT) Date: Mon, 27 Jun 2022 14:54:28 +0100 From: Ionela Voinescu To: Sudeep Holla Cc: linux-kernel@vger.kernel.org, Greg KH , Atish Patra , Atish Patra , Vincent Guittot , Dietmar Eggemann , Qing Wang , Rob Herring , "Rafael J . Wysocki" , Pierre Gondois , linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v4 00/20] arch_topology: Updates to add socket support and fix cluster ids Message-ID: References: <20220621192034.3332546-1-sudeep.holla@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220621192034.3332546-1-sudeep.holla@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220627_065432_141769_63FC347F X-CRM114-Status: GOOD ( 27.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Sudeep, On Tuesday 21 Jun 2022 at 20:20:14 (+0100), Sudeep Holla wrote: > Hi All, > > This version updates cacheinfo to populate and use the information from > there for all the cache topology. > > This series intends to fix some discrepancies we have in the CPU topology > parsing from the device tree /cpu-map node. Also this diverges from the > behaviour on a ACPI enabled platform. The expectation is that both DT > and ACPI enabled systems must present consistent view of the CPU topology. > > Currently we assign generated cluster count as the physical package identifier > for each CPU which is wrong. The device tree bindings for CPU topology supports > sockets to infer the socket or physical package identifier for a given CPU. > Also we don't check if all the cores/threads belong to the same cluster before > updating their sibling masks which is fine as we don't set the cluster id yet. > > These changes also assigns the cluster identifier as parsed from the device tree > cluster nodes within /cpu-map without support for nesting of the clusters. > Finally, it also add support for socket nodes in /cpu-map. With this the > parsing of exact same information from ACPI PPTT and /cpu-map DT node > aligns well. > > The only exception is that the last level cache id information can be > inferred from the same ACPI PPTT while we need to parse CPU cache nodes > in the device tree. > > Hi Greg, > > I had not cc-ed you on earlier 3 versions as we had some disagreement > amongst Arm developers which we have not settled. Let me know how you want to s/not/now :) > merge this once you agree with the changes. I can set pull request if > you prefer. Let me know. > > v4[3]->v4: > - Updated ACPI PPTT fw_token to use table offset instead of virtual > address as it could get changed for everytime it is mapped before > the global acpi_permanent_mmap is set > - Added warning for the topology with nested clusters > - Added update to cpu_clustergroup_mask so that introduction of > correct cluster_id doesn't break existing platforms by limiting > the span of clustergroup_mask(by Ionela) > I've tested v4 on quite a few platforms: - DT: Juno R0, DB845c, RB5 - ACPI: TX2, Ampere Altra, Kunpeng920 and it all looks good from my point of view (topology and sched domain hierarchy). So for the full set (after the changes requested for 16/20 and 20/20): Tested-by: Ionela Voinescu Hope it helps, Ionela. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel