From: Cristian Marussi <cristian.marussi@arm.com>
To: Bo Liu <liubo03@inspur.com>
Cc: sudeep.holla@arm.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] firmware: arm_scmi: Remove usage of the deprecated ida_simple_xxx API
Date: Mon, 27 Jun 2022 12:54:23 +0100 [thread overview]
Message-ID: <YrmabyDSlB9OMlLm@e120937-lin> (raw)
In-Reply-To: <20220616055052.4559-1-liubo03@inspur.com>
On Thu, Jun 16, 2022 at 01:50:52AM -0400, Bo Liu wrote:
> Use ida_alloc_xxx()/ida_free() instead of
> ida_simple_get()/ida_simple_remove().
> The latter is deprecated and more verbose.
>
> Signed-off-by: Bo Liu <liubo03@inspur.com>
> ---
Hi Bo,
I've missed this patch of yours and I recently posted something similar
using a bare ida_alloc() (so starting with id 0 instead).
Anyway AFAIU, Sudeep will pick up your patch with a small change to use
ida_alloc.
Thanks for this,
Cristian
> drivers/firmware/arm_scmi/bus.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/firmware/arm_scmi/bus.c b/drivers/firmware/arm_scmi/bus.c
> index f6fe723ab869..d4e23101448a 100644
> --- a/drivers/firmware/arm_scmi/bus.c
> +++ b/drivers/firmware/arm_scmi/bus.c
> @@ -181,7 +181,7 @@ scmi_device_create(struct device_node *np, struct device *parent, int protocol,
> return NULL;
> }
>
> - id = ida_simple_get(&scmi_bus_id, 1, 0, GFP_KERNEL);
> + id = ida_alloc_min(&scmi_bus_id, 1, GFP_KERNEL);
> if (id < 0) {
> kfree_const(scmi_dev->name);
> kfree(scmi_dev);
> @@ -204,7 +204,7 @@ scmi_device_create(struct device_node *np, struct device *parent, int protocol,
> put_dev:
> kfree_const(scmi_dev->name);
> put_device(&scmi_dev->dev);
> - ida_simple_remove(&scmi_bus_id, id);
> + ida_free(&scmi_bus_id, id);
> return NULL;
> }
>
> @@ -212,7 +212,7 @@ void scmi_device_destroy(struct scmi_device *scmi_dev)
> {
> kfree_const(scmi_dev->name);
> scmi_handle_put(scmi_dev->handle);
> - ida_simple_remove(&scmi_bus_id, scmi_dev->id);
> + ida_free(&scmi_bus_id, scmi_dev->id);
> device_unregister(&scmi_dev->dev);
> }
>
> --
> 2.27.0
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-06-27 11:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-16 5:50 [PATCH] firmware: arm_scmi: Remove usage of the deprecated ida_simple_xxx API Bo Liu
2022-06-27 11:54 ` Cristian Marussi [this message]
2022-06-29 10:05 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YrmabyDSlB9OMlLm@e120937-lin \
--to=cristian.marussi@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liubo03@inspur.com \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox