From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D2987C433EF for ; Tue, 28 Jun 2022 04:06:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SLxS9eygoXrEAYmyTC0lPo0XKNU6TUfxMheDkapptgs=; b=v/A6agCVeeCf7j dIP2FHn1WvHBKZW9Jgdnj6gcUzEjrPFV0HXuKcji9LOwIcYqqDocGF2EdOa1PoFLlzruNbF4bkLBj S2e3hciVGiTWau1feAzZlZxKEy8NWAIzSuqKiIctiXxZFsyWffWSYo/XYyjBCLIgf8Uwf79yF6+8n elEsplqjD6Ez8WUp7fY9AwD20BhEkqnvJ0tEKlHJsuwuILmKBbtPretlyLof7NR6Iiy19yTNafAac 8vJyJt8XrhLHLGeY+L0mWbYTmeb5trWARQzF7TuV1kMxlG1xwMeDgrABCnGabMXE12cNWRdgJagbf XULRrBcoIU37S8GL2TSQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o62Ta-0047VG-GP; Tue, 28 Jun 2022 04:05:22 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o62TX-0047Un-Do for linux-arm-kernel@lists.infradead.org; Tue, 28 Jun 2022 04:05:20 +0000 Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id CA64B8106; Tue, 28 Jun 2022 04:00:06 +0000 (UTC) Date: Tue, 28 Jun 2022 07:05:17 +0300 From: Tony Lindgren To: Liang He Cc: linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, Krzysztof Kozlowski Subject: Re: [PATCH v2] arm/mach-omap2: Fix refcount leak bugs Message-ID: References: <20220620155421.4076532-1-windhl@126.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220620155421.4076532-1-windhl@126.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220627_210519_538738_36ADB682 X-CRM114-Status: UNSURE ( 9.48 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Liang He [220620 15:49]: > --- a/arch/arm/mach-omap2/omap4-common.c > +++ b/arch/arm/mach-omap2/omap4-common.c > @@ -135,6 +135,7 @@ static int __init omap4_sram_init(void) > pr_warn("%s:Unable to allocate sram needed to handle errata I688\n", > __func__); > sram_pool = of_gen_pool_get(np, "sram", 0); > + of_node_put(np); > if (!sram_pool) > pr_warn("%s:Unable to get sram pool needed to handle errata I688\n", > __func__); Here sram_pool is used after of_node_put() on it. Don't we want to do the put only after no users? Regards, Tony _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel