From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Chanho Park <chanho61.park@samsung.com>
Cc: "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Alim Akhtar" <alim.akhtar@samsung.com>,
"Hector Martin" <marcan@marcan.st>,
"Jaewon Kim" <jaewon02.kim@samsung.com>,
"Vincent Whitchurch" <vincent.whitchurch@axis.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
linux-samsung-soc@vger.kernel.org, linux-serial@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] tty: serial: samsung_tty: loopback mode support
Date: Tue, 28 Jun 2022 15:51:37 +0200 [thread overview]
Message-ID: <YrsHaUqM03I6I9Om@kroah.com> (raw)
In-Reply-To: <20220628124050.144398-1-chanho61.park@samsung.com>
On Tue, Jun 28, 2022 at 09:40:50PM +0900, Chanho Park wrote:
> Internal loopback mode can be supported by setting
> UCON register's Loopback Mode bit. The mode & bit can be supported since
> s3c2410 and later SoCs. The prefix of LOOPBACK / BIT(5) naming should be
> also changed to S3C2410_ to avoid confusion.
>
> We can test it by linux-serial-test program
> with -k option. The tool will set TIOCM_LOOP mode when the option is
> specified.
> -k, --loopback Use internal hardware loop back
Again, what does this line mean in a changelog text?
And properly wrap your lines at 72 columns.
thanks,
greg k-h
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-06-28 13:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220628124300epcas2p45f1e3a7051bb93ecba778cf7d96720d3@epcas2p4.samsung.com>
2022-06-28 12:40 ` [PATCH v2] tty: serial: samsung_tty: loopback mode support Chanho Park
2022-06-28 12:58 ` Ilpo Järvinen
2022-06-29 0:29 ` Chanho Park
2022-06-28 13:51 ` Greg Kroah-Hartman [this message]
2022-06-29 0:32 ` Chanho Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YrsHaUqM03I6I9Om@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alim.akhtar@samsung.com \
--cc=chanho61.park@samsung.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jaewon02.kim@samsung.com \
--cc=jirislaby@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=vincent.whitchurch@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).