From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 521E4C43334 for ; Wed, 29 Jun 2022 12:37:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=06wRDBWOBbuBP/AKCe3CyQpJe5PurKzX96FBYINf/Fs=; b=U97kpVWTTBAu5P qSCtsvGJgk2WCYhYzAwq92S33PxuXLcxy4gpCXFJsVSGroK3kNjOtWeyD1Vx44m/vwcCMaer4+bBK ERj+QWrcFRO4Jg3WqQdMhQ0LVow9zg+VxJMVpI4oUaw390R/2yhJwTk1J4XzfIEjzzpSnWAyrHq9F 5MeCvPTPAZiMbb5kl5qWOorcggihWiH71VcdmyGD1OcH66O0k43gfviiodwtJxvrAdGz1h91y62Kd tvtq8LgpTQ9kCqx+ma5cOkoss7NGI46hbiv/zTZYuUoSOIVOZ36kYW0n/u/d8gIbWB49IrVj0jHjJ zE19o1UGj2eD64dZi4Hw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o6Wvr-00Bs6R-4q; Wed, 29 Jun 2022 12:36:35 +0000 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o6Wvi-00Bs0K-N3 for linux-arm-kernel@lists.infradead.org; Wed, 29 Jun 2022 12:36:29 +0000 Received: by mail-wm1-x32a.google.com with SMTP id l2-20020a05600c4f0200b0039c55c50482so11380639wmq.0 for ; Wed, 29 Jun 2022 05:36:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=DT+Hg4MXkKGN3iF9yrZOwKd7X9E+dCZfidIy8wnPVhs=; b=F8o1gvCHUO0AaSUw95FBfODVx1rKjGucblSlLnK9kzaYfE4z45hG7/Q/0KjOurXk7k Z70esZYM27OhUOpxpekDkWnIItmpXDhFpQWwzMoeE0IBXwAC9ybEhCSq8q93QYitDjWK zgR4KYeevxyii1mwwruDTmr820y2WMFmVm43a6vTqkK1gI+CHQR0yidq+jmyqYIuY7nz 8cRigmOgNQB5dVOh5+9QQPMh60cfzuHbfmuguEKDD5O8fBQ7MrH/cWNHZsYfGhbh3owv bEtgGvWqCJDRDrN2FskGip5MmzN9dyyDEw8ezYCegOSw94JvExbdz76QyIJ+Dbr2kKkA jneA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=DT+Hg4MXkKGN3iF9yrZOwKd7X9E+dCZfidIy8wnPVhs=; b=Pb42jds/1AVQsxNcvdlreeZ5UQNyXNb+ubHQRNZ7jnfSVgX5wObhJe5Gf0BF3Udw6f WdQYmrxcGEjn0G+Hc5lp6VBuEJaVUBVmSMu2camL8rZn6GFw4BGyXhdPRpT3P2EbcpNB FmpZvtDppP3Rd6avuQPpuCYj6QEeY17MnzVKqTDM1dk2Mtt84y3fGqAgu89YBX5bFIVt dMBcD4ZMlX7KZYHldxtWUC51ZobDssHkneb5AjtjwZuGX/W7vsEG/h/6Mn10YJ2dJLnM GMdTdkdEBzgxQfoUFXATLawXSgclRxQp3HwGg/ec8dh48Ny6/x67kTuXwUoRiw8qGOkv NJGw== X-Gm-Message-State: AJIora8IZWQREoTFHdTWB24x3896SOKDFmnLAVcU3Bm46Yykqwio8aKc GWKVKg5EAvljYeRjWgKsBkk= X-Google-Smtp-Source: AGRyM1tT3S6YJDUvU9N/m4Ujal72KTiL/+4qd507Qh2/vNqbs55SHP32TF7gvAP8aAEBEsqXzAaQ6g== X-Received: by 2002:a7b:c003:0:b0:39c:5642:e415 with SMTP id c3-20020a7bc003000000b0039c5642e415mr5312894wmb.111.1656506183225; Wed, 29 Jun 2022 05:36:23 -0700 (PDT) Received: from Red ([2a01:cb1d:3d5:a100:264b:feff:fe03:2806]) by smtp.googlemail.com with ESMTPSA id e9-20020a5d4e89000000b0021a3a87fda9sm16658872wru.47.2022.06.29.05.36.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jun 2022 05:36:22 -0700 (PDT) Date: Wed, 29 Jun 2022 14:36:20 +0200 From: Corentin Labbe To: Neal Liu Cc: Christophe JAILLET , Randy Dunlap , Herbert Xu , "David S . Miller" , Rob Herring , Krzysztof Kozlowski , Joel Stanley , Andrew Jeffery , Dhananjay Phadke , Johnny Huang , linux-aspeed@lists.ozlabs.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, BMC-SW@aspeedtech.com Subject: Re: [PATCH v6 1/5] crypto: aspeed: Add HACE hash driver Message-ID: References: <20220629094426.1930589-1-neal_liu@aspeedtech.com> <20220629094426.1930589-2-neal_liu@aspeedtech.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220629094426.1930589-2-neal_liu@aspeedtech.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220629_053626_825121_C460221F X-CRM114-Status: GOOD ( 19.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Le Wed, Jun 29, 2022 at 05:44:22PM +0800, Neal Liu a =E9crit : > Hash and Crypto Engine (HACE) is designed to accelerate the > throughput of hash data digest, encryption, and decryption. > = > Basically, HACE can be divided into two independently engines > - Hash Engine and Crypto Engine. This patch aims to add HACE > hash engine driver for hash accelerator. > = > Signed-off-by: Neal Liu > Signed-off-by: Johnny Huang > --- Hello I have some minor comments below. > +++ b/drivers/crypto/aspeed/aspeed-hace-hash.c > @@ -0,0 +1,1428 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +/* > + * Copyright (c) 2021 Aspeed Technology Inc. > + */ > + > +#include "aspeed-hace.h" > + > +#ifdef ASPEED_AHASH_DEBUG > +#define AHASH_DBG(h, fmt, ...) \ > + dev_dbg((h)->dev, "%s() " fmt, __func__, ##__VA_ARGS__) > +#else > +#define AHASH_DBG(h, fmt, ...) \ > + ((void)(h)) > +#endif Hello why not direclty use dev_dbg ? You will still need something to do to enable dev_dbg, so why force to add = the need to re-compile it with ASPEED_AHASH_DEBUG ? [...] > + if (dma_mapping_error(hace_dev->dev, rctx->digest_dma_addr)) { > + dev_warn(hace_dev->dev, "dma_map() rctx digest error\n"); > + return -ENOMEM; > + } An error displayed as warning. [...] > + if (!sg_len) { > + dev_warn(hace_dev->dev, "dma_map_sg() src error\n"); Same here. In fact you have lot of error displayed as warning in the driver. [...] > +/* Weak function for HACE hash */ > +void __weak aspeed_register_hace_hash_algs(struct aspeed_hace_dev *hace_= dev) > +{ > + pr_warn("%s: Not supported yet\n", __func__); > +} > + > +void __weak aspeed_unregister_hace_hash_algs(struct aspeed_hace_dev *hac= e_dev) > +{ > + pr_warn("%s: Not supported yet\n", __func__); > +} Why not use dev_warn ? [...] > +struct aspeed_sg_list { > + u32 len; > + u32 phy_addr; > +}; Since it is a descriptor where all member are written with cpu_to_le32(), i= t should be __le32. Regards _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel