From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9B726C43334 for ; Wed, 29 Jun 2022 15:33:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fLwlGI5hdp5bo3KkTBlphFGfFHwwpxFyH+1afgKbPIE=; b=LO/AokPZFoxzYz jVpwKX2ournkcpiTGSW8J0vcFGN6hU9NJA+R1jLqCJrqEkubXaqMM9TF5lTNAqjFuwnaanQFDM8uT SM7ERDcxmfqaX+tRpWA7/3sVvKhH/c76OcXDpa3kjuLnb3h17pkLz+lAOdAB4ZHprkbqcX4MCBlNY skkKBd09vHIZQDKNoLhFulPpD+OPXgAj74vxsEqC2fSNvVHf0Nal3m25+umsnoBZBkuXZOnxqli3A 32PfSSuZpe7LQ/fgVybLYKNffXxjmS8Bk67u29qumO9q7GgktYNFmJRTAOOvCrQFi7j9yEdZRkGxv 7OvGgUObf20XQVihOdnw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o6Zfr-00CiF8-6s; Wed, 29 Jun 2022 15:32:15 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o6Zfn-00CiDs-SB for linux-arm-kernel@lists.infradead.org; Wed, 29 Jun 2022 15:32:13 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D061AB824DD; Wed, 29 Jun 2022 15:32:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3FBC7C34114; Wed, 29 Jun 2022 15:32:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1656516726; bh=C7giPN+qsPnR9juAKxwWkHDcLBswzBs0OgjSrpVwzJM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=m4SjOqpF8ZT7iAgy0s1lC3NNsCXzJ8S9sUOuNZA92qEM8N9RMAmSBsGPTYBu+EfUB BSYHByKEldQ6oPwFq9X2oJCeS7TMof7aLFWv+B3rk7NNQwwCsVTNdcFTbpbcj2FnxG 1nPOMWngZjlptmzFRjVNQ9ENdZG5/nRHVZ/TCaWo= Date: Wed, 29 Jun 2022 17:31:57 +0200 From: Greg Kroah-Hartman To: Sebin Sebastian Cc: Neal Liu , Felipe Balbi , Joel Stanley , Andrew Jeffery , linux-aspeed@lists.ozlabs.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] usb: gadget: dereference before null check Message-ID: References: <20220629080726.107297-1-mailmesebin00@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220629_083212_238631_1ABADB33 X-CRM114-Status: GOOD ( 39.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jun 29, 2022 at 05:44:55PM +0530, Sebin Sebastian wrote: > On Wed, Jun 29, 2022 at 10:24:07AM +0200, Greg Kroah-Hartman wrote: > > On Wed, Jun 29, 2022 at 01:37:25PM +0530, SebinSebastian wrote: > > > Fix coverity warning dereferencing before null check. _ep and desc is > > > dereferenced on all paths until the check for null. Move the > > > initializations after the check for null. > > > Coverity issue: 1518209 > > > > > > Signed-off-by: SebinSebastian > > > --- > > > drivers/usb/gadget/udc/aspeed_udc.c | 9 +++++---- > > > 1 file changed, 5 insertions(+), 4 deletions(-) > > > > > > diff --git a/drivers/usb/gadget/udc/aspeed_udc.c b/drivers/usb/gadget/udc/aspeed_udc.c > > > index d75a4e070bf7..96f8193fca15 100644 > > > --- a/drivers/usb/gadget/udc/aspeed_udc.c > > > +++ b/drivers/usb/gadget/udc/aspeed_udc.c > > > @@ -341,10 +341,6 @@ static void ast_udc_stop_activity(struct ast_udc_dev *udc) > > > static int ast_udc_ep_enable(struct usb_ep *_ep, > > > const struct usb_endpoint_descriptor *desc) > > > { > > > - u16 maxpacket = usb_endpoint_maxp(desc); > > > - struct ast_udc_ep *ep = to_ast_ep(_ep); > > > - struct ast_udc_dev *udc = ep->udc; > > > - u8 epnum = usb_endpoint_num(desc); > > > unsigned long flags; > > > u32 ep_conf = 0; > > > u8 dir_in; > > > @@ -356,6 +352,11 @@ static int ast_udc_ep_enable(struct usb_ep *_ep, > > > return -EINVAL; > > > } > > > > > > + u16 maxpacket = usb_endpoint_maxp(desc); > > > + struct ast_udc_ep *ep = to_ast_ep(_ep); > > > + struct ast_udc_dev *udc = ep->udc; > > > + u8 epnum = usb_endpoint_num(desc); > > > + > > > if (!udc->driver) { > > > EP_DBG(ep, "bogus device state\n"); > > > return -ESHUTDOWN; > > > -- > > > 2.34.1 > > > > > > > Hi, > > > > This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him > > a patch that has triggered this response. He used to manually respond > > to these common problems, but in order to save his sanity (he kept > > writing the same thing over and over, yet to different people), I was > > created. Hopefully you will not take offence and will fix the problem > > in your patch and resubmit it so that it can be accepted into the Linux > > kernel tree. > > > > You are receiving this message because of the following common error(s) > > as indicated below: > > > > - Your patch breaks the build. > > > > - Your patch contains warnings and/or errors noticed by the > > scripts/checkpatch.pl tool. > > > > - This looks like a new version of a previously submitted patch, but you > > did not list below the --- line any changes from the previous version. > > Please read the section entitled "The canonical patch format" in the > > kernel file, Documentation/SubmittingPatches for what needs to be done > > here to properly describe this. > > > > If you wish to discuss this problem further, or you have questions about > > how to resolve this issue, please feel free to respond to this email and > > Greg will reply once he has dug out from the pending patches received > > from other developers. > > > > thanks, > > > > greg k-h's patch email bot > > I am sorry to keep on bothering with this incorrect patches. I am > running the checkpatch script everytime before I sent any patches. It is > not showing any warnings or errors. Is it because of my name that my > patches are getting rejected? I can see a space missing. Did you test build your patch? If not, why not? thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel