From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5AFB1C43334 for ; Tue, 12 Jul 2022 07:29:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SOovd2uF4Upe1T6FOoAiZ4LZ3hAjhaIQv4eAcAYicsM=; b=oOOyQPR/KyN6Ja ehX5z/8LePvw5yPPObKCnCcA0LnhbnUNIpHQieQ4nawKRakl9mZ4KFiCM+yAPcumFdsifAZg3Jk0p Kcdvv9YGeZIX6YY9cFT0EP7BonWYzUYzs8XB2wllN7RF35dlfQLx3pqqgQJvLF78SfCD5XSWD8Wkl 44YC8KQvARdUKnimaS5zYW/1eGsTb9uf3mMRwSFpF40EYWypltVtN8+rSk6UsB4I37NQSbrLESDYC JJ7qpbT6HHpK8P17YVaxJ25HkaE75Kk5Q/ST2dYWWcldug76n6XWrof2nHwM/zuJLMA81a1lImKnY xiT4go5HdTQb8SGFFsjQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oBAK5-008Kgd-P7; Tue, 12 Jul 2022 07:28:45 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oBAK2-008Kez-SX for linux-arm-kernel@lists.infradead.org; Tue, 12 Jul 2022 07:28:44 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0CD1D614A3; Tue, 12 Jul 2022 07:28:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3D98BC3411E; Tue, 12 Jul 2022 07:28:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657610921; bh=LpTX8BtQ4nk3s/QpUBEBjyqybWzs+v3XLR2Bdeqf0p0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=reRLqpm9GgvTgHoyQYC923IczXG+CVC2LXpg+hFgwV3YXmwXQnTKchxyOl1ZYJTVC 1aN0UiG2ViFdcJAfxxrDGk+rSSUCGel0aYO4MGPXgRwDIncvEFBREXfTqdO8m3RWrL 4gVXn7AgLMwnnBO1J9/sGEeWm76ppEUs0zUbC4018qvVE7OY1ps58c2kYIGDiAyXFF PqtTZF8K0ohy8sRjrRKpQ1vF3fedTEg98ozCtqymW8QucUCZ/1FExg2FUdy6dxe5zm t3aXHCRBQFVcn+qVyUZQaO5BzK86WooLk0Z4YQY3yMM6/IrPBtI0L33l2t+vnbstPB MfwFST995TFhA== Date: Tue, 12 Jul 2022 00:28:39 -0700 From: Eric Biggers To: GUO Zihua Cc: linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, herbert@gondor.apana.org.au, davem@davemloft.net, catalin.marinas@arm.com, will@kernel.org Subject: Re: [PATCH] arm64/crypto: poly1305 fix a read out-of-bound Message-ID: References: <20220712033215.45960-1-guozihua@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220712_002842_974077_5EB40258 X-CRM114-Status: GOOD ( 12.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jul 12, 2022 at 12:08:36AM -0700, Eric Biggers wrote: > > Is the special reproducer really needed? I'd expect this to be reproduced by > the existing crypto self-tests just by booting a kernel built with both > CONFIG_KASAN=y and CONFIG_CRYPTO_MANAGER_EXTRA_TESTS=y. > Ah, probably the self-tests don't find this because with poly1305 the key is actually read from the "data", and for the self-tests the data addresses happens to always be in the kernel direct map, so KASAN doesn't work for it (I think). Ideally the self-tests would test with kmalloc'ed data buffers too, or a buffer in vmalloc'ed memory that's directly followed by a guard page. - Eric _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel