From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7202BC43334 for ; Sat, 2 Jul 2022 11:57:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8PteRQlr3PpAnhxkmiKdKdQ+S5xh9mqchGTU1dn050Y=; b=JwNjoEwfkfbnVC DqtQxSuqoKij2DkAO6QfmMguJuOcbPDwTwnodFiaNy23ncXW4TvuPLL1/c+tkTIGq3dDY8g9wu0Pn 3I8KdwdjKZnBPbO2CupFAoIhFY9n6brArwlJAMwU33fuo44nvDHcWRYCCUGKtf/kctGs8W5vc5mlN qF3vpVtMTCKhUc83wjIpF7UBLBiWloUOq8HC7bynW8fghR+qd/Wm2Ek3LgHL+eiG/ylR3Wr/wgPf1 5/QuxICEe64EbWgN0Lr3z5vHLJlFygwM5EGEf6MyLLTi5HgeZPH+Ty1LZ9gj8D/jd52BOTW3EIIor 5gTlFmUR1IcBGiPRhJ2A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o7bjQ-009N5I-6E; Sat, 02 Jul 2022 11:56:12 +0000 Received: from mga06b.intel.com ([134.134.136.31] helo=mga06.intel.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o7bjN-009N3H-9I for linux-arm-kernel@lists.infradead.org; Sat, 02 Jul 2022 11:56:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1656762969; x=1688298969; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=IHRxPXI2AjXfX75L8NFTEgjJ1hQ1grsVio3ExHvN1eY=; b=NTWo8L7El70wBtsyFk5MD9Aj7mZ6DsniuT/EKrpr5rJ8z6JpPda9csZs nMyqt7MoQg/1szww+tdfBawH1wOnwN2Y1oLFdNIsTOCbl+kLQ/39qa+fO saNeOFRsiL/W0ayBPPi2FvpQsZDPJffoMAdVG56aRvlG2fIzTkw8h7OcR NS4WHfnAvEkooSdfRBD/1mbK75a75sJkFZAE5KJHVu8+8hTF1qy+XqPVH ZOmThEaIYx4Ne6cCpHMP8KPXMp8zaz7gZjhj1hIXogMmY/xSE66sBdUS9 jjQTgYwbr6QTUs1BMmkWvyFL5LiPJ7/k0wSj007sIo6amRMBCR+axsHer A==; X-IronPort-AV: E=McAfee;i="6400,9594,10395"; a="344507307" X-IronPort-AV: E=Sophos;i="5.92,239,1650956400"; d="scan'208";a="344507307" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jul 2022 04:56:04 -0700 X-IronPort-AV: E=Sophos;i="5.92,239,1650956400"; d="scan'208";a="768758377" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jul 2022 04:56:00 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1o7bjA-0013aa-2j; Sat, 02 Jul 2022 14:55:56 +0300 Date: Sat, 2 Jul 2022 14:55:56 +0300 From: Andy Shevchenko To: Yury Norov Cc: linux-kernel@vger.kernel.org, Andrew Morton , David Howells , Geert Uytterhoeven , Jonathan Corbet , "Kirill A . Shutemov" , Matthew Wilcox , NeilBrown , Rasmus Villemoes , Russell King , Vlastimil Babka , William Kucharski , linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org Subject: Re: [PATCH 1/8] arm: align find_bit declarations with generic kernel Message-ID: References: <20220701125430.2907638-1-yury.norov@gmail.com> <20220701125430.2907638-2-yury.norov@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220701125430.2907638-2-yury.norov@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220702_045609_427290_92255313 X-CRM114-Status: GOOD ( 10.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 01, 2022 at 05:54:23AM -0700, Yury Norov wrote: > ARM has their own implementation for find_bit functions, and function > declarations are different with those in generic headers. Fix it. ... > -extern int _find_first_zero_bit_le(const unsigned long *p, unsigned size); > -extern int _find_next_zero_bit_le(const unsigned long *p, int size, int offset); > -extern int _find_first_bit_le(const unsigned long *p, unsigned size); > -extern int _find_next_bit_le(const unsigned long *p, int size, int offset); > +unsigned long _find_first_zero_bit_le(const unsigned long *p, unsigned long size); > +unsigned long _find_next_zero_bit_le(const unsigned long *p, > + unsigned long size, unsigned long offset); > +unsigned long _find_first_bit_le(const unsigned long *p, unsigned long size); > +unsigned long _find_next_bit_le(const unsigned long *p, > + unsigned long size, unsigned long offset); Indentation seems broken. Also for all: is double space required? ... > +unsigned long _find_next_bit_be(const unsigned long *p, > + unsigned long size, unsigned long offset); Indentation of the second line is broken (u in 'unsigned' should be in the same column as 'const'). -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel