From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4020DC433EF for ; Sat, 2 Jul 2022 11:59:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FMdSaGVMYlv+T0i8X675I1VCvkMqufl9m3Z63L151c8=; b=wahFJpOsMBCC2A MmfdavPh4X4LnBrKTFU1hT+PeCgRA5v441CLLYBrfU0gRiTnGrvfS3eEX4xOdu9StLmRBYbvLT9i4 nS5dtFmjGo+78vVePPf0KSNfs8+RSfriRwlPdlA/T9Ishr4uyzqCDUjBV3cMvDxOr7Br84Pa1RSz2 xSd3LGKsMdbAFJ0koX/vD1EyqgCOjmKPnZwI7J/5zHqwktsjsWz+U0dlYho1MBhdbSn5lYg8DV7HS fFQgFofI0/jXsZTqXvfFF9+XkQsw3OaeC9pONJPQQwWvB/gvjPccQ0+f9i7yssUX2/Xecm735sYyk XA6HR9EN8+NVqcSQFJwQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o7blD-009NdL-QJ; Sat, 02 Jul 2022 11:58:03 +0000 Received: from mga04.intel.com ([192.55.52.120]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o7blB-009NbD-2A for linux-arm-kernel@lists.infradead.org; Sat, 02 Jul 2022 11:58:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1656763081; x=1688299081; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=re3LFd38nLBlu3MQiWD1Ny6wrWGEckMsB9soYe/z/cY=; b=VB9Z10I3m1IZsvtqDzkdAWfSxQrNcqdRrOTrMp64rOXs7MpIBUPBBHUo 3Y4tRl1DpFKSCzSPbZYa5RbrglvjSgzVQ+XIdEV1lkEGZL4jDzxTZeLcB 7+KoJb7oO4FTakFCyqhJU50h5HPWzCpoqJHzIBK7QE9KuWj+CAcIruvb1 Dgehnj6CTJIdvT+Fw6OAxmyR7DSrRXj/SC5mNwvrC6pwhn+nzZfWdqZbr RV7fVF9Jn/cB/e2Pkrl4eh9HofBW6xHKIbug/+VPC2EDDRZ3zWDN5rtAy YLwoQG41qXD4Qblk/Pm9Dye0FPEovWam2THPThXLIPTqx2GgeHDriyP8N g==; X-IronPort-AV: E=McAfee;i="6400,9594,10395"; a="281584201" X-IronPort-AV: E=Sophos;i="5.92,239,1650956400"; d="scan'208";a="281584201" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jul 2022 04:57:59 -0700 X-IronPort-AV: E=Sophos;i="5.92,239,1650956400"; d="scan'208";a="541992929" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jul 2022 04:57:55 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1o7bl1-0013ah-1H; Sat, 02 Jul 2022 14:57:51 +0300 Date: Sat, 2 Jul 2022 14:57:51 +0300 From: Andy Shevchenko To: Yury Norov Cc: linux-kernel@vger.kernel.org, Andrew Morton , David Howells , Geert Uytterhoeven , Jonathan Corbet , "Kirill A . Shutemov" , Matthew Wilcox , NeilBrown , Rasmus Villemoes , Russell King , Vlastimil Babka , William Kucharski , linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org Subject: Re: [PATCH 3/8] lib/bitmap: change type of bitmap_weight to unsigned int Message-ID: References: <20220701125430.2907638-1-yury.norov@gmail.com> <20220701125430.2907638-4-yury.norov@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220701125430.2907638-4-yury.norov@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220702_045801_145065_C71CE855 X-CRM114-Status: UNSURE ( 9.40 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 01, 2022 at 05:54:25AM -0700, Yury Norov wrote: > bitmap_weight() doesn't return negative values, so change it's type > to unsigned int. Patch (the code) suggests something else. > It may help compiler to generate better code and > catch bugs. ... > -int __bitmap_weight(const unsigned long *bitmap, unsigned int nbits); > +unsigned long __bitmap_weight(const unsigned long *bitmap, unsigned int nbits); -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel