From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6A72EC433EF for ; Sat, 2 Jul 2022 22:00:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CgAG9CTq2mo8otxvzVgrqn1wppzgLGXfjIah2ZypGcU=; b=b85Mp80IrSKwPD 2gZ5CrzIUXpOHZa/ig5jdmwn7mJ2I2kyi0ZnEvM7XdCv/RK4klxY1bltD37w/wingTJDpADiifpCY ZfdaT/q1nr56MzrftQG31ocE2t1PJPI4/iEm0eykdVFRapbQQ2/Jwg3KJMcpTb2r6YatNlcJMDT2/ 2XbbCbwLrCwKQVowbhP8yRBmEJxBr6B93W56lBR/t+K4aU6HruSojaLl581g3KkJQbV0+hOVzj21R PS2bs4Fk8ZPmSuWWCCLtHkP5UrBNld41QkNN73sxdNhjsRMhubJfaVPq56cUx9zxaD/R8HxXfewdE Iuw31vPi2HyIWKQmU6Ng==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o7l9R-00Bp8H-Nu; Sat, 02 Jul 2022 21:59:41 +0000 Received: from mail-qt1-x831.google.com ([2607:f8b0:4864:20::831]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o7l9P-00Bp6J-2g for linux-arm-kernel@lists.infradead.org; Sat, 02 Jul 2022 21:59:40 +0000 Received: by mail-qt1-x831.google.com with SMTP id q16so4716285qtn.5 for ; Sat, 02 Jul 2022 14:59:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=CRmpJqPfR2Ffc8HgrJVdi9vtvYXJmh3FYn3557q1NwE=; b=IM5wTLBzQjNlhxRrQd9duTSaviX9W642sXlAB85N1J/s7j5rmEna+8IABQod6CKWwf idRQLlJu1V3fyKxBBgZT8orNNwSfG3ldK93UWDDfwO+2whPF1ZAxLA40DoQvxU5BfMNp 3lBbbYWyQlIivNwXQikzuuHqR4sZAigx4GkkKHfZlqHeuEoeLfDb/PifXKGZipSv/aeN Cynt/+Yyu7uFh0AOVPy3Vsn+npnyt9GaCOHUIl2GPSlPaA5FV2+u3jZ48DmkHJn3sw2W Qhb1WicuxCijgoIjMRw1yzx8xh+1vtZ7swikn0STs41+ERPMsE0gL2i/YGW133S/wqfx tCEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=CRmpJqPfR2Ffc8HgrJVdi9vtvYXJmh3FYn3557q1NwE=; b=zf2y+fQjgxQoVvvWWeMbyZMlRjvFEMankkwWAcnG7FbCTuH5LShCe5tig+NYaQT9tD CL/cjK3U9bZzyZkRbu8qMMQi4VBB+4JBgiedYzHyCSeGFnV7XubYAe64igKlgarifB4J aVLA2BdujEfdNYF2glx2Knwdvyway3di59lF5AROu/xyI78TnBAAMzl1MiS/cP95vf7x dHMxcK+Dpuoh0LxaBo4kBbc309q4V6Cgb4nnkCdZk6hePxsoksiqG+MP+hkYyhBpDAWx F9Oh0iRdLKZJXQBWR+p8w8DBqk/ApBQw6VSFRA+3iYfTptO1WfUGxD3eYDdTeBlvjNq7 KJVA== X-Gm-Message-State: AJIora/GWtEgCDzkd0QO0WSJKTEtOWQ/x8J92i0EK+Mm87MdPzApZdcj 8IFvII83YSbrgjPsepN6OSY= X-Google-Smtp-Source: AGRyM1vsKaZ4Q845hwAJdZ+Iup3JowgDZtmbhIizUAD0kSH6BZk1L5rQHvQIxX0hZopZgMtlLU/zgg== X-Received: by 2002:a05:6214:c6e:b0:472:edeb:f694 with SMTP id t14-20020a0562140c6e00b00472edebf694mr2331526qvj.90.1656799178059; Sat, 02 Jul 2022 14:59:38 -0700 (PDT) Received: from localhost ([2601:4c1:c100:1230:e838:b1c2:b125:986a]) by smtp.gmail.com with ESMTPSA id q15-20020ac8450f000000b003177f0fb61esm16496345qtn.75.2022.07.02.14.59.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Jul 2022 14:59:37 -0700 (PDT) Date: Sat, 2 Jul 2022 14:59:37 -0700 From: Yury Norov To: Andy Shevchenko Cc: linux-kernel@vger.kernel.org, Andrew Morton , David Howells , Geert Uytterhoeven , Jonathan Corbet , "Kirill A . Shutemov" , Matthew Wilcox , NeilBrown , Rasmus Villemoes , Russell King , Vlastimil Babka , William Kucharski , linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org Subject: Re: [PATCH 5/8] lib/cpumask: change return types to unsigned where appropriate Message-ID: References: <20220701125430.2907638-1-yury.norov@gmail.com> <20220701125430.2907638-6-yury.norov@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220702_145939_159157_F4B5F5BC X-CRM114-Status: GOOD ( 14.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Jul 02, 2022 at 03:00:19PM +0300, Andy Shevchenko wrote: > On Fri, Jul 01, 2022 at 05:54:27AM -0700, Yury Norov wrote: > > Switch return types to unsigned int where return values cannot be negative. > > ... > > > -int cpumask_any_and_distribute(const struct cpumask *src1p, > > +unsigned int cpumask_any_and_distribute(const struct cpumask *src1p, > > const struct cpumask *src2p); > > It breaks indentation of the second line. I'd prefer to keep 2nd line untouched to not trash history for nothing. > > ... > > > -int cpumask_next_and(int n, const struct cpumask *src1p, > > +unsigned int cpumask_next_and(int n, const struct cpumask *src1p, > > const struct cpumask *src2p) > > Ditto. > > And seems a lot of cases in the series like this. > > -- > With Best Regards, > Andy Shevchenko > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel