From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7E83EC433EF for ; Mon, 4 Jul 2022 08:16:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=chei3XFItkRGFY8cy+q4cs1ZBj0mD4X4xjEjaf960eU=; b=vIGGEZ0gxB3ydg d6mZ8jYKRlGORgMPCbJGz5OBbABUGQnBPRQB5JvOzsghZzb7S2/cyBIrpbf9RMFw0BkKn9Px0mj+z bXopjTjLXXwUvksdrSTt7ea6rjE9BypjBZWudIB0w/s7lFxtpD3qFTmjpmXMZafbgtNQo8vQ8qvDG qIjxyWwRU/gcRFUqKGw89GBt4BnjVa4v06SF3MBBxdu7Ca2M09IPl4hWLlHb+VZTvdqb8yelPUcP2 JUXZzdzx5M3hTeCLTfdV0GY7+6TIDzD4Yi6ORKY6sWzdBYZODs5RfEGu4NTLXwXGKxND3u/gycD1S LRlomWpZP1TVBGYRcnmw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o8HFM-005zj8-K0; Mon, 04 Jul 2022 08:15:56 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o8HCX-005yIi-Uo for linux-arm-kernel@lists.infradead.org; Mon, 04 Jul 2022 08:13:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=Xh0s1LpzcO7nydfkpZGpNseYKTnrZ+2Np/ZcfDCXpDc=; b=GRRRgUttFjPFbbfTAINrHCG6OO G3Ucab5+mdT7nPB0AuW6e16lKwr8uqFfCLD1pBhBi2XnR5OJs9KjIC0QdsEFFfzuXCBfQq2ia9qcc zfUxLnlTxNNrSOYXchj1Y416h76UnLVXcdFm2EZfEflJ8dDq0Fb6iWj2x6PLVujKUEPU=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1o8HCK-009GCW-Ug; Mon, 04 Jul 2022 10:12:48 +0200 Date: Mon, 4 Jul 2022 10:12:48 +0200 From: Andrew Lunn To: Ahmad Fatoum Cc: Wei Fang , davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, aisheng.dong@nxp.com, devicetree@vger.kernel.org, peng.fan@nxp.com, ping.bai@nxp.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, sudeep.holla@arm.com, festevam@gmail.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/3] arm64: dts: imx8ulp: Add the fec support Message-ID: References: <20220704101056.24821-1-wei.fang@nxp.com> <20220704101056.24821-3-wei.fang@nxp.com> <751e1ec6-2d34-44f6-a6c3-775df8a3cea2@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <751e1ec6-2d34-44f6-a6c3-775df8a3cea2@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220704_011302_024321_8A51E05C X-CRM114-Status: UNSURE ( 8.65 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > > + clocks = <&cgc1 IMX8ULP_CLK_XBAR_DIVBUS>, > > + <&pcc4 IMX8ULP_CLK_ENET>, > > + <&cgc1 IMX8ULP_CLK_ENET_TS_SEL>, > > + <&clock_ext_rmii>; > > + clock-names = "ipg", "ahb", "ptp", "enet_clk_ref"; > > I think the default should be the other way round, assume MAC to provide reference > clock and allow override on board-level if PHY does it instead. I would make it the same as all the other instances of FEC in the IMX7, IMX6, IMX5, IMX4, Vybrid etc Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel