From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9DD5AC43334 for ; Tue, 5 Jul 2022 15:23:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RF0Ctae04qQhCrC4icpHZgQgXV7eXdwqIoFOgsYqRFw=; b=3wbsGdJ1rMT46L oSHBFyjszi2sU6ZADhrWrOnEtaWIVLTvOkocZUrRp6H0U35kJdQmSYpzGqbIHIC9XGOKlkJKy7Kvm rB6KqzvV1gHFlLQ15YfnHWSxoS7umUbWS/R6stcC/T4vrPkX4vEb/YwllSc0+caMJZ0cWRFQCSC40 JAZUHs1Q3YAmON77bQqDwrt2Ppb7d0PNZk6BzKXjabpL+VcnoOgLHJbmQRHDjM/7Iae7y+QcgjYn0 sP9WvAPLWNI8yfE113jYlkTlVkiuN/AakPQldQ2wYxBNdzkaZAYZ4dtidGWw1mlW/XtrUySei4j6K WYlbPivV5i7ZJL6h1sNA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o8kNz-0017Z6-ES; Tue, 05 Jul 2022 15:22:47 +0000 Received: from mail-ua1-x931.google.com ([2607:f8b0:4864:20::931]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o8kNs-0017Ub-Md for linux-arm-kernel@lists.infradead.org; Tue, 05 Jul 2022 15:22:43 +0000 Received: by mail-ua1-x931.google.com with SMTP id r18so2472058uan.4 for ; Tue, 05 Jul 2022 08:22:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vanguardiasur-com-ar.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=H/Bc/bJMHnC8mzLiX26E9yJXZ58JRgepqJ5GBKZIhIU=; b=FUu2PrOJcHfJzsPTGNQFGyVj7WroZoWbVSu8xerO75dS1A1hxzRlGdvouBnBFwSEqe PCc699FCk2IEmsopsLfinplJ3DwZIkZ5cIqeJx8v4tL8ZkvcZSBX2f4m1GO/XauIpHTI 1wVdONerVllsWdipFeEmDJBNSX7RZbiy9b/Lmr0sFYsbgodT+F67jjkhcZAWbNAkPNTo UdK6q17Lu32ZInqcxOE0jgo5I1vOUISlBBxQTGJFgqrjCr9XCZAofjxLIR9K10j08aly gAQSHHC8RJJPqtGBtB+jK6GoYocJ3Wt00zSElHsyqBm98rYtSY0gzTk44ZqMqGkRjJig Dbiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=H/Bc/bJMHnC8mzLiX26E9yJXZ58JRgepqJ5GBKZIhIU=; b=gRXuZxAuN3p2KGQcleiDLuV5HxElHkTp67nN20MNaUCeWmWyTfkfvIyfKAqBOJpbRA YDvCg3T7hWRA9nmJvF1ofJLrhCcXtQXeCNBGOISGezRv7WSMDsXKfJEoEP2DagBQaZ3U +tSbPyuyzS/+BrsoxA+dxE8Vpfju01IgUNq4gCBGXRZzD6I5K2f7Dm1qrUY8oVq/6jUT 6L/Y4q5IWKV7bSLqPJfnOHC4/j9KwqxZ6TbiMGHIAMqWYSbZf2sFhRkQjUi4RQtLX3De 0aKyRH4wnyxgtmQ3wDN3lv5gj/8zWiSfuYTl8v3E2H+eCLLg46EIBdp3ByYPfQ2dGHlD /OKA== X-Gm-Message-State: AJIora8D8/JLBcsF4KPSq3dEo6IJDh/nC6pOcIf1wr3t3N84pVu7i1AT VYlt49TZFQ3wHxsj32aCvPxkIg== X-Google-Smtp-Source: AGRyM1sib/Rl8zTG8OOfQq2RftxdlE1mO6TAX2MJwRY06PgFNm4cje0JTXSroOCahYX2r6A6k5wYIw== X-Received: by 2002:ab0:2093:0:b0:382:935c:aaf8 with SMTP id r19-20020ab02093000000b00382935caaf8mr4927068uak.90.1657034558560; Tue, 05 Jul 2022 08:22:38 -0700 (PDT) Received: from eze-laptop ([190.190.187.68]) by smtp.gmail.com with ESMTPSA id j10-20020a05610202ea00b00356f933b161sm1251842vsj.9.2022.07.05.08.22.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Jul 2022 08:22:38 -0700 (PDT) Date: Tue, 5 Jul 2022 12:22:32 -0300 From: Ezequiel Garcia To: Benjamin Gaignard Cc: mchehab@kernel.org, hverkuil@xs4all.nl, p.zabel@pengutronix.de, gregkh@linuxfoundation.org, mripard@kernel.org, paul.kocialkowski@bootlin.com, wens@csie.org, jernej.skrabec@gmail.com, samuel@sholland.org, nicolas.dufresne@collabora.com, andrzej.p@collabora.com, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, kernel@collabora.com Subject: Re: [PATCH v10 07/17] media: uapi: HEVC: Add SEI pic struct flags Message-ID: References: <20220705085420.272912-1-benjamin.gaignard@collabora.com> <20220705085420.272912-8-benjamin.gaignard@collabora.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220705085420.272912-8-benjamin.gaignard@collabora.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220705_082240_847682_6A199DD9 X-CRM114-Status: GOOD ( 18.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jul 05, 2022 at 10:54:10AM +0200, Benjamin Gaignard wrote: > The possible values for the field_pic field in the v4l2_hevc_dpb_entry > structure are defined in the table D.2 in HEVC specification section D.3.3. > Add flags and documentation for each of them. > > Signed-off-by: Benjamin Gaignard > Acked-by: Nicolas Dufresne > Tested-by: Jernej Skrabec Reviewed-by: Ezequiel Garcia > --- > .../media/v4l/ext-ctrls-codec.rst | 54 +++++++++++++++++++ > include/media/hevc-ctrls.h | 14 +++++ > 2 files changed, 68 insertions(+) > > diff --git a/Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst b/Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst > index 3dfb81a93935..8ba16e8742f3 100644 > --- a/Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst > +++ b/Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst > @@ -3218,6 +3218,7 @@ enum v4l2_mpeg_video_hevc_size_of_length_field - > * - __u8 > - ``field_pic`` > - Whether the reference is a field picture or a frame. > + See :ref:`HEVC dpb field pic Flags ` > * - __u16 > - ``pic_order_cnt[2]`` > - The picture order count of the reference. Only the first element of the > @@ -3231,6 +3232,59 @@ enum v4l2_mpeg_video_hevc_size_of_length_field - > > \normalsize > > +.. _hevc_dpb_field_pic_flags: > + > +``HEVC dpb field pic Flags`` > + > +.. raw:: latex > + > + \scriptsize > + > +.. flat-table:: > + :header-rows: 0 > + :stub-columns: 0 > + :widths: 1 1 2 > + > + * - ``V4L2_HEVC_SEI_PIC_STRUCT_FRAME`` > + - 0 > + - (progressive) Frame > + * - ``V4L2_HEVC_SEI_PIC_STRUCT_TOP_FIELD`` > + - 1 > + - Top field > + * - ``V4L2_HEVC_SEI_PIC_STRUCT_BOTTOM_FIELD`` > + - 2 > + - Bottom field > + * - ``V4L2_HEVC_SEI_PIC_STRUCT_TOP_BOTTOM`` > + - 3 > + - Top field, bottom field, in that order > + * - ``V4L2_HEVC_SEI_PIC_STRUCT_BOTTOM_TOP`` > + - 4 > + - Bottom field, top field, in that order > + * - ``V4L2_HEVC_SEI_PIC_STRUCT_TOP_BOTTOM_TOP`` > + - 5 > + - Top field, bottom field, top field repeated, in that order > + * - ``V4L2_HEVC_SEI_PIC_STRUCT_BOTTOM_TOP_BOTTOM`` > + - 6 > + - Bottom field, top field, bottom field repeated, in that order > + * - ``V4L2_HEVC_SEI_PIC_STRUCT_FRAME_DOUBLING`` > + - 7 > + - Frame doubling > + * - ``V4L2_HEVC_SEI_PIC_STRUCT_FRAME_TRIPLING`` > + - 8 > + - Frame tripling > + * - ``V4L2_HEVC_SEI_PIC_STRUCT_TOP_PAIRED_PREVIOUS_BOTTOM`` > + - 9 > + - Top field paired with previous bottom field in output order > + * - ``V4L2_HEVC_SEI_PIC_STRUCT_BOTTOM_PAIRED_PREVIOUS_TOP`` > + - 10 > + - Bottom field paired with previous top field in output order > + * - ``V4L2_HEVC_SEI_PIC_STRUCT_TOP_PAIRED_NEXT_BOTTOM`` > + - 11 > + - Top field paired with next bottom field in output order > + * - ``V4L2_HEVC_SEI_PIC_STRUCT_BOTTOM_PAIRED_NEXT_TOP`` > + - 12 > + - Bottom field paired with next top field in output order > + > .. c:type:: v4l2_hevc_pred_weight_table > > .. raw:: latex > diff --git a/include/media/hevc-ctrls.h b/include/media/hevc-ctrls.h > index 01c1795c57a9..f3695ab44389 100644 > --- a/include/media/hevc-ctrls.h > +++ b/include/media/hevc-ctrls.h > @@ -132,6 +132,20 @@ struct v4l2_ctrl_hevc_pps { > > #define V4L2_HEVC_DPB_ENTRY_LONG_TERM_REFERENCE 0x01 > > +#define V4L2_HEVC_SEI_PIC_STRUCT_FRAME 0 > +#define V4L2_HEVC_SEI_PIC_STRUCT_TOP_FIELD 1 > +#define V4L2_HEVC_SEI_PIC_STRUCT_BOTTOM_FIELD 2 > +#define V4L2_HEVC_SEI_PIC_STRUCT_TOP_BOTTOM 3 > +#define V4L2_HEVC_SEI_PIC_STRUCT_BOTTOM_TOP 4 > +#define V4L2_HEVC_SEI_PIC_STRUCT_TOP_BOTTOM_TOP 5 > +#define V4L2_HEVC_SEI_PIC_STRUCT_BOTTOM_TOP_BOTTOM 6 > +#define V4L2_HEVC_SEI_PIC_STRUCT_FRAME_DOUBLING 7 > +#define V4L2_HEVC_SEI_PIC_STRUCT_FRAME_TRIPLING 8 > +#define V4L2_HEVC_SEI_PIC_STRUCT_TOP_PAIRED_PREVIOUS_BOTTOM 9 > +#define V4L2_HEVC_SEI_PIC_STRUCT_BOTTOM_PAIRED_PREVIOUS_TOP 10 > +#define V4L2_HEVC_SEI_PIC_STRUCT_TOP_PAIRED_NEXT_BOTTOM 11 > +#define V4L2_HEVC_SEI_PIC_STRUCT_BOTTOM_PAIRED_NEXT_TOP 12 > + > #define V4L2_HEVC_DPB_ENTRIES_NUM_MAX 16 > > struct v4l2_hevc_dpb_entry { > -- > 2.32.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel