From: Vinod Koul <vkoul@kernel.org>
To: Shengjiu Wang <shengjiu.wang@nxp.com>
Cc: shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dmaengine: imx-sdma: Fix compile warning 'Function parameter not described'
Date: Wed, 6 Jul 2022 10:47:10 +0530 [thread overview]
Message-ID: <YsUa1qwIb2LzrUjW@matsya> (raw)
In-Reply-To: <1652858507-12628-1-git-send-email-shengjiu.wang@nxp.com>
On 18-05-22, 15:21, Shengjiu Wang wrote:
> Fix compile warning that 'Function parameter or member not described'
> with 'W=1' option:
>
> There is no description for struct sdma_script_start_addrs, so use /*
> instead of /**
>
> Add missed description for struct sdma_desc
Patch title should describe the change, so add struct documentation etc
would be apt. Pls revise
>
> Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
> ---
> drivers/dma/imx-sdma.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
> index 95367a8a81a5..111beb7138e0 100644
> --- a/drivers/dma/imx-sdma.c
> +++ b/drivers/dma/imx-sdma.c
> @@ -188,7 +188,7 @@
> #define SDMA_DONE0_CONFIG_DONE_SEL BIT(7)
> #define SDMA_DONE0_CONFIG_DONE_DIS BIT(6)
>
> -/**
> +/*
> * struct sdma_script_start_addrs - SDMA script start pointers
> *
> * start addresses of the different functions in the physical
> @@ -424,6 +424,11 @@ struct sdma_desc {
> * @data: specific sdma interface structure
> * @bd_pool: dma_pool for bd
> * @terminate_worker: used to call back into terminate work function
> + * @terminated: terminated list
> + * @is_ram_script: flag for script in ram
> + * @n_fifos_src: number of source device fifos
> + * @n_fifos_dst: number of destination device fifos
> + * @sw_done: software done flag
> */
> struct sdma_channel {
> struct virt_dma_chan vc;
> --
> 2.17.1
--
~Vinod
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-07-06 5:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-18 7:21 [PATCH] dmaengine: imx-sdma: Fix compile warning 'Function parameter not described' Shengjiu Wang
2022-07-06 5:17 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YsUa1qwIb2LzrUjW@matsya \
--to=vkoul@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=shengjiu.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox