From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A8A16C43334 for ; Wed, 6 Jul 2022 10:52:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QATzv3sQbLv9qOpqDpDR7O31/09Ial0ze5bnX66oqUc=; b=pM5LwHQO1XhcMk Rfk4yVcQX3XRBoe1+8mdrMPqYJWNVIxOGPpNVOdq/W6eC79GmR3QURqxHidFAv7TF6r0CvsgMTkY/ 2iEVjfg0nv+Z5H2kUdDEt6t4UfWoK5iAu4CKj0TQH5q2f9uM+KRasMLZIDL3sdcxdBP2iaMJkTrzp TMuodlReApdL7nfwe/66klRpbBSuPN7sfADH+iMqlm4CVPzdvcRoFS3xd7kBDU8yexYk5Y37hNpK9 Xq5rPuf0u4Pn5Vc4D803MS0TDoFRbDl7rcQPZVt1nCJHZDzwOliZRZc0RKnACIa2ytDD/loIWM2Kk hPt7aNNFP6KUw5Pg/SlQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o92cb-008sGV-Q1; Wed, 06 Jul 2022 10:51:05 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o92cX-008s4r-Ik for linux-arm-kernel@lists.infradead.org; Wed, 06 Jul 2022 10:51:04 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 31A171042; Wed, 6 Jul 2022 03:50:52 -0700 (PDT) Received: from monolith.localdoman (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6F0363F66F; Wed, 6 Jul 2022 03:50:50 -0700 (PDT) Date: Wed, 6 Jul 2022 11:51:17 +0100 From: Alexandru Elisei To: Calvin Owens Cc: maz@kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, will@kernel.org, mark.rutland@arm.com Subject: Re: [RFC PATCH v5 15/38] perf: arm_spe_pmu: Move struct arm_spe_pmu to a separate header file Message-ID: References: <20211117153842.302159-1-alexandru.elisei@arm.com> <20211117153842.302159-16-alexandru.elisei@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220706_035101_746606_EF0A946E X-CRM114-Status: GOOD ( 27.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Calvin, Thank you for the interest! FYI, I'm working on the next iteration of the series where I'm planning to remove the dependency on CONFIG_NUMA_BALANCING being unset. On Tue, Jul 05, 2022 at 09:57:22AM -0700, Calvin Owens wrote: > Hi Alexandru, > > I've been taking a look at this series, it needs a little tweak to > build successfully as a module which I've appended below. > > Cheers, > Calvin > > On Wed, Nov 17, 2021 at 03:38:19PM +0000, Alexandru Elisei wrote: > > KVM will soon want to make use of struct arm_spe_pmu, move it to a separate > > header where it will be easily accessible. This is a straightforward move > > and functionality should not be impacted. > > > > CC: Will Deacon > > Signed-off-by: Alexandru Elisei > > --- > > > > > +++ b/include/linux/perf/arm_spe_pmu.h > > @@ -0,0 +1,49 @@ > > +/* SPDX-License-Identifier: GPL-2.0-only */ > > +/* > > + * Split from from drivers/perf/arm_spe_pmu.c. > > + * > > + * Copyright (C) 2021 ARM Limited > > + */ > > + > > +#ifndef __ARM_SPE_PMU_H__ > > +#define __ARM_SPE_PMU_H__ > > + > > +#include > > +#include > > +#include > > +#include > > + > > +#ifdef CONFIG_ARM_SPE_PMU > > Here, we need to use the IS_ENABLED() macro for the ARM_SPE_PMU=m case. > > Signed-off-by: Calvin Owens > --- > include/linux/perf/arm_spe_pmu.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/linux/perf/arm_spe_pmu.h b/include/linux/perf/arm_spe_pmu.h > index 505a8867daad..b643e5e7a766 100644 > --- a/include/linux/perf/arm_spe_pmu.h > +++ b/include/linux/perf/arm_spe_pmu.h > @@ -13,7 +13,7 @@ > #include > #include > > -#ifdef CONFIG_ARM_SPE_PMU > +#if IS_ENABLED(CONFIG_ARM_SPE_PMU) > > struct arm_spe_pmu { > struct pmu pmu; > @@ -50,6 +50,6 @@ void kvm_host_spe_init(struct arm_spe_pmu *spe_pmu); > #define kvm_host_spe_init(x) do { } while(0) > #endif > > -#endif /* CONFIG_ARM_SPE_PMU */ > +#endif /* IS_ENABLED(CONFIG_ARM_SPE_PMU) */ > > #endif /* __ARM_SPE_PMU_H__ */ > -- > 2.30.2 This indeed fixes the nasty screenfulls of errors that I get when trying to compile with CONFIG_ARM_SPE_PMU=m. If that's alright with you, I'll fold the fix into the patch and I'll CC you. Thanks, Alex _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel