From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6CD42C433EF for ; Wed, 6 Jul 2022 17:11:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PKaq9wDqyOYqflNCN4kq5f5w7CKm3NkasAD4uyORc68=; b=dVSdGJUa+lAkNG uXyDF6mkYDlxQ1pgyXPZduARCMBbE4mhkfaVbJy9pbl1MW0XA2ppn8+4EcmSRpkK8u0PBzB9fVRu7 +twwLnFEquRTrCMuHbwzb7SXCUtrkI1gIZuDBSFrbYPYyAIOrgM2Yh0A9IHm7rYxDgSj6gweynoL3 HBacFT2x2KyJnd94+7fZ/+mHxrCR2kGZHigs1UMY/jH3gnuuPvaaosTx987av3GtAi/eJ8LeG5lMd 5ZzOo3DpAmTesbObGgajyZtCReVdBdYl1pfwEVACic7Bu30lf5qottQJa9AMPkBo9m6POi/yMJKyF mpyPcx8bnsRNjFq7J0hw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o98Wm-00BbRy-M0; Wed, 06 Jul 2022 17:09:30 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o98Ku-00BWNF-3F; Wed, 06 Jul 2022 16:57:13 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BA36961E24; Wed, 6 Jul 2022 16:57:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 555C8C3411C; Wed, 6 Jul 2022 16:57:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657126630; bh=GF/aKIAzhOdpyO5Xdb1pXVqwDvZ44YUeDjQ86DdLEVU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=B7UfPWR6H7wHVWrVGgUXtsz5mVegP0uqNRm7Rl0GaG6lSk3/XF0bJ1dRDz910/nrw ArJlrBbcmQVUkXNEozaNrykOgZ0XjbILwzH8Eig5ZPcPfEFKMTk1JzxGSdij9yq67/ xOtgyfqkH+q2ZHp2h9BXhpi1JfDk6uKgD51fVcSVBFpqrBwKzY7rLXfVsxlhUhgZM9 CMDchWma018hV0+3hZpxLL5P198TNxnQukwCj8zo74rOMxLjpft0GWboEFVGfNRYBH dVp5s+/IxNrMQyMbS6/mLBlKrb3ESTrf8ZNrF6Lyz4CJD9yebEDJ5ftpznp9zNLEc9 NUsajuj6c/aKA== Date: Wed, 6 Jul 2022 22:27:05 +0530 From: Vinod Koul To: Sean Anderson Cc: "David S . Miller" , Jakub Kicinski , Madalin Bucur , netdev@vger.kernel.org, Russell King , Paolo Abeni , linux-arm-kernel@lists.infradead.org, Eric Dumazet , linux-kernel@vger.kernel.org, Ioana Ciornei , Jonathan Corbet , Kishon Vijay Abraham I , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-phy@lists.infradead.org Subject: Re: [PATCH net-next v2 04/35] [RFC] phy: fsl: Add Lynx 10G SerDes driver Message-ID: References: <20220628221404.1444200-1-sean.anderson@seco.com> <20220628221404.1444200-5-sean.anderson@seco.com> <431a014a-3a8f-fdc7-319e-29df52832128@seco.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <431a014a-3a8f-fdc7-319e-29df52832128@seco.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220706_095712_224641_C3EBF7BE X-CRM114-Status: GOOD ( 18.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 05-07-22, 11:29, Sean Anderson wrote: > >> + /* TODO: wait for the PLL to lock */ > > > > when will this be added? > > I'm not sure. I haven't had any issues with this, and waiting on the lock bit is > only mentioned in some datasheets for this SerDes. On the LS1046A for example, > there is no mention of waiting for lock. okay maybe remove the comment then? > >> +static const struct clk_ops lynx_pll_clk_ops = { > >> + .enable = lynx_pll_enable, > >> + .disable = lynx_pll_disable, > >> + .is_enabled = lynx_pll_is_enabled, > >> + .recalc_rate = lynx_pll_recalc_rate, > >> + .round_rate = lynx_pll_round_rate, > >> + .set_rate = lynx_pll_set_rate, > >> +}; > > > > right, this should be a clk driver > > Well, it is a clock driver, effectively internal to the SerDes. There are a few > examples of this already (e.g. the qualcomm and cadence phys). It could of course > be split off, but I would prefer that they remained together. I would prefer clk driver is split and we maintain clean split b/w phy and clk -- ~Vinod _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel