Re: [PATCH] dt-bindings: dma: allwinner,sun50i-a64-dma: Fix min/max typo

Jernej Škrabec
2022-07-02T19:35:46Z

Dne sobota, 02. julij 2022 ob 05:19:02 CEST je Samuel Holland napisal(a):
> The conditional block for variants with a second clock should have set
> minItems, not maxItems, which was already 2. Since clock-names requires
> two items, this typo should not have caused any problems.
>
> Fixes: edd14218bd66 ("dt-bindings: dmaengine: Convert Allwinner A31 and A64
> DMA to a schema") Signed-off-by: Samuel Holland <samuel@sholland.org>
> ---
>
> .../devicetree/bindings/dma/allwinner,sun50i-a64-dma.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
> a/Documentation/devicetree/bindings/dma/allwinner,sun50i-a64-dma.yaml
> b/Documentation/devicetree/bindings/dma/allwinner,sun50i-a64-dma.yaml index
> ff0a5c58d78c..e712444abff1 100644
> --- a/Documentation/devicetree/bindings/dma/allwinner,sun50i-a64-dma.yaml
> +++ b/Documentation/devicetree/bindings/dma/allwinner,sun50i-a64-dma.yaml
> @@ -67,7 +67,7 @@ if:
> then:
> properties:
> clocks:
> - maxItems: 2
> + minItems: 2

These specific variants have exactly 2 clocks. Having both limits seems right.

Best regards,
Jernej

>
> required:
> - clock-names