From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B372DC433EF for ; Wed, 6 Jul 2022 13:08:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lnuiAosHrNIAlRgbohP2hAklQ6O5z819rDa0HwAGh0w=; b=P1fwG9jPpwQ2p/Vde5/Koeg2wP CwMBL2Yvz+nztvu2TSKiKC0Rrfa0fYmMQL9rRjhHIPu32srP244bcCsuDpgAeCyrxT1TMMvN5Dhzp QG4QrRn0HTDReuZ22eN/ZR9kugZIlVlgKqzBeJZhYRI+lQmSMPen7uvX4oGNMGm/x0Xeir6km4lJI Ah4e/Yt9EnZN671539D4Og+V5h6lajl0MibgyGy3TBoPZw3bPSYRNvzKBYqrF12pDDouKMftWb72n NnEf/uRtjNZavMBDIgqbWmTabi5sviK5ITev87gnThf17u3j5lniihWBO/qM4zDIYDNXOCpz/sf/J XTJDcehg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o94kA-00A9qj-SM; Wed, 06 Jul 2022 13:07:02 +0000 Received: from www.zeus03.de ([194.117.254.33] helo=mail.zeus03.de) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o94k6-00A9oH-Ln for linux-arm-kernel@lists.infradead.org; Wed, 06 Jul 2022 13:07:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple; d=sang-engineering.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=k1; bh=D0hNbSBzGzNXDpHde8BsfsD5hfBQ bb4aorNSvpTgVrU=; b=E6cdQmWOgXODAMsv1qYtftsUDkq8yB2rzDN7nbBj49dC OTU5rWih/KddxbSWUIuqbYyZA1DH1debq9NIp/cByt22mxrn5n/ONLBreV56cIbi Lq0NaxHrB7CM921l7oThMnvySzFR0PaRyaVsm+XjBJmkMxL8giq3frwg2nVAZ1E= Received: (qmail 1712726 invoked from network); 6 Jul 2022 15:06:46 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 6 Jul 2022 15:06:46 +0200 X-UD-Smtp-Session: l3s3148p1@ZX/5oyLjKmlZzIq1 Date: Wed, 6 Jul 2022 15:06:42 +0200 From: Wolfram Sang To: Andy Shevchenko Subject: Re: [PATCH v2 2/2] i2c: Introduce i2c_str_read_write() and make use of it Message-ID: Mail-Followup-To: Wolfram Sang , Andy Shevchenko , Michael Walle , Krzysztof Kozlowski , Sam Protsenko , Lucas De Marchi , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Codrin Ciubotariu , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Krzysztof Kozlowski , Alim Akhtar , Till Harbaum References: <20220703154232.55549-1-andriy.shevchenko@linux.intel.com> <20220703154232.55549-2-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 In-Reply-To: <20220703154232.55549-2-andriy.shevchenko@linux.intel.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220706_060659_042929_8D050BC5 X-CRM114-Status: GOOD ( 12.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , linux-samsung-soc@vger.kernel.org, Lucas De Marchi , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , linux-renesas-soc@vger.kernel.org, Krzysztof Kozlowski , Michael Walle , linux-i2c@vger.kernel.org, Alim Akhtar , Codrin Ciubotariu , Sam Protsenko , Claudiu Beznea , linux-arm-kernel@lists.infradead.org, Till Harbaum Content-Type: multipart/mixed; boundary="===============7769676193408246711==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============7769676193408246711== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="CdaVGdeblKJUV2jY" Content-Disposition: inline --CdaVGdeblKJUV2jY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Andy, On Sun, Jul 03, 2022 at 06:42:32PM +0300, Andy Shevchenko wrote: > str_read_write() returns a string literal "read" or "write" based > on the value. It also allows to unify usage of a such in the kernel. >=20 > For i2c case introduce a wrapper that takes struct i2c_msg as parameter. >=20 > Signed-off-by: Andy Shevchenko To be honest, I don't think this series is very useful. Most of the converted strings here are debug printouts which could rather be removed because we have a tracepoint for i2c_transfer (which is the preferred unification). The warnings printed on timeouts are plain wrong, because timeouts can happen and need to be handled by the client driver. And the change in the I2C core is not worth the hazzle IMHO. Happy hacking, Wolfram --CdaVGdeblKJUV2jY Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmLFiN4ACgkQFA3kzBSg KbaOnRAAlv7WrOzngujipBR3pVf3yo6uKVwFX+PykjBTa0wBHwetMP0pYuObpjH9 MPI+xi3IOPO8nnwQgPbg8ke0Yq4akFTTkLG8QOXU1ddT1UWRq1TJXNB9hME3tXGD WkO7L/wslhrvwy48f+0nOJotVJ3q34bifTQ78CTnFyYY6Tfg6BgF/opp70w7XNgW 5blntGsxPCRsh1VBlDilYsgh3TXzmD934y8v1hFpM2BXFgnHKsID9FOeHVDsuB8O RL08dyCz/yt2r4M0f7DDOF56PS/35JsJhZ5v2F9er0fkPgEdS392WEeJrQhiQ920 ugWPpY6MhwTuTFZQqaeiv9moB+j1BBcKoEyG3c4quq35KKIYsaaC0fj40+1u9Gel wlZ5qxgE29BYSWZocpQbdFF8jG/iEhnEy9pIRfGfQagUypOLsqqcsk5Qq9aavWHK Vu4pI5SRlsMcRWzWO4592D8KYF5Tc/0NQ+qfCj6AO+OwBIBR+S7lBsLiNpIETLil EMa1kLVlr/ElAFyqXIa8yX7vvK9xHDcHEPWsW3Q30g5QEGT40iXSGkM21l3KebVz Lw7qzoMkINICUNGP2ULiYOCgafWdlVlev4RmQCDFDljj2ZKH1ph91kJeM7YscDj5 ZGh3HI5USzLFt/C6uFVIwSpz2aM2IMOWcasNvtXlR7RZNu/qwdI= =srXy -----END PGP SIGNATURE----- --CdaVGdeblKJUV2jY-- --===============7769676193408246711== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============7769676193408246711==--