From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0A968C433EF for ; Fri, 8 Jul 2022 10:07:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aIzX9T9CviHlFGpngVACGeRKxNR/SZ3H04Jr8tJ4h7g=; b=cU/+5M0zQ+X5gV EKrSlABcyw+QovAuxGMSpkpSWZ4Zbaf54v+o+CrnHmwxnR4iMglc4ISjH00EykSxzl6UtiQkk2Sfh rIEIxtBMEI7SjYB/IupxhXmS7JmB7R2rpBoNYREGZEOV0QBQ8gjuuKxpab2rQIWeiq381sMFz7k0u sWvALnHFXSk93urSWptDWcQXtilnSflmJhNCE7F5CamAdt+YE8Ff2Nw3TbzjKFRjyd5Xq10gpEE4/ bS22UEBXBSc1R+UkF0KUP4in7QUMZfFvASmQKUwJaM2CY2TBKpyA7Vq0ALB8ert1lD9ccS8oD0upj G/Sxg+WP6Wb6EbBHhcSQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o9ksP-0037fM-3E; Fri, 08 Jul 2022 10:06:21 +0000 Received: from mga12.intel.com ([192.55.52.136]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o9ksM-0037eG-4s for linux-arm-kernel@lists.infradead.org; Fri, 08 Jul 2022 10:06:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1657274778; x=1688810778; h=date:from:to:subject:message-id:references:mime-version: in-reply-to; bh=lbqQjKB+wMbVvhshNl7agCaUpV1RPa7FLoLbtHU0PKQ=; b=AXy4hlHb/FIpbP3rMKbdbj4pZhZd7LFmeN4dAXAlvmDqJjbd1CYUyxnf cYVW36JRyWYh/jtQ04XCs4LcLSf8zMwXYdSdI0OSFO6KSAdwugBuLI0FY hNfNVKRDmiFLIxTKFvlfqD+sdPhJvT89YXk47yegybAlrbfDr6XzKiCX2 pETqQ21frFkXRzVKwPHRQbBpnmuT4thNBOTHlvvwU2QrJVPABrWnpnQBr wnZ8VEQkfiabTeVmEpozZVYYzd69cAEbTZFnIGm7gvCl2XWLOzxFD7/IX nah64zAmwBzS52UBvXbzR/kAamtDi7m42uW/W8St/wwB89fPNKWm4EJ4m g==; X-IronPort-AV: E=McAfee;i="6400,9594,10401"; a="264027582" X-IronPort-AV: E=Sophos;i="5.92,255,1650956400"; d="scan'208";a="264027582" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jul 2022 03:06:16 -0700 X-IronPort-AV: E=Sophos;i="5.92,255,1650956400"; d="scan'208";a="683618026" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jul 2022 03:06:12 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1o9ksD-0017y9-0P; Fri, 08 Jul 2022 13:06:09 +0300 Date: Fri, 8 Jul 2022 13:06:08 +0300 From: Andy Shevchenko To: Wolfram Sang , Michael Walle , Krzysztof Kozlowski , Sam Protsenko , Lucas De Marchi , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Codrin Ciubotariu , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Krzysztof Kozlowski , Alim Akhtar , Till Harbaum Subject: Re: [PATCH v2 2/2] i2c: Introduce i2c_str_read_write() and make use of it Message-ID: References: <20220703154232.55549-1-andriy.shevchenko@linux.intel.com> <20220703154232.55549-2-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220708_030618_252355_6927BF6C X-CRM114-Status: GOOD ( 17.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jul 06, 2022 at 03:06:42PM +0200, Wolfram Sang wrote: > On Sun, Jul 03, 2022 at 06:42:32PM +0300, Andy Shevchenko wrote: > > str_read_write() returns a string literal "read" or "write" based > > on the value. It also allows to unify usage of a such in the kernel. > > > > For i2c case introduce a wrapper that takes struct i2c_msg as parameter. > > > > Signed-off-by: Andy Shevchenko > > To be honest, I don't think this series is very useful. Most of the > converted strings here are debug printouts which could rather be removed > because we have a tracepoint for i2c_transfer (which is the preferred > unification). OK. > The warnings printed on timeouts are plain wrong, because > timeouts can happen and need to be handled by the client driver. OK > And the > change in the I2C core is not worth the hazzle IMHO. OK Just noticed yet another (but not in the category of the above) debug message [1]. Would it be acceptable to use patch 1 from this series and its use in (a completely new) patch 2? [1]: i2c-scmi.c: dev_dbg(&adap->dev, "access size: %d %s\n", size, (read_write) ? "READ" : "WRITE"); -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel