From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Mattijs Korpershoek <mkorpershoek@baylibre.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Kevin Hilman <khilman@baylibre.com>,
Fabien Parent <parent.f@gmail.com>,
linux-input@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH v3 0/2] Input: mt6779-keypad - fix hw code logic and row/col selection
Date: Fri, 8 Jul 2022 14:58:20 -0700 [thread overview]
Message-ID: <YsiofJQBZvLgQKSh@google.com> (raw)
In-Reply-To: <20220707075236.126631-1-mkorpershoek@baylibre.com>
On Thu, Jul 07, 2022 at 09:52:34AM +0200, Mattijs Korpershoek wrote:
> Input: mt6779-keypad - fix hw code logic and row/col selection
>
> This serie is the first follow-up on the mt6779-keypad in
> order to enable it on the MediaTek mt8183-pumpkin board.
>
> To fully enable it on mt8183-pumpkin, we still need:
> * double key support
> * dts changes
>
> To ease up reviewing, I preferred sending this first.
>
> The first patch fixes a logic bug based on the (non-public) datasheet
> I have.
> The second patch configures the keypad correctly in order to not
> report bogus values.
>
> Thank you,
> Mattijs
>
> Changes in v3:
> * reworked row/column logic as discussed in [1]
> * Dropped Angelo's review since patch 1 changed
>
> Changes in v2:
> * Simplified SEL_COL/ROW_MASK macros as suggested by Dmitry
> * Added Angelo's Reviewed-by on patch 1
>
> Mattijs Korpershoek (2):
> Input: mt6779-keypad - match hardware matrix organization
> Input: mt6779-keypad - implement row/column selection
>
> drivers/input/keyboard/mt6779-keypad.c | 18 +++++++++++++++---
> 1 file changed, 15 insertions(+), 3 deletions(-)
>
> [1] https://lore.kernel.org/r/YpMDZORAlHmg/x/0@google.com
>
> base-commit: c4bcc1b99b8b8acdfe673e4701a9c2acb6b8b2fb
> --
> 2.34.1
>
Applied the series, thank you.
--
Dmitry
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-07-08 21:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-07 7:52 [RESEND PATCH v3 0/2] Input: mt6779-keypad - fix hw code logic and row/col selection Mattijs Korpershoek
2022-07-07 7:52 ` [RESEND PATCH v3 1/2] Input: mt6779-keypad - match hardware matrix organization Mattijs Korpershoek
2022-07-07 7:52 ` [RESEND PATCH v3 2/2] Input: mt6779-keypad - implement row/column selection Mattijs Korpershoek
2022-07-08 21:58 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YsiofJQBZvLgQKSh@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=khilman@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mkorpershoek@baylibre.com \
--cc=parent.f@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).