From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C22FDC43334 for ; Mon, 11 Jul 2022 06:46:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ylHNnMSbPG8ddOx1lLuZkKlYfVYQr2dahptdCLSdrPk=; b=vzV+iCENwDe8CD J+q/q18vQVhqTNMQ2xQlt6m4B7gLXYEyIE0tOD4YIKqvVQbN7NfXCfz4hLxpqvdH9GxRKa7e/iG3v MYTZBF+SlCo8ceUpmrXGZVAlZLyzb02u6WhppGLH4F8ChjqIp6zCfrDU/Vl8WgKeBdZxQbQyQTX5c fiaIycD4H5qZgNQst2As9/jKP4dK1OtT16kxWy7NFUWbtGJIx/AUR1QhvmSBnMcnzH6Bw+WC3ogpi gOFk9i69/eTZz6Xb8HxemcsTCi8Q7kaN2pXCuIzNmrnO8BWwnjc8ZrRi5F2E+oWHOLo1kzDm6L5SU zNzcfNTlw86H1KdSNnbg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oAnAs-00GVGz-9w; Mon, 11 Jul 2022 06:45:42 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oAnAp-00GVGJ-Ev; Mon, 11 Jul 2022 06:45:40 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A79016120A; Mon, 11 Jul 2022 06:45:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 91FB0C34115; Mon, 11 Jul 2022 06:45:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1657521938; bh=Ovz0oMFCzUxed5tqrGHDygD5Uxy+oLIyQGwPoBJ7dOI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vIhTM/WIYvfvFd3tYQZQjY+xMo39WcW5td+wL9IHZfdBZoz6Mpp/KwcWBMhbSh8CY BvvQslaCEuWXbxaAkzC5+kxiZfadf4PAtdt17djEL7vZauScVSbf9bmRL9lS7ANnDQ 0gFHD1g4lCPL6vrluOhaNzNMyAzzR3UvVun+O0eQ= Date: Mon, 11 Jul 2022 08:45:35 +0200 From: Greg Kroah-Hartman To: Chunfeng Yun Cc: Matthias Brugger , linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Felipe Balbi , Eddie Hung Subject: Re: [PATCH 1/5] usb: mtu3: fix coverity of string buffer Message-ID: References: <20220708071903.25752-1-chunfeng.yun@mediatek.com> <9bbc0472bafa6116618e9861c3566d470c30c619.camel@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <9bbc0472bafa6116618e9861c3566d470c30c619.camel@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220710_234539_564348_5FD1C349 X-CRM114-Status: GOOD ( 12.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 11, 2022 at 02:39:10PM +0800, Chunfeng Yun wrote: > On Fri, 2022-07-08 at 09:26 +0200, Greg Kroah-Hartman wrote: > > On Fri, Jul 08, 2022 at 03:18:59PM +0800, Chunfeng Yun wrote: > > > Use snprintf instead of sprintf which could cause buffer overflow. > > > > How can it cause an overflow? > Maybe I didn't describe it clearly, this patch is used to fix coverity > check warning of string buffer, in fact no overflow happens. Then perhaps the coverity warning is useless and yet-another-false-positive that that tool is known to spit out? Don't make code changes just because broken tools say to do so. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel