From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EA28BC433EF for ; Mon, 11 Jul 2022 17:59:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UHnOQNBlyDTCtc2K/aX9UkEuWlOlwHPgSJrAE861Aq4=; b=LyMeY5Ai03/49k mzCA+g3XapcGiD6Vf5AyxYLKpmHrvrttv4CcUalT/QkY18kDfX9Ae6+EPPvZ6HaX6AnU2TE44N4fD +/dKhGu51YJ7PaXp2V+DbLpx2yQ2USleZmdipW1sKK6oryPOrNgpS9/UcZHn4rfX/Krp1c4Sb3So/ 54GHr6lFclWdFQAtzoacH2pRi1LuDbxT3dD4Kix17Zt5fBUndAvGGN8Snf2Wzo8elCpfGpM7mlqN1 E1AbPBaf7OlQK7SfgPz+WuH2Ka+DtLn6IeBSuUdYUA6vN5ZftblZBd3Y9FKEgK7z/8Be1+aSQ8vpS D6fYSjOlR5r+dSREkeeQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oAxfj-003gPW-Sn; Mon, 11 Jul 2022 17:58:16 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oAxfg-003gOP-Hh for linux-arm-kernel@lists.infradead.org; Mon, 11 Jul 2022 17:58:13 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8356B61496; Mon, 11 Jul 2022 17:58:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C8110C34115; Mon, 11 Jul 2022 17:58:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657562290; bh=dqKL1ZHaU9DALuFJcYhh0LDAOizflbirqGTWzM+maT8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bhdB18exvKnYksKC+IKTrJECibcSsYbwShPuYH36PhnpzakjoumTw6QKC6jm9PMSC A2QJ4mgqZElLiLa8Sz0Rmmsa3vqbfPZUwTgHSowQXozSd563rvgPsc1U8B4LHBmbYP Ux9yMxECgREQbQR0RWdgtn2i4qg5tXlv+vS7u0UbGGarYyTPlB+7k8viWcoEtz7MYA 9v6dxXx/JtQw1YKVo3oLaXbynbX/v2VC3Hzenosuk+59lHxDHbIHKEnXvmlkJssZIQ OcrdrUelZw5zvYgNgiz7LtmUL+OOyB/qJj7L+YmFsECWGuGV8LNGm+f2GUjEF8ROsQ bksOFZN5mSNTg== Date: Mon, 11 Jul 2022 17:58:09 +0000 From: Eric Biggers To: "Guozihua (Scott)" Cc: linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, herbert@gondor.apana.org.au, davem@davemloft.net, zengxianjun3@huawei.com, yunjia.wang@huawei.com Subject: Re: An inquire about a read out-of-bound found in poly1305-neon Message-ID: References: <65952163-6b78-a02a-ba14-933807d3cfec@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <65952163-6b78-a02a-ba14-933807d3cfec@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220711_105812_657402_78C65D59 X-CRM114-Status: GOOD ( 10.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 11, 2022 at 09:34:49PM +0800, Guozihua (Scott) wrote: > Directly calling poly1305_init_arm64 instead of poly1305_init_arch() is also > tried but it would fail the self-test as well. I think that's the correct fix. Are you sure it fails the self-test? It should look like: poly1305_init_arm64(&dctx->h, src); Just like the arm32 version in arch/arm/crypto/poly1305-glue.c. Note that &dctx->h must be used rather than just dctx. - Eric _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel