From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2AF3FC43334 for ; Mon, 11 Jul 2022 21:37:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1qFHgAxTB4OTGk03y2TliTvzoasQJjMNoc+YZulCj9M=; b=vnz2Pr7ckGKTYV fHc4oC+41pC4NymSnsiBEiCgm17datMD1s2WVZjqo3efEB9h2ohdkOB8AJNelyf/dZlSLeNQ8EZXJ G5PkId2oXcBE8h4nqIjvSvP/10+sAhQAiOLfv4h0BY/HJ9kSWaaagQndPpiN7TFXP5TaU6J+iVYIc FoypJHQcRmMmECIe3B8R3a9Q1nG8GeBgZp+4O34oze3PZAuJ2tuc5X+paaLCEeuRGWTK3Iy8ZhdTN r2AT2/02ASw40zGrWN+h/HCd6UvASEMHiGMfdO/88A96lAOFz1OIJzQEjWyGu8Pi1KuBh2h7b+YNW +Bdk7sYXryeM8qxB3U6g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oB14a-004yGc-Tx; Mon, 11 Jul 2022 21:36:09 +0000 Received: from mail-oi1-x241.google.com ([2607:f8b0:4864:20::241]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oB14X-004yAt-Fo for linux-arm-kernel@lists.infradead.org; Mon, 11 Jul 2022 21:36:06 +0000 Received: by mail-oi1-x241.google.com with SMTP id r82so8303674oig.2 for ; Mon, 11 Jul 2022 14:36:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vanguardiasur-com-ar.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=W1lfMFF7GwisucHEs2WhdN/ngSj9xjvJck8CvmDPr8Q=; b=m3zlf3eaY+ozNxIYDmb53Dyn4cP8iN10VPE2PcHMMkNQ9B2QriL/uoXD3KinNbSCAf R/jGyCPjVfs+Y/AURJLDM3VfiBz+w/TJUmx1mPLs5NfjNaUicM/sJBmLH7oa78GdqTRd dCfTnoM1Y/xR0GDVkc+OMWaXuozZ8hXrGWyFj3Oc8s9x/D7hYkqVt7waYUXceAKyQYBR hJGiu3OXz4anUqmK+YnlzMOskhRFOwH68SeARH3VE9rqYgvskwyPmoxINBIWCoKpQqS5 ZS5z+fQYqavQg+9MF6Bgtw4OiOxkzfd4UPKbX12r6/rTuAJsMPguquCbHZi1YOP5NHGG CIXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=W1lfMFF7GwisucHEs2WhdN/ngSj9xjvJck8CvmDPr8Q=; b=oJsThdkKxZd/OtG+Lwz8sWYg6xKTAYK09TdL3ZCUbsj77BvByk9aQvmy7wxoS7YEkh rTXyN56Lc/fTzWwNwN2OkkPpHB2AYccKgeFdbrfM6WQIuKEXMuYz54+6+hIIOi0WmKzM /VuFM6iz7WpksgtEnKY4eiFst/6SU+p/FHq/2XjeewS7mP9YC6WYOG9QSq9SSO8WTnET wZdbdras0rc6XZ6aKy+1TFuH1WqTLAT93m9Yqy4oE34/pP7rH05G/RExz3UVtq6pVY+I rq/DvPh0XHtHb6yzoRQvmw1UkZ8ZHJ6j69HBtvk6TAHxw5EazGjGBgLvS4//Q1125wYd mlig== X-Gm-Message-State: AJIora+fyFUTifXDfS/fyt+XWeD9gEkmeue+WUGuwQKwPYyNe6OupSEU azbrDAZJFUW/DL1XvGt0rnl5fta/bl7BXVFeqWQ= X-Google-Smtp-Source: AGRyM1ukzkSjiYh6xdbkafb6/cn72eoJoX+cxrroy+Ym4I4X16AsdivaNNxd+cGYK6dsX/hak9UA+A== X-Received: by 2002:a05:6808:2127:b0:335:9807:959e with SMTP id r39-20020a056808212700b003359807959emr251350oiw.270.1657575363633; Mon, 11 Jul 2022 14:36:03 -0700 (PDT) Received: from eze-laptop ([190.190.187.68]) by smtp.gmail.com with ESMTPSA id cj8-20020a0568081b8800b00339e4ca6a15sm3239334oib.45.2022.07.11.14.36.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Jul 2022 14:36:03 -0700 (PDT) Date: Mon, 11 Jul 2022 18:35:57 -0300 From: Ezequiel Garcia To: Jernej Skrabec Cc: mripard@kernel.org, paul.kocialkowski@bootlin.com, wens@csie.org, samuel@sholland.org, mchehab@kernel.org, gregkh@linuxfoundation.org, hverkuil-cisco@xs4all.nl, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/7] media: cedrus: Improve error messages for controls Message-ID: References: <20220620175517.648767-1-jernej.skrabec@gmail.com> <20220620175517.648767-4-jernej.skrabec@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220620175517.648767-4-jernej.skrabec@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220711_143605_546626_E76EE3B2 X-CRM114-Status: GOOD ( 16.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 20, 2022 at 07:55:13PM +0200, Jernej Skrabec wrote: > Currently error messages when control creation fails are very sparse. > Granted, user should never observe them. However, developer working on > codecs can. In such cases additional information like which control > creation failed and error number are very useful. > > Expand error messages with additional info. > > Signed-off-by: Jernej Skrabec Reviewed-by: Ezequiel Garcia > --- > drivers/staging/media/sunxi/cedrus/cedrus.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/media/sunxi/cedrus/cedrus.c b/drivers/staging/media/sunxi/cedrus/cedrus.c > index b12219123a6b..99c87319d2b4 100644 > --- a/drivers/staging/media/sunxi/cedrus/cedrus.c > +++ b/drivers/staging/media/sunxi/cedrus/cedrus.c > @@ -242,7 +242,8 @@ static int cedrus_init_ctrls(struct cedrus_dev *dev, struct cedrus_ctx *ctx) > v4l2_ctrl_handler_init(hdl, CEDRUS_CONTROLS_COUNT); > if (hdl->error) { > v4l2_err(&dev->v4l2_dev, > - "Failed to initialize control handler\n"); > + "Failed to initialize control handler: %d\n", > + hdl->error); > return hdl->error; > } > > @@ -257,7 +258,9 @@ static int cedrus_init_ctrls(struct cedrus_dev *dev, struct cedrus_ctx *ctx) > NULL); > if (hdl->error) { > v4l2_err(&dev->v4l2_dev, > - "Failed to create new custom control\n"); > + "Failed to create %s control: %d\n", > + v4l2_ctrl_get_name(cedrus_controls[i].cfg.id), > + hdl->error); > > v4l2_ctrl_handler_free(hdl); > kfree(ctx->ctrls); > -- > 2.36.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel