From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2D311C43334 for ; Tue, 26 Jul 2022 12:51:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=boKffwcqvH2cvF7V/aVHd5XLvekt63T10jdWdavo+ik=; b=LeMcAwhtyXix/p MKrAqqy+wCrYT0t4sA6ch5Hyyyoyh48WlgWhFjyCK9fzRit5XYJlHhm+hg2J4qvwd0OoWVGi55f6x I6Oh980c0V2IUfSXFCq86YkZE7ObHAgkzIjDU49A2hP/4AeEHpcHnXPH1J/meIydznH0ftVP2HMYn r2NMFJyLKYhUbWtVOupdTaq5WhXYYn2UTtwGcJHV4+RLVqu/pq6DwsU4uhwrn75lGEZA1CW08fkS2 MVNR0UTyFWLerNRoLLpoY6SlmAtbUVdJlD0KIQyKMHc6EhtEY/nRvz8R+NVYyY3F3fUtbaRrwR4dS MwRnZAPEwbiziLFQZotA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oGK0u-00H5VF-2n; Tue, 26 Jul 2022 12:50:16 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oGK0q-00H5Tl-Ta for linux-arm-kernel@lists.infradead.org; Tue, 26 Jul 2022 12:50:14 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A5DF61FB; Tue, 26 Jul 2022 05:50:11 -0700 (PDT) Received: from FVFF77S0Q05N (unknown [10.57.87.225]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 23D0B3F70D; Tue, 26 Jul 2022 05:50:10 -0700 (PDT) Date: Tue, 26 Jul 2022 13:50:06 +0100 From: Mark Rutland To: Sudeep Holla Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Peter Zijlstra Subject: Re: [-next] Lockdep warnings Message-ID: References: <20220726104134.3b3awfphvafljdgp@bogus> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220726_055013_054575_B520640F X-CRM114-Status: GOOD ( 18.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jul 26, 2022 at 01:40:40PM +0100, Mark Rutland wrote: > [Adding Peter; I suspect this is due to the cpuidle rework] Looking again I see the cpuidle rework isn't in next, so evidently not... Sorry for the noise! Mark. > > I'll go give next a spin in a VM, but I suspect I might need real HW to see > this due to the way PSCI idle states work. > > Mark. > > On Tue, Jul 26, 2022 at 11:41:34AM +0100, Sudeep Holla wrote: > > I was seeing the below lockdep warnings on my arm64 Juno development > > platform almost 2 weeks back with -next. I wanted to check for similar > > reports before post and forgot. > > > > --->8 > > > > DEBUG_LOCKS_WARN_ON(lockdep_hardirqs_enabled()) > > hardirqs last enabled at (46157): cpuidle_enter_state+0x174/0x2b4 > > WARNING: CPU: 5 PID: 0 at kernel/locking/lockdep.c:5506 check_flags+0x90/0x1e8 > > hardirqs last disabled at (46158): el1_interrupt+0x2c/0xc8 > > Modules linked in: > > softirqs last enabled at (46154): __do_softirq+0x2c0/0x388 > > softirqs last disabled at (46139): __irq_exit_rcu+0x118/0x18c > > CPU: 5 PID: 0 Comm: swapper/5 Not tainted 5.19.0-rc6-next-20220714 #9 > > pstate: 600000c5 (nZCv daIF -PAN -UAO -TCO -DIT -SSBS BTYPE=--) > > pc : check_flags+0x90/0x1e8 > > lr : check_flags+0x90/0x1e8 > > Call trace: > > check_flags+0x90/0x1e8 > > lock_is_held_type+0x80/0x164 > > rcu_read_lock_sched_held+0x40/0x7c > > trace_rcu_dyntick+0x5c/0x140 > > ct_kernel_enter+0x78/0xd4 > > ct_idle_exit+0x1c/0x44 > > cpu_idle_poll+0x74/0xb8 > > do_idle+0x90/0x2c4 > > cpu_startup_entry+0x30/0x34 > > secondary_start_kernel+0x130/0x144 > > __secondary_switched+0xb0/0xb4 > > irq event stamp: 64229 > > hardirqs last enabled at (64229): cpu_idle_poll+0x40/0xb8 > > hardirqs last disabled at (64228): do_idle+0xbc/0x2c4 > > softirqs last enabled at (64190): __do_softirq+0x2c0/0x388 > > softirqs last disabled at (64185): __irq_exit_rcu+0x118/0x18c > > ---[ end trace 0000000000000000 ]--- > > possible reason: unannotated irqs-off. > > irq event stamp: 64229 > > hardirqs last enabled at (64229): cpu_idle_poll+0x40/0xb8 > > hardirqs last disabled at (64228): do_idle+0xbc/0x2c4 > > softirqs last enabled at (64190): __do_softirq+0x2c0/0x388 > > softirqs last disabled at (64185): __irq_exit_rcu+0x118/0x18c > > > > ---- > > > > However I don't see the above warning with the latest -next. When I tried > > yesterday's -next now, I see a different warning. Not sure if they are > > related. I haven't tried to bisect. > > > > --->8 > > ============================= > > [ BUG: Invalid wait context ] > > 5.19.0-rc8-next-20220725 #38 Not tainted > > ----------------------------- > > swapper/0/0 is trying to lock: > > (&drvdata->spinlock){....}-{3:3}, at: cti_cpu_pm_notify+0x54/0x114 > > other info that might help us debug this: > > context-{5:5} > > 1 lock held by swapper/0/0: > > #0: (cpu_pm_notifier.lock){....}-{2:2}, at: cpu_pm_enter+0x2c/0x80 > > stack backtrace: > > CPU: 0 PID: 0 Comm: swapper/0 Not tainted 5.19.0-rc8-next-20220725-00004-g599e6691ed8c #38 > > Call trace: > > dump_backtrace+0xe8/0x108 > > show_stack+0x18/0x4c > > dump_stack_lvl+0x90/0xc8 > > dump_stack+0x18/0x54 > > __lock_acquire+0xa70/0x32d0 > > lock_acquire+0x160/0x308 > > _raw_spin_lock+0x60/0xa0 > > cti_cpu_pm_notify+0x54/0x114 > > raw_notifier_call_chain_robust+0x50/0xd4 > > cpu_pm_enter+0x48/0x80 > > psci_enter_idle_state+0x34/0x74 > > cpuidle_enter_state+0x120/0x2a8 > > cpuidle_enter+0x38/0x50 > > do_idle+0x1e8/0x2b8 > > cpu_startup_entry+0x24/0x28 > > kernel_init+0x0/0x1a0 > > start_kernel+0x0/0x470 > > start_kernel+0x34c/0x470 > > __primary_switched+0xbc/0xc4 > > > > ---- > > > > -- > > Regards, > > Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel