Re: [PATCH v2 3/9] arm64: dts: bcmbca: update BCM4908 board dts files

William Zhang
2022-07-26T01:10:49Z

[-- Attachment #1.1: Type: text/plain, Size: 3755 bytes --]

Hi Rob,

On 07/25/2022 04:32 PM, Rob Herring wrote:
> On Sun, Jul 24, 2022 at 10:53:56PM -0700, William Zhang wrote:
>> Append "brcm,bcmbca" to compatible strings based on the new bcmbca
>> binding rule for BCM4908 family based boards. This will break drivers
>> that use the old compatible string for binding. Fortunately there is no
>> such usage in linux and u-boot.
>
> How does adding an additional compatible break things?
> In theory when some crazy code tries to match the entire string. But not
in linux, u-boot code and hopefully not in other bootloader and Os does
that. But this does change an existing compatible string so Krzysztof
suggested to add comment about the breakage in the commit message. I can
remove this and send v3 if you guys think it is necessary.

>>
>> Signed-off-by: William Zhang <william.zhang@broadcom.com>
>> Acked-by: Rafał Miłecki <rafal@milecki.pl>
>>
>> ---
>>
>> Changes in v2:
>> - Add Acked-by tag
>>
>> arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-netgear-r8000p.dts | 2 +-
>> .../dts/broadcom/bcm4908/bcm4906-tplink-archer-c2300-v1.dts | 2 +-
>> arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-asus-gt-ac5300.dts | 2 +-
>> .../arm64/boot/dts/broadcom/bcm4908/bcm4908-netgear-raxe500.dts | 2 +-
>> 4 files changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-netgear-r8000p.dts b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-netgear-r8000p.dts
>> index 2dd028438c22..d8b60575eb4f 100644
>> --- a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-netgear-r8000p.dts
>> +++ b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-netgear-r8000p.dts
>> @@ -7,7 +7,7 @@
>> #include "bcm4906.dtsi"
>>
>> / {
>> - compatible = "netgear,r8000p", "brcm,bcm4906", "brcm,bcm4908";
>> + compatible = "netgear,r8000p", "brcm,bcm4906", "brcm,bcm4908", "brcm,bcmbca";
>> model = "Netgear R8000P";
>>
>> memory@0 {
>> diff --git a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-tplink-archer-c2300-v1.dts b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-tplink-archer-c2300-v1.dts
>> index 064f7f549665..296393d4aaab 100644
>> --- a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-tplink-archer-c2300-v1.dts
>> +++ b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-tplink-archer-c2300-v1.dts
>> @@ -7,7 +7,7 @@
>> #include "bcm4906.dtsi"
>>
>> / {
>> - compatible = "tplink,archer-c2300-v1", "brcm,bcm4906", "brcm,bcm4908";
>> + compatible = "tplink,archer-c2300-v1", "brcm,bcm4906", "brcm,bcm4908", "brcm,bcmbca";
>> model = "TP-Link Archer C2300 V1";
>>
>> memory@0 {
>> diff --git a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-asus-gt-ac5300.dts b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-asus-gt-ac5300.dts
>> index 04f8524b5335..787c7ddf9102 100644
>> --- a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-asus-gt-ac5300.dts
>> +++ b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-asus-gt-ac5300.dts
>> @@ -6,7 +6,7 @@
>> #include "bcm4908.dtsi"
>>
>> / {
>> - compatible = "asus,gt-ac5300", "brcm,bcm4908";
>> + compatible = "asus,gt-ac5300", "brcm,bcm4908", "brcm,bcmbca";
>> model = "Asus GT-AC5300";
>>
>> memory@0 {
>> diff --git a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-netgear-raxe500.dts b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-netgear-raxe500.dts
>> index 3c2cf2d238b6..23b96c663239 100644
>> --- a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-netgear-raxe500.dts
>> +++ b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-netgear-raxe500.dts
>> @@ -3,7 +3,7 @@
>> #include "bcm4908.dtsi"
>>
>> / {
>> - compatible = "netgear,raxe500", "brcm,bcm4908";
>> + compatible = "netgear,raxe500", "brcm,bcm4908", "brcm,bcmbca";
>> model = "Netgear RAXE500";
>>
>> memory@0 {
>> --
>> 2.34.1
>>
>
>