From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D247CC433EF for ; Thu, 14 Jul 2022 18:06:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=y4CdZ/uZyglCWR+7sGA9+7lHuX5PIyEvj3KjiYKtuc4=; b=BIYH3QPQCi4T2o O4eMUIk8sXTlglHYhCYnRP2KZuaJjYHMfisLFODlnVOYm4d5KpBxtFEpCGMxW0TdSngukhuo4XtRn Nlns3A6V5CSwJxTvfzue/w+39LX8r5HarlKrdEMgn9u2Sogqz56UROTvakXAPF+K5H+Yi0yfcChXi +jffMfOcxWWNf6s6aLXp+nkJCP+P3xlsXnQD5i+GNHqjuLYEn+wmA9GW0/cVs8N+1XySxPbptJ7eW 1OUGWv/0vXUYZzl6I61acxGVtobxyCSni+AhzEfqGSs8ldPjQAFnG65Gu+F6FB/TIMi902XeEKS7/ dtKuq/TMDdhPZ1Q/PhtQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oC3DB-00Gyhj-1N; Thu, 14 Jul 2022 18:05:17 +0000 Received: from wnew4-smtp.messagingengine.com ([64.147.123.18]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oC3D7-00GyeL-Lv for linux-arm-kernel@lists.infradead.org; Thu, 14 Jul 2022 18:05:15 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.west.internal (Postfix) with ESMTP id B46A62B0597F; Thu, 14 Jul 2022 14:05:06 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Thu, 14 Jul 2022 14:05:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pjd.dev; h=cc:cc :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1657821906; x=1657825506; bh=/iwEYxigdE FuJz5vUQfpajKlKQ642prMXuR8LsWTJx4=; b=dsP1dcOwic3v090lBty7m6YW4K atHGONu7Led0sjHJZWelPCHgNq9BtvCXoAlawZinMH7q+4MLV+52lyecfKvPC8fo zDfpaHKoD7N4x9QIEogUA3YYhUPI042cDS3aVqc9eYzN2bQnV2YPDegWsrwQZwSY RhM57rkIgthJXPb4Wy1ZOBg0+bWYEsEv0YEfGaIJT016haemk3WFPXeACzgkZ7qG sy2nB6v9CtYohh4fKzjj4BAWOupA0ZjkEoB3UU9ad/DQHG3PoPrlNZZVJwputKnW LjZ2+/f1VO9Q0MfgWXf//Ho20NDcsQ0qaoNE6wp8RN5gWaZGWA2XpqCknHkA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1657821906; x=1657825506; bh=/iwEYxigdEFuJz5vUQfpajKlKQ64 2prMXuR8LsWTJx4=; b=uiftyfxJnwG7Wl8vGOUO9ZiZhGBb7O5yZVTr+YdQmAC9 cTNgOu9DZTtAOac1txGWodXuHV3b6JEDgm0s7X01WTzoLieBZiO1GFhd0N/gqppM sVid7qPRakRVkow4ZFiOPrQnfWReuW5I9pyV0NWeIwWdfE9JnL6YN+Aa1Biq0e05 A1WWLT/D4dKfeJn7f8ORNcmbpE1JcmVdbQykxPHPp7kjXkv7fncj2t61M12n5Xko V1/PcGuPHiGSPdfd9G+DTTnOhFGbcRVXKIAQEbno6LBnkcXjgsOzIK4nRjbm8XYf 7wIj5LvH0PmfXt7bDLYCo9LF8V4j/hVdfS7BYcRCtg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudejledguddvudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefrvght vghrucffvghlvghvohhrhigrshcuoehpvghtvghrsehpjhgurdguvghvqeenucggtffrrg htthgvrhhnpeevgfehgedvvdekveeifeekjeduueetieegvdeitedvffdvgffhjeekveek tdehfeenucffohhmrghinhepghhithhhuhgsrdgtohhmnecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomhepphgvthgvrhesphhjugdruggvvh X-ME-Proxy: Feedback-ID: i9e814621:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 14 Jul 2022 14:05:03 -0400 (EDT) Date: Thu, 14 Jul 2022 11:05:01 -0700 From: Peter Delevoryas To: Arnd Bergmann Cc: Logananth Sundararaj , DTML , linux-aspeed , Andrew Jeffery , OpenBMC Maillist , Linux Kernel Mailing List , naveen.mosess@hcl.com, thangavel.k@hcl.com, SoC Team , Rob Herring , Joel Stanley , Olof Johansson , garnermic@gmail.com, velumanit@hcl.com, Linux ARM Subject: Re: [PATCH v3] The Yosemite V3.5 is a facebook multi-node server platform that host four OCP server. The BMC in the Yosemite V3.5 platform based on AST2600 SoC. Message-ID: References: <20220707132054.GA10610@logan-ThinkPad-T14-Gen-1> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220714_110514_152632_BCAD66E6 X-CRM114-Status: GOOD ( 23.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jul 07, 2022 at 03:33:48PM +0200, Arnd Bergmann wrote: > On Thu, Jul 7, 2022 at 3:20 PM Logananth Sundararaj > wrote: > > > > This patch adds linux device tree entry related to > > Yosemite V3.5 specific devices connected to BMC SoC. > > > > Signed-off-by: Logananth Sundararaj > > > Something went wrong with the patch description, it looks like you dropped > the subject and sent the first paragraph as the subject instead. > > > +/ { > > + model = "Facebook fby35"; > > + compatible = "facebook,fby35", "aspeed,ast2600"; > > + > > + aliases { > > + serial4 = &uart5; > > + }; > > Why not start at serial0 here? Hey, Facebook person jumping in here (using a personal email): I think you're right, it should be like this: aliases { serial0 = &uart5; serial1 = &uart1; serial2 = &uart2; serial3 = &uart3; serial4 = &uart4; }; > > > + chosen { > > + stdout-path = &uart5; > > + bootargs = "console=ttyS4,57600n8 root=/dev/ram rw vmalloc=384M"; > > + }; Also: if we do serial0 = &uart5, it should be console=ttyS0, not ttyS4. > > The bootargs should really come from the boot loader. What if we want to boot the kernel by itself with QEMU? It's kinda annoying to have to specify '-append "console=ttyS0,57600n8...' everytime, or to have to use a wrapper script. But, it's also a source of bugs: I realized yesterday the dts we were using here: https://github.com/facebook/openbmc-linux/blob/e26c76992e0761d9e440ff514538009384c094b4/arch/arm/boot/dts/aspeed-bmc-facebook-fby35.dts Has the wrong console setting. Booting the kernel directly is actualy really useful for us, because U-Boot literally takes 4+ minutes in QEMU because we execute in-place from flash for most of it. > > Why do you need the vmalloc=384M? That seems excessive. Yeah I'm not sure what that is about, would need to find the person who wrote this originally. Speaking of which: The dts I linked above, from our repo, how come this patch is not just a copy of that? > > > + > > + memory@80000000 { > > + device_type = "memory"; > > + reg = <0x80000000 0x80000000>; > > + }; > > The memory location and size is usually also set by the boot loader Yeah not sure what happens if I remove this and boot the kernel directly in QEMU, would we need to specify the RAM size explicitly in console args? Hmmm, I'll check it out. Thanks for your comments! Peter > > Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel