From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3F492C04A68 for ; Wed, 27 Jul 2022 16:02:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TGxGQg+2Vi+A9qe8SBnxoxRso7pTeTSg+ouPBRpl1uw=; b=P6xQ4tonGL7FPf CEkMPsXk1g2HD7sbNDZb3dU4qY7F1t056bJDWUtoWjHtY1Xa+ha5qOVFggZjNTBWpj/t2iGhbzaPf kU45nDDsS3OBxPsb1i/XbfmDR018R1S6gKC7VxI02WEds2IQq7g+0pcvBVey2wxdpY84ZO7UO9Iil dhd/C0v0aaGEANlFhc+MloRH34HUD3Sun6xnTISoU09qc0QGKEUPSWMsGevLS6Qi3NdpSYWyHZUhJ IaGPusHGW8Prezsi9F22XGnRChTAqXNWzNrlbqCfGp++LM56xV5NM+zVc7qevVBkF0oBXGxJuFBgD mLw9GOcXy3Yj/r7V80qQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oGjTp-00FJPE-3C; Wed, 27 Jul 2022 16:01:49 +0000 Received: from out0.migadu.com ([2001:41d0:2:267::]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oGjTj-00FJKm-DV for linux-arm-kernel@lists.infradead.org; Wed, 27 Jul 2022 16:01:46 +0000 Date: Wed, 27 Jul 2022 16:01:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1658937701; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MIVHqmVT6XDFh0scJsMUAJJN5QiOkyZcHL6zatK40GI=; b=pf/jpd6W/zgUqZ06ofNtfuD9HllnMfiRTormw96GjNDkX8MLvy4eJcvM8Y4ku1aua8lnO4 iwhIu9WoGeJfUXN/v2RTQGVLgabWVUnlsDf+fhkcFiJp5cNv22CZIG3FBbQteS3NCtAXIa BB7xDgLzFurRCGkyTWkMnIC+rZ74rqA= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Marc Zyngier Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, mark.rutland@arm.com, broonie@kernel.org, madvenka@linux.microsoft.com, tabba@google.com, qperret@google.com, kaleshsingh@google.com, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, andreyknvl@gmail.com, vincenzo.frascino@arm.com, mhiramat@kernel.org, ast@kernel.org, wangkefeng.wang@huawei.com, elver@google.com, keirf@google.com, yuzenghui@huawei.com, ardb@kernel.org, kernel-team@android.com Subject: Re: [PATCH 0/6] KVM: arm64: nVHE stack unwinder rework Message-ID: References: <20220726073750.3219117-18-kaleshsingh@google.com> <20220727142906.1856759-1-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220727142906.1856759-1-maz@kernel.org> X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220727_090144_191496_60FC6E23 X-CRM114-Status: GOOD ( 16.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jul 27, 2022 at 03:29:00PM +0100, Marc Zyngier wrote: > Hi all, > > As Kalesh's series[1] already went through quite a few rounds and that > it has proved to be an extremely useful debugging help, I'd like to > queue it for 5.20. > > However, there is a couple of nits that I'd like to address: > > - the code is extremely hard to follow, due to the include maze and > the various levels of inline functions that have forward > declarations... > > - there is a subtle bug in the way the kernel on_accessible_stack() > helper has been rewritten > > - the config symbol for the protected unwinder is oddly placed > > Instead of going for another round and missing the merge window, I > propose to stash the following patches on top, which IMHO result in > something much more readable. > > This series directly applies on top of Kalesh's. > > [1] https://lore.kernel.org/r/20220726073750.3219117-1-kaleshsingh@google.com For the series (besides my own patch of course): Reviewed-by: Oliver Upton -- Thanks, Oliver _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel