From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Baruch Siach <baruch@tkos.co.il>
Cc: Ard Biesheuvel <ardb@kernel.org>, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: traps: print un-hashed user pc on undefined instruction
Date: Thu, 28 Jul 2022 16:23:17 +0100 [thread overview]
Message-ID: <YuKp5V815WT/WCG4@shell.armlinux.org.uk> (raw)
In-Reply-To: <515f8c621449e0f9aa7d11f998ce010676ba35fd.1658938681.git.baruch@tkos.co.il>
On Wed, Jul 27, 2022 at 07:18:01PM +0300, Baruch Siach wrote:
> When user undefined instruction debug is enabled pc value is hashed like
> kernel pointers for security reason. But the security benefit of this
> hash is very limited because the code goes on to call __show_regs() that
> prints the plain pointer value. pc is a user pointer anyway, so the
> kernel does not leak anything. The only result is confusion about the
> difference between the pc value on the first printed line, and the value
> that __show_regs() prints.
>
> Always print the plain value of pc.
>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Looks sensible to me. Please drop it in the patch system, thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-07-28 15:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-27 16:18 [PATCH] ARM: traps: print un-hashed user pc on undefined instruction Baruch Siach
2022-07-28 15:23 ` Russell King (Oracle) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YuKp5V815WT/WCG4@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=ardb@kernel.org \
--cc=baruch@tkos.co.il \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).